[PATCH 1/5] Add comment for struct mutex definition.

[PATCH 1/5] Add comment for struct mutex definition.

[Tamara Diaconita]

Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
---
 drivers/staging/media/cxd2099/cxd2099.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/cxd2099/cxd2099.c b/drivers/staging/media/cxd2099/cxd2099.c
index c72c3f0..f88690b 100644
--- a/drivers/staging/media/cxd2099/cxd2099.c
+++ b/drivers/staging/media/cxd2099/cxd2099.c
@@ -54,7 +54,7 @@ struct cxd {
 	int    amem_read;
 
 	int    cammode;
-	struct mutex lock;
+	struct mutex lock;/*lock for digital devices*/
 };
 
 static int i2c_write_reg(struct i2c_adapter *adapter, u8 adr,
-- 
2.9.3

Re: [Outreachy kernel] [PATCH 1/5] Add comment for struct mutex definition.

[Julia Lawall]

On Tue, 28 Feb 2017, Tamara Diaconita wrote:

> Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
> ---
>  drivers/staging/media/cxd2099/cxd2099.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/cxd2099/cxd2099.c b/drivers/staging/media/cxd2099/cxd2099.c
> index c72c3f0..f88690b 100644
> --- a/drivers/staging/media/cxd2099/cxd2099.c
> +++ b/drivers/staging/media/cxd2099/cxd2099.c
> @@ -54,7 +54,7 @@ struct cxd {
>  	int    amem_read;
>
>  	int    cammode;
> -	struct mutex lock;
> +	struct mutex lock;/*lock for digital devices*/

Comments should have at least one space before, a space after the /* and a
space before the */.

More importantly, it would be good to justify the choice of text for the
comment in some way.  Digital devices does not seem very specific.

julia

>  };
>
>  static int i2c_write_reg(struct i2c_adapter *adapter, u8 adr,
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170228182154.25401-1-diaconita.tamara%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [PATCH 1/5] Add comment for struct mutex definition.

[Greg KH]

On Tue, Feb 28, 2017 at 08:21:54PM +0200, Tamara Diaconita wrote:
> Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
> ---
>  drivers/staging/media/cxd2099/cxd2099.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot