All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alison Schofield <amsfield22@gmail.com>
To: Tamara Diaconita <diaconitatamara@gmail.com>
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org,
	outreachy-kernel@googlegroups.com,
	Tamara Diaconita <diaconita.tamara@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH 0/5] Fixing multiple checkpath issues
Date: Tue, 28 Feb 2017 12:11:46 -0800	[thread overview]
Message-ID: <20170228201145.GA19234@d830.WORKGROUP> (raw)
In-Reply-To: <20170228181756.22863-1-diaconita.tamara@gmail.com>

On Tue, Feb 28, 2017 at 08:17:56PM +0200, Tamara Diaconita wrote:
> Made cxd2099.c file from cxd2099 driver more readable by fixing multiple checkpath issues.
> 
> Tamara Diaconita (5):
>   Add comment for struct mutex definition.
>   Added spaces around arithmetical operators.
>   Removed unnecessary blank lines.
>   Change a kzalloc parameter.
>   emoved redundant code.
> 
>  drivers/staging/media/cxd2099/cxd2099.c | 96 +++++----------------------------
>  1 file changed, 13 insertions(+), 83 deletions(-)

Hi Tamra -
I can see you have the suggestions on how to improve this patchset from
gregkh and julia, but let me offer one more thing:  This looks like your
first patch?  We try to encourage applicants to start with a single
patch to workout the mechanical details of patching and after they have
that working well, move onto doing small patchsets.
Perhaps you can pull one of these out, correct it, and get it accepted
as a single patch as a first step.
alisons

> 
> -- 
> 2.9.3
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170228181756.22863-1-diaconita.tamara%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.


      parent reply	other threads:[~2017-02-28 20:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28 18:17 [PATCH 0/5] Fixing multiple checkpath issues Tamara Diaconita
2017-02-28 18:34 ` Greg KH
2017-02-28 20:11 ` Alison Schofield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170228201145.GA19234@d830.WORKGROUP \
    --to=amsfield22@gmail.com \
    --cc=diaconita.tamara@gmail.com \
    --cc=diaconitatamara@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=mchehab@kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.