[PATCH 0/5] Fixing multiple checkpath issues

[PATCH 0/5] Fixing multiple checkpath issues

[Tamara Diaconita]

Made cxd2099.c file from cxd2099 driver more readable by fixing multiple checkpath issues.

Tamara Diaconita (5):
  Add comment for struct mutex definition.
  Added spaces around arithmetical operators.
  Removed unnecessary blank lines.
  Change a kzalloc parameter.
  emoved redundant code.

 drivers/staging/media/cxd2099/cxd2099.c | 96 +++++----------------------------
 1 file changed, 13 insertions(+), 83 deletions(-)

-- 
2.9.3

Re: [PATCH 0/5] Fixing multiple checkpath issues

[Greg KH]

On Tue, Feb 28, 2017 at 08:17:56PM +0200, Tamara Diaconita wrote:
> Made cxd2099.c file from cxd2099 driver more readable by fixing multiple checkpath issues.
> 
> Tamara Diaconita (5):
>   Add comment for struct mutex definition.
>   Added spaces around arithmetical operators.
>   Removed unnecessary blank lines.
>   Change a kzalloc parameter.
>   emoved redundant code.
> 
>  drivers/staging/media/cxd2099/cxd2099.c | 96 +++++----------------------------
>  1 file changed, 13 insertions(+), 83 deletions(-)

My "patch bot" found problems with the first one, and the same thing
goes for all of the other 4 as well.  Please fix up and resend, as a
series that is linked together so it is easy to see in an email client
(this happens if you use git-send-email).

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH 0/5] Fixing multiple checkpath issues

[Alison Schofield]

On Tue, Feb 28, 2017 at 08:17:56PM +0200, Tamara Diaconita wrote:
> Made cxd2099.c file from cxd2099 driver more readable by fixing multiple checkpath issues.
> 
> Tamara Diaconita (5):
>   Add comment for struct mutex definition.
>   Added spaces around arithmetical operators.
>   Removed unnecessary blank lines.
>   Change a kzalloc parameter.
>   emoved redundant code.
> 
>  drivers/staging/media/cxd2099/cxd2099.c | 96 +++++----------------------------
>  1 file changed, 13 insertions(+), 83 deletions(-)

Hi Tamra -
I can see you have the suggestions on how to improve this patchset from
gregkh and julia, but let me offer one more thing:  This looks like your
first patch?  We try to encourage applicants to start with a single
patch to workout the mechanical details of patching and after they have
that working well, move onto doing small patchsets.
Perhaps you can pull one of these out, correct it, and get it accepted
as a single patch as a first step.
alisons

> 
> -- 
> 2.9.3
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170228181756.22863-1-diaconita.tamara%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.