From: "Michael S. Tsirkin" <mst@redhat.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: kernel-team@fb.com, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Amit Shah <amit@kernel.org>
Subject: Re: [PATCH] virtio-console: avoid DMA from stack
Date: Wed, 1 Mar 2017 23:25:14 +0200 [thread overview]
Message-ID: <20170301232508-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20170301200110.GA24754@vader.dhcp.thefacebook.com>
On Wed, Mar 01, 2017 at 12:01:10PM -0800, Omar Sandoval wrote:
> On Wed, Feb 01, 2017 at 07:17:12PM +0530, Amit Shah wrote:
> > On (Wed) 01 Feb 2017 [00:02:27], Omar Sandoval wrote:
> > > From: Omar Sandoval <osandov@fb.com>
> > >
> > > put_chars() stuffs the buffer it gets into an sg, but that buffer may be
> > > on the stack. This breaks with CONFIG_VMAP_STACK=y (for me, it
> > > manifested as printks getting turned into NUL bytes).
> >
> > Seems reasonable. I wonder since all implementations of hvc do a
> > memcpy, if we can abstract it - but that'll need some work.
> >
> > Reviewed-by: Amit Shah <amit.shah@redhat.com>
> >
> > Michael, please add to the virtio queue.
> >
> > Amit
>
> Hi, Michael,
>
> I don't see this in Linus' master or in your git tree, is it going to go
> in for -rc1?
>
> Thanks.
Yes.
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: Amit Shah <amit@kernel.org>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] virtio-console: avoid DMA from stack
Date: Wed, 1 Mar 2017 23:25:14 +0200 [thread overview]
Message-ID: <20170301232508-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20170301200110.GA24754@vader.dhcp.thefacebook.com>
On Wed, Mar 01, 2017 at 12:01:10PM -0800, Omar Sandoval wrote:
> On Wed, Feb 01, 2017 at 07:17:12PM +0530, Amit Shah wrote:
> > On (Wed) 01 Feb 2017 [00:02:27], Omar Sandoval wrote:
> > > From: Omar Sandoval <osandov@fb.com>
> > >
> > > put_chars() stuffs the buffer it gets into an sg, but that buffer may be
> > > on the stack. This breaks with CONFIG_VMAP_STACK=y (for me, it
> > > manifested as printks getting turned into NUL bytes).
> >
> > Seems reasonable. I wonder since all implementations of hvc do a
> > memcpy, if we can abstract it - but that'll need some work.
> >
> > Reviewed-by: Amit Shah <amit.shah@redhat.com>
> >
> > Michael, please add to the virtio queue.
> >
> > Amit
>
> Hi, Michael,
>
> I don't see this in Linus' master or in your git tree, is it going to go
> in for -rc1?
>
> Thanks.
Yes.
next prev parent reply other threads:[~2017-03-01 21:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 8:02 [PATCH] virtio-console: avoid DMA from stack Omar Sandoval
2017-02-01 8:02 ` Omar Sandoval
2017-02-01 13:47 ` Amit Shah
2017-02-01 13:47 ` Amit Shah
2017-03-01 20:01 ` Omar Sandoval
2017-03-01 20:01 ` Omar Sandoval
2017-03-01 21:25 ` Michael S. Tsirkin [this message]
2017-03-01 21:25 ` Michael S. Tsirkin
2017-03-03 0:58 ` Jan Dakinevich
2017-03-03 0:58 ` Jan Dakinevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301232508-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=amit@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@osandov.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.