From: Christoffer Dall <cdall@linaro.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
Tomasz Nowicki <tnowicki@caviumnetworks.com>,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Subject: Re: [PATCH] arm64: KVM: VHE: Clear HCR_TGE when invalidating guest TLBs
Date: Thu, 2 Mar 2017 13:59:17 +0100 [thread overview]
Message-ID: <20170302125917.GK1409@cbox> (raw)
In-Reply-To: <20170227152437.26261-1-marc.zyngier@arm.com>
On Mon, Feb 27, 2017 at 03:24:37PM +0000, Marc Zyngier wrote:
> When invalidating guest TLBs, special care must be taken to
> actually shoot the guest TLBs and not the host ones if we're
> running on a VHE system. This is controlled by the HCR_EL2.TGE
> bit, which we forget to clear before invalidating TLBs.
>
> Address the issue by introducing two wrappers (__tlb_switch_to_guest
> and __tlb_switch_to_host) that take care of both the VTTBR_EL2
> and HCR_EL2.TGE switching.
>
> Reported-by: Tomasz Nowicki <tnowicki@caviumnetworks.com>
> Tested-by: Tomasz Nowicki <tnowicki@caviumnetworks.com>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Reviewed-by: Christoffer Dall <cdall@linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: cdall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: KVM: VHE: Clear HCR_TGE when invalidating guest TLBs
Date: Thu, 2 Mar 2017 13:59:17 +0100 [thread overview]
Message-ID: <20170302125917.GK1409@cbox> (raw)
In-Reply-To: <20170227152437.26261-1-marc.zyngier@arm.com>
On Mon, Feb 27, 2017 at 03:24:37PM +0000, Marc Zyngier wrote:
> When invalidating guest TLBs, special care must be taken to
> actually shoot the guest TLBs and not the host ones if we're
> running on a VHE system. This is controlled by the HCR_EL2.TGE
> bit, which we forget to clear before invalidating TLBs.
>
> Address the issue by introducing two wrappers (__tlb_switch_to_guest
> and __tlb_switch_to_host) that take care of both the VTTBR_EL2
> and HCR_EL2.TGE switching.
>
> Reported-by: Tomasz Nowicki <tnowicki@caviumnetworks.com>
> Tested-by: Tomasz Nowicki <tnowicki@caviumnetworks.com>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Reviewed-by: Christoffer Dall <cdall@linaro.org>
next prev parent reply other threads:[~2017-03-02 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 15:24 [PATCH] arm64: KVM: VHE: Clear HCR_TGE when invalidating guest TLBs Marc Zyngier
2017-02-27 15:24 ` Marc Zyngier
2017-03-02 12:59 ` Christoffer Dall [this message]
2017-03-02 12:59 ` Christoffer Dall
-- strict thread matches above, loose matches on Subject: below --
2017-03-20 16:09 Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302125917.GK1409@cbox \
--to=cdall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=tnowicki@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.