All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Laura Abbott <labbott@redhat.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Kees Cook <keescook@chromium.org>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-arch@vger.kernel.org, David Airlie <airlied@linux.ie>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Wim Van Sebroeck <wim@iguana.be>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-watchdog@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Dani
Subject: Re: [PATCHv2 03/14] arm64: Use set_memory.h header
Date: Thu, 2 Mar 2017 14:07:48 +0000	[thread overview]
Message-ID: <20170302140747.GK19632@leverpostej> (raw)
In-Reply-To: <1488413706-9739-4-git-send-email-labbott@redhat.com>

On Wed, Mar 01, 2017 at 04:14:55PM -0800, Laura Abbott wrote:
> 
> The set_memory_* functions have moved to set_memory.h. Use that header
> explicitly.
> 
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
>  arch/arm64/mm/pageattr.c      | 1 +
>  arch/arm64/net/bpf_jit_comp.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c
> index 8def55e..12ab86d 100644
> --- a/arch/arm64/mm/pageattr.c
> +++ b/arch/arm64/mm/pageattr.c
> @@ -18,6 +18,7 @@
>  
>  #include <asm/pgtable.h>
>  #include <asm/tlbflush.h>
> +#include <asm/set_memory.h>

Nit: alphabetical order, please.

>  
>  struct page_change_data {
>  	pgprot_t set_mask;
> diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c
> index a785554..84e4a91 100644
> --- a/arch/arm64/net/bpf_jit_comp.c
> +++ b/arch/arm64/net/bpf_jit_comp.c
> @@ -26,6 +26,7 @@
>  
>  #include <asm/byteorder.h>
>  #include <asm/cacheflush.h>
> +#include <asm/set_memory.h>
>  #include <asm/debug-monitors.h>

Nit: likewise.

Otherwise, this looks fine to me. FWIW:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

>  
>  #include "bpf_jit.h"
> -- 
> 2.7.4
> 

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Laura Abbott <labbott@redhat.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Kees Cook <keescook@chromium.org>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-arch@vger.kernel.org, David Airlie <airlied@linux.ie>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Wim Van Sebroeck <wim@iguana.be>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-watchdog@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jessica Yu <jeyu@redhat.com>, Takashi Iwai <tiwai@suse.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCHv2 03/14] arm64: Use set_memory.h header
Date: Thu, 2 Mar 2017 14:07:48 +0000	[thread overview]
Message-ID: <20170302140747.GK19632@leverpostej> (raw)
Message-ID: <20170302140748.bgWoyytbmc0oeejsOEwzBC7CZYmDPUB4shdO7xPtq30@z> (raw)
In-Reply-To: <1488413706-9739-4-git-send-email-labbott@redhat.com>

On Wed, Mar 01, 2017 at 04:14:55PM -0800, Laura Abbott wrote:
> 
> The set_memory_* functions have moved to set_memory.h. Use that header
> explicitly.
> 
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
>  arch/arm64/mm/pageattr.c      | 1 +
>  arch/arm64/net/bpf_jit_comp.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c
> index 8def55e..12ab86d 100644
> --- a/arch/arm64/mm/pageattr.c
> +++ b/arch/arm64/mm/pageattr.c
> @@ -18,6 +18,7 @@
>  
>  #include <asm/pgtable.h>
>  #include <asm/tlbflush.h>
> +#include <asm/set_memory.h>

Nit: alphabetical order, please.

>  
>  struct page_change_data {
>  	pgprot_t set_mask;
> diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c
> index a785554..84e4a91 100644
> --- a/arch/arm64/net/bpf_jit_comp.c
> +++ b/arch/arm64/net/bpf_jit_comp.c
> @@ -26,6 +26,7 @@
>  
>  #include <asm/byteorder.h>
>  #include <asm/cacheflush.h>
> +#include <asm/set_memory.h>
>  #include <asm/debug-monitors.h>

Nit: likewise.

Otherwise, this looks fine to me. FWIW:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

>  
>  #include "bpf_jit.h"
> -- 
> 2.7.4
> 

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 03/14] arm64: Use set_memory.h header
Date: Thu, 2 Mar 2017 14:07:48 +0000	[thread overview]
Message-ID: <20170302140747.GK19632@leverpostej> (raw)
In-Reply-To: <1488413706-9739-4-git-send-email-labbott@redhat.com>

On Wed, Mar 01, 2017 at 04:14:55PM -0800, Laura Abbott wrote:
> 
> The set_memory_* functions have moved to set_memory.h. Use that header
> explicitly.
> 
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
>  arch/arm64/mm/pageattr.c      | 1 +
>  arch/arm64/net/bpf_jit_comp.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c
> index 8def55e..12ab86d 100644
> --- a/arch/arm64/mm/pageattr.c
> +++ b/arch/arm64/mm/pageattr.c
> @@ -18,6 +18,7 @@
>  
>  #include <asm/pgtable.h>
>  #include <asm/tlbflush.h>
> +#include <asm/set_memory.h>

Nit: alphabetical order, please.

>  
>  struct page_change_data {
>  	pgprot_t set_mask;
> diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c
> index a785554..84e4a91 100644
> --- a/arch/arm64/net/bpf_jit_comp.c
> +++ b/arch/arm64/net/bpf_jit_comp.c
> @@ -26,6 +26,7 @@
>  
>  #include <asm/byteorder.h>
>  #include <asm/cacheflush.h>
> +#include <asm/set_memory.h>
>  #include <asm/debug-monitors.h>

Nit: likewise.

Otherwise, this looks fine to me. FWIW:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

>  
>  #include "bpf_jit.h"
> -- 
> 2.7.4
> 

  reply	other threads:[~2017-03-02 14:07 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02  0:14 [PATCHv2 00/14] set_memory_* functions header refactor Laura Abbott
2017-03-02  0:14 ` Laura Abbott
2017-03-02  0:14 ` Laura Abbott
2017-03-02  0:14 ` [PATCHv2 01/14] treewide: Move set_memory_* functions away from cacheflush.h Laura Abbott
2017-03-02  0:14   ` Laura Abbott
2017-03-02  0:14   ` Laura Abbott
     [not found]   ` <1488413706-9739-2-git-send-email-labbott-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-03-02 12:07     ` Russell King - ARM Linux
2017-03-02 12:07       ` Russell King - ARM Linux
2017-03-02 12:07       ` Russell King - ARM Linux
2017-03-02 14:11   ` Mark Rutland
2017-03-02 14:11     ` Mark Rutland
2017-03-02 14:11     ` Mark Rutland
2017-03-02  0:14 ` [PATCHv2 02/14] arm: Use set_memory.h header Laura Abbott
2017-03-02  0:14   ` Laura Abbott
2017-03-02  0:14   ` Laura Abbott
2017-03-02 12:01   ` Russell King - ARM Linux
2017-03-02 12:01     ` Russell King - ARM Linux
2017-03-02 12:01     ` Russell King - ARM Linux
2017-03-02  0:14 ` [PATCHv2 03/14] arm64: " Laura Abbott
2017-03-02  0:14   ` Laura Abbott
2017-03-02  0:14   ` Laura Abbott
2017-03-02 14:07   ` Mark Rutland [this message]
2017-03-02 14:07     ` Mark Rutland
2017-03-02 14:07     ` Mark Rutland
2017-03-02 15:06   ` Catalin Marinas
2017-03-02 15:06     ` Catalin Marinas
2017-03-02 15:06     ` Catalin Marinas
2017-03-02  0:14 ` [PATCHv2 04/14] s390: " Laura Abbott
2017-03-02  0:14   ` Laura Abbott
2017-03-02  0:14   ` Laura Abbott
2017-03-02  0:14 ` [PATCHv2 05/14] x86: " Laura Abbott
2017-03-02  0:14   ` Laura Abbott
2017-03-02  0:14   ` Laura Abbott
2017-03-02  8:01   ` Ingo Molnar
2017-03-02  8:01     ` Ingo Molnar
2017-03-02  8:01     ` Ingo Molnar
2017-03-02  0:14 ` [PATCHv2 06/14] agp: " Laura Abbott
2017-03-02  0:14   ` Laura Abbott
2017-03-02  0:14   ` Laura Abbott
2017-03-02  0:14 ` [PATCHv2 07/14] drm: " Laura Abbott
2017-03-02  0:14   ` Laura Abbott
2017-03-02  0:14   ` Laura Abbott
2017-03-05  1:08   ` kbuild test robot
2017-03-05  1:08     ` kbuild test robot
2017-03-05  1:08     ` kbuild test robot
2017-03-05  1:08     ` kbuild test robot
2017-03-02  0:15 ` [PATCHv2 08/14] intel_th: " Laura Abbott
2017-03-02  0:15   ` Laura Abbott
2017-03-02  0:15   ` Laura Abbott
2017-03-02 11:06   ` Alexander Shishkin
2017-03-02 11:06     ` Alexander Shishkin
2017-03-02 11:06     ` Alexander Shishkin
2017-03-02 11:06     ` Alexander Shishkin
2017-03-02  0:15 ` [PATCHv2 09/14] watchdog: hpwdt: " Laura Abbott
2017-03-02  0:15   ` Laura Abbott
2017-03-02  0:15   ` Laura Abbott
2017-03-02 14:48   ` Guenter Roeck
2017-03-02 14:48     ` Guenter Roeck
2017-03-02 14:48     ` Guenter Roeck
2017-03-02  0:15 ` [PATCHv2 10/14] bpf: " Laura Abbott
2017-03-02  0:15   ` Laura Abbott
2017-03-02  0:15   ` Laura Abbott
2017-03-02 20:26   ` Daniel Borkmann
2017-03-02 20:26     ` Daniel Borkmann
2017-03-02 20:26     ` Daniel Borkmann
2017-03-05  3:01   ` kbuild test robot
2017-03-05  3:01     ` kbuild test robot
2017-03-05  3:01     ` kbuild test robot
2017-03-05  3:01     ` kbuild test robot
2017-03-02  0:15 ` [PATCHv2 11/14] module: " Laura Abbott
2017-03-02  0:15   ` Laura Abbott
2017-03-02  0:15   ` Laura Abbott
2017-03-02 17:09   ` Jessica Yu
2017-03-02 17:09     ` Jessica Yu
2017-03-02 17:09     ` Jessica Yu
2017-03-02 17:09     ` Jessica Yu
2017-03-02  0:15 ` [PATCHv2 12/14] PM / hibernate: " Laura Abbott
2017-03-02  0:15   ` Laura Abbott
2017-03-02  0:15   ` Laura Abbott
     [not found] ` <1488413706-9739-1-git-send-email-labbott-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-03-02  0:15   ` [PATCHv2 13/14] ALSA: hda: " Laura Abbott
2017-03-02  0:15     ` Laura Abbott
2017-03-02  0:15     ` Laura Abbott
2017-03-02  0:15 ` [PATCHv2 14/14] treewide: Decouple cacheflush.h and set_memory.h Laura Abbott
2017-03-02  0:15   ` Laura Abbott
2017-03-02  0:15   ` Laura Abbott
2017-03-02 12:06   ` Russell King - ARM Linux
2017-03-02 12:06     ` Russell King - ARM Linux
2017-03-02 12:06     ` Russell King - ARM Linux
2017-03-02 14:12   ` Mark Rutland
2017-03-02 14:12     ` Mark Rutland
2017-03-02 14:12     ` Mark Rutland
2017-03-02 15:05   ` Catalin Marinas
2017-03-02 15:05     ` Catalin Marinas
2017-03-02 15:05     ` Catalin Marinas
     [not found]   ` <1488413706-9739-15-git-send-email-labbott-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-03-04 22:57     ` kbuild test robot
2017-03-04 22:57       ` kbuild test robot
2017-03-04 22:57       ` kbuild test robot
2017-03-04 22:57       ` kbuild test robot
2017-03-05  0:03   ` kbuild test robot
2017-03-05  0:03     ` kbuild test robot
2017-03-05  0:03     ` kbuild test robot
2017-03-05  0:03     ` kbuild test robot
2017-03-02  7:34 ` [PATCHv2 00/14] set_memory_* functions header refactor Heiko Carstens
2017-03-02  7:34   ` Heiko Carstens
2017-03-02  7:34   ` Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170302140747.GK19632@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=airlied@linux.ie \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=labbott@redhat.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linux@roeck-us.net \
    --cc=mingo@redhat.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    --cc=wim@iguana.be \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.