[PATCH] beaglebone.inc: Update use of obsolete bitbake API

[PATCH] beaglebone.inc: Update use of obsolete bitbake API

[Gary Thomas]

The bb.data.getVar() API has been deprecated & removed.  This change
follows that change and allows MACHINE=beaglebone to work again.

Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
 conf/machine/include/beaglebone.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/conf/machine/include/beaglebone.inc b/conf/machine/include/beaglebone.inc
index f76ad3d..b10146d 100644
--- a/conf/machine/include/beaglebone.inc
+++ b/conf/machine/include/beaglebone.inc
@@ -1,5 +1,5 @@
 python () {
-    layers = bb.data.getVar("BBFILE_COLLECTIONS", d, 1)
+    layers = d.getVar("BBFILE_COLLECTIONS", True)
     if not layers:
         return
     if "yoctobsp" in layers:
-- 
2.7.4

Re: [PATCH] beaglebone.inc: Update use of obsolete bitbake API

[Denys Dmytriyenko]

Ah, right, I forgot about this API change when pushing to master... Thanks.

On Thu, Mar 02, 2017 at 09:33:35AM +0100, Gary Thomas wrote:
> The bb.data.getVar() API has been deprecated & removed.  This change
> follows that change and allows MACHINE=beaglebone to work again.
> 
> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> ---
>  conf/machine/include/beaglebone.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/conf/machine/include/beaglebone.inc b/conf/machine/include/beaglebone.inc
> index f76ad3d..b10146d 100644
> --- a/conf/machine/include/beaglebone.inc
> +++ b/conf/machine/include/beaglebone.inc
> @@ -1,5 +1,5 @@
>  python () {
> -    layers = bb.data.getVar("BBFILE_COLLECTIONS", d, 1)
> +    layers = d.getVar("BBFILE_COLLECTIONS", True)
>      if not layers:
>          return
>      if "yoctobsp" in layers:
> -- 
> 2.7.4
> 
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti

Re: [PATCH] beaglebone.inc: Update use of obsolete bitbake API

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

On Thu, Mar 2, 2017 at 10:13 AM, Denys Dmytriyenko <denys@ti.com> wrote:

> Ah, right, I forgot about this API change when pushing to master... Thanks.


As an FYI, this check should really be moved to an event handler. As it is,
if you have meta-yocto-bsp in bblayers, it’ll show an error for each and
every recipe that was parsed, not particularly friendly. I’ll submit a
patch when I can find a moment.
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 965 bytes --]

Re: [PATCH] beaglebone.inc: Update use of obsolete bitbake API

[Denys Dmytriyenko]

On Thu, Mar 02, 2017 at 12:29:19PM -0700, Christopher Larson wrote:
> On Thu, Mar 2, 2017 at 10:13 AM, Denys Dmytriyenko <denys@ti.com> wrote:
> 
> > Ah, right, I forgot about this API change when pushing to master... Thanks.
> 
> 
> As an FYI, this check should really be moved to an event handler. As it is,
> if you have meta-yocto-bsp in bblayers, it’ll show an error for each and
> every recipe that was parsed, not particularly friendly. I’ll submit a
> patch when I can find a moment.

Thanks. I noticed that too and was thinking of changing it, but so far didn't 
have time... Looking forward to your patch then! :)

-- 
Denys