From: Stephen Boyd <sboyd@codeaurora.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
David Brown <david.brown@linaro.org>
Subject: Re: [PATCH 1/2] ARM: dts: add SDC2 and SDC4 to the MSM8660 family
Date: Mon, 6 Mar 2017 06:35:42 -0800 [thread overview]
Message-ID: <20170306143542.GY25384@codeaurora.org> (raw)
In-Reply-To: <20170306080029.3422-1-linus.walleij@linaro.org>
On 03/06, Linus Walleij wrote:
> To make the picture complete, add DTS entries also for the
> second and fourth MMC/SD blocks on the MSM8660. SDC2 is
> an 8-bit interface and SDC4 is a 4-bit interface.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> arch/arm/boot/dts/qcom-msm8660.dtsi | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8660.dtsi b/arch/arm/boot/dts/qcom-msm8660.dtsi
> index 91c9a62ae725..5564ad131325 100644
> --- a/arch/arm/boot/dts/qcom-msm8660.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8660.dtsi
> @@ -392,6 +392,22 @@
> cap-mmc-highspeed;
> };
>
> + sdcc2: sdcc@12140000 {
> + status = "disabled";
> + compatible = "arm,pl18x", "arm,primecell";
> + arm,primecell-periphid = <0x00051180>;
> + reg = <0x12140000 0x8000>;
> + interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "cmd_irq";
> + clocks = <&gcc SDC2_CLK>, <&gcc SDC2_H_CLK>;
> + clock-names = "mclk", "apb_pclk";
> + bus-width = <8>;
> + max-frequency = <48000000>;
> + non-removable;
Should things like non-removable or max-frequency be specified in
the base dts? Those seem like board attributes.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: add SDC2 and SDC4 to the MSM8660 family
Date: Mon, 6 Mar 2017 06:35:42 -0800 [thread overview]
Message-ID: <20170306143542.GY25384@codeaurora.org> (raw)
In-Reply-To: <20170306080029.3422-1-linus.walleij@linaro.org>
On 03/06, Linus Walleij wrote:
> To make the picture complete, add DTS entries also for the
> second and fourth MMC/SD blocks on the MSM8660. SDC2 is
> an 8-bit interface and SDC4 is a 4-bit interface.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> arch/arm/boot/dts/qcom-msm8660.dtsi | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8660.dtsi b/arch/arm/boot/dts/qcom-msm8660.dtsi
> index 91c9a62ae725..5564ad131325 100644
> --- a/arch/arm/boot/dts/qcom-msm8660.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8660.dtsi
> @@ -392,6 +392,22 @@
> cap-mmc-highspeed;
> };
>
> + sdcc2: sdcc at 12140000 {
> + status = "disabled";
> + compatible = "arm,pl18x", "arm,primecell";
> + arm,primecell-periphid = <0x00051180>;
> + reg = <0x12140000 0x8000>;
> + interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "cmd_irq";
> + clocks = <&gcc SDC2_CLK>, <&gcc SDC2_H_CLK>;
> + clock-names = "mclk", "apb_pclk";
> + bus-width = <8>;
> + max-frequency = <48000000>;
> + non-removable;
Should things like non-removable or max-frequency be specified in
the base dts? Those seem like board attributes.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-03-06 14:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 8:00 [PATCH 1/2] ARM: dts: add SDC2 and SDC4 to the MSM8660 family Linus Walleij
2017-03-06 8:00 ` Linus Walleij
2017-03-06 13:10 ` Bjorn Andersson
2017-03-06 13:10 ` Bjorn Andersson
2017-03-06 14:35 ` Stephen Boyd [this message]
2017-03-06 14:35 ` Stephen Boyd
2017-03-15 9:15 ` Linus Walleij
2017-03-15 9:15 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2017-03-15 9:16 Linus Walleij
2017-03-15 9:16 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170306143542.GY25384@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.