From: Alban <albeu@free.fr>
To: Richard Weinberger <richard@nod.at>
Cc: Alban <albeu@free.fr>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-mtd@lists.infradead.org,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Marek Vasut <marek.vasut@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Moritz Fischer <moritz.fischer@ettus.com>
Subject: Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the nvmem API
Date: Mon, 6 Mar 2017 18:21:47 +0100 [thread overview]
Message-ID: <20170306182147.65d59d33@avionic-0020> (raw)
In-Reply-To: <54c76650-b61f-8a4c-70c7-febe76e16d3b@nod.at>
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
On Fri, 3 Mar 2017 23:21:29 +0100
Richard Weinberger <richard@nod.at> wrote:
> Am 03.03.2017 um 15:11 schrieb Boris Brezillon:
> >> And add a list of successfully added notifiers, along with their
> >> data pointer, to the MTD device. That's simple and would also remove
> >> the need for notifier to have a private list of their instances as I
> >> had to do here.
> >
> > And then you're abusing the notifier concept. As said earlier, a
> > notifier is not necessarily using the device, and thus, don't
> > necessarily need private data.
> > It's not only about what is the simplest solution for your use case,
> > but also what other users want/need.
>
> Yes, please don't use the mtd_notifier.
> I strongly vote to embed the nvmem pointer into struct mtd_info.
Ok, I'll do that. However it mean it will have to stays in
drivers/mtd as it then become part of the MTD core.
Alban
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Alban <albeu-GANU6spQydw@public.gmane.org>
To: Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>
Cc: Alban <albeu-GANU6spQydw@public.gmane.org>,
Boris Brezillon
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Cyrille Pitchen
<cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Marek Vasut <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Srinivas Kandagatla
<srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Moritz Fischer
<moritz.fischer-+aYTwkv1SeIAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the nvmem API
Date: Mon, 6 Mar 2017 18:21:47 +0100 [thread overview]
Message-ID: <20170306182147.65d59d33@avionic-0020> (raw)
In-Reply-To: <54c76650-b61f-8a4c-70c7-febe76e16d3b-/L3Ra7n9ekc@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
On Fri, 3 Mar 2017 23:21:29 +0100
Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org> wrote:
> Am 03.03.2017 um 15:11 schrieb Boris Brezillon:
> >> And add a list of successfully added notifiers, along with their
> >> data pointer, to the MTD device. That's simple and would also remove
> >> the need for notifier to have a private list of their instances as I
> >> had to do here.
> >
> > And then you're abusing the notifier concept. As said earlier, a
> > notifier is not necessarily using the device, and thus, don't
> > necessarily need private data.
> > It's not only about what is the simplest solution for your use case,
> > but also what other users want/need.
>
> Yes, please don't use the mtd_notifier.
> I strongly vote to embed the nvmem pointer into struct mtd_info.
Ok, I'll do that. However it mean it will have to stays in
drivers/mtd as it then become part of the MTD core.
Alban
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-03-07 2:22 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 19:50 [PATCH 0/3] mtd: Add support for reading MTD devices via the nvmem API Alban
2017-03-02 19:50 ` Alban
2017-03-02 19:50 ` [PATCH 1/3] doc: bindings: Add bindings documentation for mtd nvmem Alban
2017-03-02 19:50 ` Alban
2017-03-02 20:22 ` Boris Brezillon
2017-03-02 20:22 ` Boris Brezillon
2017-03-03 12:17 ` Alban
2017-03-03 12:17 ` Alban
2017-03-03 12:37 ` Boris Brezillon
2017-03-03 12:37 ` Boris Brezillon
2017-03-03 13:12 ` Alban
2017-03-03 11:27 ` Srinivas Kandagatla
2017-03-03 11:27 ` Srinivas Kandagatla
2017-03-03 12:19 ` Boris Brezillon
2017-03-03 12:19 ` Boris Brezillon
2017-03-03 12:22 ` Alban
2017-03-03 12:22 ` Alban
2017-03-02 19:50 ` [PATCH 2/3] mtd: Add support for reading MTD devices via the nvmem API Alban
2017-03-02 19:50 ` Alban
2017-03-02 21:18 ` Boris Brezillon
2017-03-02 21:18 ` Boris Brezillon
2017-03-03 12:36 ` Alban
2017-03-03 12:36 ` Alban
2017-03-03 13:36 ` Boris Brezillon
2017-03-03 13:36 ` Boris Brezillon
2017-03-03 13:57 ` Alban
2017-03-03 13:57 ` Alban
2017-03-03 14:11 ` Boris Brezillon
2017-03-03 14:11 ` Boris Brezillon
2017-03-03 22:21 ` Richard Weinberger
2017-03-03 22:21 ` Richard Weinberger
2017-03-06 17:21 ` Alban [this message]
2017-03-06 17:21 ` Alban
2017-03-06 19:03 ` Richard Weinberger
2017-03-06 19:03 ` Richard Weinberger
2017-03-06 21:02 ` Boris Brezillon
2017-03-06 21:02 ` Boris Brezillon
2017-03-03 11:23 ` Srinivas Kandagatla
2017-03-03 11:23 ` Srinivas Kandagatla
2017-03-03 12:34 ` Boris Brezillon
2017-03-03 12:34 ` Boris Brezillon
2017-03-03 13:30 ` Alban
2017-03-03 14:03 ` Boris Brezillon
2017-03-03 14:03 ` Boris Brezillon
2017-03-02 19:50 ` [PATCH 3/3] nvmem: core: Allow allocating several anonymous nvmem devices Alban
2017-03-02 19:50 ` Alban
2017-03-02 20:03 ` Boris Brezillon
2017-03-02 20:03 ` Boris Brezillon
2017-03-03 1:50 ` Moritz Fischer
2017-03-03 1:50 ` Moritz Fischer
2017-03-03 10:08 ` Srinivas Kandagatla
2017-03-03 10:08 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170306182147.65d59d33@avionic-0020 \
--to=albeu@free.fr \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=moritz.fischer@ettus.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.