* [PATCH] media:atomisp:pci Remove unnecessary variable
@ 2017-03-06 19:25 Georgiana Rodica Chelu
2017-03-06 21:44 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Georgiana Rodica Chelu @ 2017-03-06 19:25 UTC (permalink / raw)
To: outreachy-kernel; +Cc: mchehab, gregkh
Remove the local variable "ret" because its initial
value does not change during the function execution.
Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c | 5 ++---
.../media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_init.c | 4 +---
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_mipi.c | 4 +---
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c | 3 +--
4 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c
index 0a0652a..bc09914 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c
@@ -557,8 +557,6 @@ const struct atomisp_format_bridge *atomisp_get_format_bridge_from_mbus(u32
static int atomisp_querycap(struct file *file, void *fh,
struct v4l2_capability *cap)
{
- int ret = 0;
-
memset(cap, 0, sizeof(struct v4l2_capability));
WARN_ON(sizeof(DRIVER) > sizeof(cap->driver) ||
@@ -574,7 +572,8 @@ static int atomisp_querycap(struct file *file, void *fh,
cap->device_caps = V4L2_CAP_VIDEO_CAPTURE |
V4L2_CAP_STREAMING | V4L2_CAP_VIDEO_OUTPUT;
cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
- return ret;
+
+ return 0;
}
/*
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_init.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_init.c
index 239ef31..2ed5162 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_init.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_init.c
@@ -105,8 +105,6 @@ input_system_error_t ia_css_isys_init(void)
#elif defined(USE_INPUT_SYSTEM_VERSION_2401)
input_system_error_t ia_css_isys_init(void)
{
- input_system_error_t error = INPUT_SYSTEM_ERR_NO_ERROR;
-
ia_css_isys_csi_rx_lut_rmgr_init();
ia_css_isys_ibuf_rmgr_init();
ia_css_isys_dma_channel_rmgr_init();
@@ -120,7 +118,7 @@ input_system_error_t ia_css_isys_init(void)
isys_irqc_status_enable(ISYS_IRQ1_ID);
isys_irqc_status_enable(ISYS_IRQ2_ID);
- return error;
+ return INPUT_SYSTEM_ERR_NO_ERROR;
}
#endif
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_mipi.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_mipi.c
index 1210c21..bc4b623 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_mipi.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_mipi.c
@@ -37,12 +37,10 @@ enum ia_css_err
ia_css_mipi_frame_specify(const unsigned int size_mem_words,
const bool contiguous)
{
- enum ia_css_err err = IA_CSS_SUCCESS;
-
my_css.size_mem_words = size_mem_words;
(void)contiguous;
- return err;
+ return IA_CSS_SUCCESS;
}
#ifdef ISP2401
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c
index 00b2d16..9caf0b6 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c
@@ -825,7 +825,6 @@ configure_isp_from_args(
bool two_ppc,
bool deinterleaved)
{
- enum ia_css_err err = IA_CSS_SUCCESS;
#ifdef ISP2401
struct ia_css_pipe *pipe = find_pipe_by_num(pipeline->pipe_num);
const struct ia_css_resolution *res;
@@ -853,7 +852,7 @@ configure_isp_from_args(
/* Remove support for TNR2 once TNR3 fully integrated */
ia_css_tnr3_configure(binary, (const struct ia_css_frame **)args->tnr_frames);
#endif
- return err;
+ return IA_CSS_SUCCESS;
}
static void
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] media:atomisp:pci Remove unnecessary variable
2017-03-06 19:25 [PATCH] media:atomisp:pci Remove unnecessary variable Georgiana Rodica Chelu
@ 2017-03-06 21:44 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2017-03-06 21:44 UTC (permalink / raw)
To: Georgiana Rodica Chelu; +Cc: outreachy-kernel, mchehab, gregkh
The subject one doesn't seem standard. Normally there are at least spaces
after the :s. In general, use got long --oneline on each file to see what
others have done, and try to come up with something that covers the
affected files.
julia
On Mon, 6 Mar 2017, Georgiana Rodica Chelu wrote:
> Remove the local variable "ret" because its initial
> value does not change during the function execution.
>
> Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
> ---
> drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c | 5 ++---
> .../media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_init.c | 4 +---
> drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_mipi.c | 4 +---
> drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c | 3 +--
> 4 files changed, 5 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c
> index 0a0652a..bc09914 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c
> @@ -557,8 +557,6 @@ const struct atomisp_format_bridge *atomisp_get_format_bridge_from_mbus(u32
> static int atomisp_querycap(struct file *file, void *fh,
> struct v4l2_capability *cap)
> {
> - int ret = 0;
> -
> memset(cap, 0, sizeof(struct v4l2_capability));
>
> WARN_ON(sizeof(DRIVER) > sizeof(cap->driver) ||
> @@ -574,7 +572,8 @@ static int atomisp_querycap(struct file *file, void *fh,
> cap->device_caps = V4L2_CAP_VIDEO_CAPTURE |
> V4L2_CAP_STREAMING | V4L2_CAP_VIDEO_OUTPUT;
> cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
> - return ret;
> +
> + return 0;
> }
>
> /*
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_init.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_init.c
> index 239ef31..2ed5162 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_init.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/isys_init.c
> @@ -105,8 +105,6 @@ input_system_error_t ia_css_isys_init(void)
> #elif defined(USE_INPUT_SYSTEM_VERSION_2401)
> input_system_error_t ia_css_isys_init(void)
> {
> - input_system_error_t error = INPUT_SYSTEM_ERR_NO_ERROR;
> -
> ia_css_isys_csi_rx_lut_rmgr_init();
> ia_css_isys_ibuf_rmgr_init();
> ia_css_isys_dma_channel_rmgr_init();
> @@ -120,7 +118,7 @@ input_system_error_t ia_css_isys_init(void)
> isys_irqc_status_enable(ISYS_IRQ1_ID);
> isys_irqc_status_enable(ISYS_IRQ2_ID);
>
> - return error;
> + return INPUT_SYSTEM_ERR_NO_ERROR;
> }
> #endif
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_mipi.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_mipi.c
> index 1210c21..bc4b623 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_mipi.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_mipi.c
> @@ -37,12 +37,10 @@ enum ia_css_err
> ia_css_mipi_frame_specify(const unsigned int size_mem_words,
> const bool contiguous)
> {
> - enum ia_css_err err = IA_CSS_SUCCESS;
> -
> my_css.size_mem_words = size_mem_words;
> (void)contiguous;
>
> - return err;
> + return IA_CSS_SUCCESS;
> }
>
> #ifdef ISP2401
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c
> index 00b2d16..9caf0b6 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c
> @@ -825,7 +825,6 @@ configure_isp_from_args(
> bool two_ppc,
> bool deinterleaved)
> {
> - enum ia_css_err err = IA_CSS_SUCCESS;
> #ifdef ISP2401
> struct ia_css_pipe *pipe = find_pipe_by_num(pipeline->pipe_num);
> const struct ia_css_resolution *res;
> @@ -853,7 +852,7 @@ configure_isp_from_args(
> /* Remove support for TNR2 once TNR3 fully integrated */
> ia_css_tnr3_configure(binary, (const struct ia_css_frame **)args->tnr_frames);
> #endif
> - return err;
> + return IA_CSS_SUCCESS;
> }
>
> static void
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170306192538.GA5241%40fireworks.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-06 21:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-06 19:25 [PATCH] media:atomisp:pci Remove unnecessary variable Georgiana Rodica Chelu
2017-03-06 21:44 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.