[PATCH 0/3] staging: wilc1000: renames multiple camel-cased parameters in wilc methods

[PATCH 0/3] staging: wilc1000: renames multiple camel-cased parameters in wilc methods

[Tahia Khan]

Multiple camel-cased parameters renamed in wilc RX buffer 
manipulation methods. Originally reported by checkpatch.pl.

Tahia Khan (3):
  staging: wilc1000: Fixes camel-casing in wilc_scan_complete_received
  staging: wilc1000: Fixes camel-casing in wilc_network_info_received
  staging: wilc1000: Fixes camel-casing in wilc_gnrl_info_received

 drivers/staging/wilc1000/coreconfigurator.h | 12 ++++++------
 drivers/staging/wilc1000/host_interface.c   | 30 ++++++++++++++---------------
 2 files changed, 21 insertions(+), 21 deletions(-)

-- 
2.7.4

[PATCH 1/3] staging: wilc1000: Fixes camel-casing in wilc_scan_complete_received

[Tahia Khan]

Fixes checkpatch warning by renaming pu8Buffer to buffer
and u32Length to length in wilc_scan_complete_received.

Signed-off-by: Tahia Khan <tahia.khan@gmail.com>
---
 drivers/staging/wilc1000/coreconfigurator.h | 4 ++--
 drivers/staging/wilc1000/host_interface.c   | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h
index 10101f8..616bd21 100644
--- a/drivers/staging/wilc1000/coreconfigurator.h
+++ b/drivers/staging/wilc1000/coreconfigurator.h
@@ -124,8 +124,8 @@ s32 wilc_parse_network_info(u8 *msg_buffer,
 			    struct network_info **ret_network_info);
 s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len,
 			       struct connect_resp_info **ret_connect_resp_info);
-void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
-				 u32 u32Length);
+void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
+				 u32 length);
 void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
 				u32 u32Length);
 void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index f848bb8..853a57f3 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -3523,8 +3523,8 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
 	mutex_unlock(&hif_deinit_lock);
 }
 
-void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
-				 u32 u32Length)
+void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
+				 u32 length)
 {
 	s32 result = 0;
 	struct host_if_msg msg;
@@ -3532,7 +3532,7 @@ void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
 	struct host_if_drv *hif_drv = NULL;
 	struct wilc_vif *vif;
 
-	id = ((pu8Buffer[u32Length - 4]) | (pu8Buffer[u32Length - 3] << 8) | (pu8Buffer[u32Length - 2] << 16) | (pu8Buffer[u32Length - 1] << 24));
+	id = ((buffer[length - 4]) | (buffer[length - 3] << 8) | (buffer[length - 2] << 16) | (buffer[length - 1] << 24));
 	vif = wilc_get_vif_from_idx(wilc, id);
 	if (!vif)
 		return;
-- 
2.7.4

[PATCH 2/3] staging: wilc1000: Fixes camel-casing in wilc_network_info_received

[Tahia Khan]

Fixes checkpatch warning by renaming pu8Buffer to buffer
and u32Length to length in wilc_network_info_received.

Signed-off-by: Tahia Khan <tahia.khan@gmail.com>
---
 drivers/staging/wilc1000/coreconfigurator.h |  4 ++--
 drivers/staging/wilc1000/host_interface.c   | 12 ++++++------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h
index 616bd21..c4c5f3b 100644
--- a/drivers/staging/wilc1000/coreconfigurator.h
+++ b/drivers/staging/wilc1000/coreconfigurator.h
@@ -126,8 +126,8 @@ s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len,
 			       struct connect_resp_info **ret_connect_resp_info);
 void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
 				 u32 length);
-void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
-				u32 u32Length);
+void wilc_network_info_received(struct wilc *wilc, u8 *buffer,
+				u32 length);
 void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
 				   u32 u32Length);
 #endif
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 853a57f3..312a598b 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -3442,8 +3442,8 @@ int wilc_deinit(struct wilc_vif *vif)
 	return result;
 }
 
-void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
-				u32 u32Length)
+void wilc_network_info_received(struct wilc *wilc, u8 *buffer,
+				u32 length)
 {
 	s32 result = 0;
 	struct host_if_msg msg;
@@ -3451,7 +3451,7 @@ void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
 	struct host_if_drv *hif_drv = NULL;
 	struct wilc_vif *vif;
 
-	id = ((pu8Buffer[u32Length - 4]) | (pu8Buffer[u32Length - 3] << 8) | (pu8Buffer[u32Length - 2] << 16) | (pu8Buffer[u32Length - 1] << 24));
+	id = ((buffer[length - 4]) | (buffer[length - 3] << 8) | (buffer[length - 2] << 16) | (buffer[length - 1] << 24));
 	vif = wilc_get_vif_from_idx(wilc, id);
 	if (!vif)
 		return;
@@ -3467,9 +3467,9 @@ void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
 	msg.id = HOST_IF_MSG_RCVD_NTWRK_INFO;
 	msg.vif = vif;
 
-	msg.body.net_info.len = u32Length;
-	msg.body.net_info.buffer = kmalloc(u32Length, GFP_KERNEL);
-	memcpy(msg.body.net_info.buffer, pu8Buffer, u32Length);
+	msg.body.net_info.len = length;
+	msg.body.net_info.buffer = kmalloc(length, GFP_KERNEL);
+	memcpy(msg.body.net_info.buffer, buffer, length);
 
 	result = wilc_enqueue_cmd(&msg);
 	if (result)
-- 
2.7.4

[PATCH 3/3] staging: wilc1000: Fixes camel-casing in wilc_gnrl_info_received

[Tahia Khan]

Fixes checkpatch warning by renaming pu8Buffer to buffer
and u32Length to length in wilc_gnrl_info_received.

Signed-off-by: Tahia Khan <tahia.khan@gmail.com>
---
 drivers/staging/wilc1000/coreconfigurator.h |  4 ++--
 drivers/staging/wilc1000/host_interface.c   | 12 ++++++------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h
index c4c5f3b..a2df5c7 100644
--- a/drivers/staging/wilc1000/coreconfigurator.h
+++ b/drivers/staging/wilc1000/coreconfigurator.h
@@ -128,6 +128,6 @@ void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
 				 u32 length);
 void wilc_network_info_received(struct wilc *wilc, u8 *buffer,
 				u32 length);
-void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
-				   u32 u32Length);
+void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *buffer,
+				   u32 length);
 #endif
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 312a598b..39f4dcf 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -3476,8 +3476,8 @@ void wilc_network_info_received(struct wilc *wilc, u8 *buffer,
 		netdev_err(vif->ndev, "message parameters (%d)\n", result);
 }
 
-void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
-				   u32 u32Length)
+void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *buffer,
+				   u32 length)
 {
 	s32 result = 0;
 	struct host_if_msg msg;
@@ -3487,7 +3487,7 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
 
 	mutex_lock(&hif_deinit_lock);
 
-	id = ((pu8Buffer[u32Length - 4]) | (pu8Buffer[u32Length - 3] << 8) | (pu8Buffer[u32Length - 2] << 16) | (pu8Buffer[u32Length - 1] << 24));
+	id = ((buffer[length - 4]) | (buffer[length - 3] << 8) | (buffer[length - 2] << 16) | (buffer[length - 1] << 24));
 	vif = wilc_get_vif_from_idx(wilc, id);
 	if (!vif) {
 		mutex_unlock(&hif_deinit_lock);
@@ -3512,9 +3512,9 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
 	msg.id = HOST_IF_MSG_RCVD_GNRL_ASYNC_INFO;
 	msg.vif = vif;
 
-	msg.body.async_info.len = u32Length;
-	msg.body.async_info.buffer = kmalloc(u32Length, GFP_KERNEL);
-	memcpy(msg.body.async_info.buffer, pu8Buffer, u32Length);
+	msg.body.async_info.len = length;
+	msg.body.async_info.buffer = kmalloc(length, GFP_KERNEL);
+	memcpy(msg.body.async_info.buffer, buffer, length);
 
 	result = wilc_enqueue_cmd(&msg);
 	if (result)
-- 
2.7.4

Re: [PATCH 1/3] staging: wilc1000: Fixes camel-casing in wilc_scan_complete_received

[Greg KH]

On Mon, Mar 06, 2017 at 05:23:15PM -0500, Tahia Khan wrote:
> Fixes checkpatch warning by renaming pu8Buffer to buffer
> and u32Length to length in wilc_scan_complete_received.
> 
> Signed-off-by: Tahia Khan <tahia.khan@gmail.com>
> ---
>  drivers/staging/wilc1000/coreconfigurator.h | 4 ++--
>  drivers/staging/wilc1000/host_interface.c   | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h
> index 10101f8..616bd21 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.h
> +++ b/drivers/staging/wilc1000/coreconfigurator.h
> @@ -124,8 +124,8 @@ s32 wilc_parse_network_info(u8 *msg_buffer,
>  			    struct network_info **ret_network_info);
>  s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len,
>  			       struct connect_resp_info **ret_connect_resp_info);
> -void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
> -				 u32 u32Length);
> +void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
> +				 u32 length);

This can all now be on one line, correct?

>  void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
>  				u32 u32Length);
>  void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index f848bb8..853a57f3 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -3523,8 +3523,8 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
>  	mutex_unlock(&hif_deinit_lock);
>  }
>  
> -void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
> -				 u32 u32Length)
> +void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
> +				 u32 length)

Same here.

thanks,

greg k-h

Re: [PATCH 2/3] staging: wilc1000: Fixes camel-casing in wilc_network_info_received

[Greg KH]

On Mon, Mar 06, 2017 at 05:23:20PM -0500, Tahia Khan wrote:
> Fixes checkpatch warning by renaming pu8Buffer to buffer
> and u32Length to length in wilc_network_info_received.
> 
> Signed-off-by: Tahia Khan <tahia.khan@gmail.com>
> ---
>  drivers/staging/wilc1000/coreconfigurator.h |  4 ++--
>  drivers/staging/wilc1000/host_interface.c   | 12 ++++++------
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h
> index 616bd21..c4c5f3b 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.h
> +++ b/drivers/staging/wilc1000/coreconfigurator.h
> @@ -126,8 +126,8 @@ s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len,
>  			       struct connect_resp_info **ret_connect_resp_info);
>  void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
>  				 u32 length);
> -void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
> -				u32 u32Length);
> +void wilc_network_info_received(struct wilc *wilc, u8 *buffer,
> +				u32 length);

Again, one line please.  I'll let you fix up the others in this series
this way as well.

thanks,

greg k-h

Re: [Outreachy kernel] Re: [PATCH 1/3] staging: wilc1000: Fixes camel-casing in wilc_scan_complete_received

[Julia Lawall]

On Tue, 7 Mar 2017, Greg KH wrote:

> On Mon, Mar 06, 2017 at 05:23:15PM -0500, Tahia Khan wrote:
> > Fixes checkpatch warning by renaming pu8Buffer to buffer
> > and u32Length to length in wilc_scan_complete_received.
> >
> > Signed-off-by: Tahia Khan <tahia.khan@gmail.com>
> > ---
> >  drivers/staging/wilc1000/coreconfigurator.h | 4 ++--
> >  drivers/staging/wilc1000/host_interface.c   | 6 +++---
> >  2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h
> > index 10101f8..616bd21 100644
> > --- a/drivers/staging/wilc1000/coreconfigurator.h
> > +++ b/drivers/staging/wilc1000/coreconfigurator.h
> > @@ -124,8 +124,8 @@ s32 wilc_parse_network_info(u8 *msg_buffer,
> >  			    struct network_info **ret_network_info);
> >  s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len,
> >  			       struct connect_resp_info **ret_connect_resp_info);
> > -void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
> > -				 u32 u32Length);
> > +void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
> > +				 u32 length);
>
> This can all now be on one line, correct?

If ther is any issue, then buf would also be perfectly fine as a name.

julia

>
> >  void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
> >  				u32 u32Length);
> >  void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
> > diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> > index f848bb8..853a57f3 100644
> > --- a/drivers/staging/wilc1000/host_interface.c
> > +++ b/drivers/staging/wilc1000/host_interface.c
> > @@ -3523,8 +3523,8 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
> >  	mutex_unlock(&hif_deinit_lock);
> >  }
> >
> > -void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
> > -				 u32 u32Length)
> > +void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
> > +				 u32 length)
>
> Same here.
>
> thanks,
>
> greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170307054849.GB14438%40kroah.com.
> For more options, visit https://groups.google.com/d/optout.
>