All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-clk@vger.kernel.org, linux-omap@vger.kernel.org,
	mturquette@baylibre.com, tony@atomide.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH DO NOT MERGE 5/6] ARM: dts: omap4: add some sample clkctrl data
Date: Tue, 7 Mar 2017 06:45:00 -0800	[thread overview]
Message-ID: <20170307144500.GE10239@codeaurora.org> (raw)
In-Reply-To: <1486992157-10673-6-git-send-email-t-kristo@ti.com>

On 02/13, Tero Kristo wrote:
> Adds clkctrl nodes for cm_l4per and cm_abe as example. Peripherals using
> @@ -131,27 +132,61 @@
>  			ranges = <0 0x4a000000 0x1000000>;
>  
>  			cm1: cm1@4000 {
> -				compatible = "ti,omap4-cm1";
> +				compatible = "ti,omap4-cm1", "simple-bus";
>  				reg = <0x4000 0x2000>;
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +				ranges = <0 0x4000 0x2000>;
>  
>  				cm1_clocks: clocks {
>  					#address-cells = <1>;
>  					#size-cells = <0>;
>  				};
>  
> +				cm_abe: cm_abe@0 {

The unit address should be 500 here.

> +					compatible = "ti,omap4-cm";
> +					reg = <0x500 0x100>;
> +					#address-cells = <1>;
> +					#size-cells = <1>;
> +					ranges = <0 0x500 0x100>;
> +
> +					cm_abe_clkctrl: cm_abe_clkctrl@20 {
> +						compatible = "ti,omap4-clkctrl";
> +						reg = <0x20 0x6c>;
> +						#clock-cells = <2>;
> +					};
> +				};
> +
>  				cm1_clockdomains: clockdomains {
>  				};
>  			};
>  
>  			cm2: cm2@8000 {
> -				compatible = "ti,omap4-cm2";
> +				compatible = "ti,omap4-cm2", "simple-bus";
>  				reg = <0x8000 0x3000>;
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +				ranges = <0 0x8000 0x3000>;
>  
>  				cm2_clocks: clocks {
>  					#address-cells = <1>;
>  					#size-cells = <0>;
>  				};
>  
> +				cm_l4per: cm_l4per@0 {

and 1400 here.

> +					compatible = "ti,omap4-cm";
> +					reg = <0x1400 0x200>;
> +					#address-cells = <1>;
> +					#size-cells = <1>;
> +					ranges = <0 0x1400 0x200>;
> +
> +					cm_l4per_clkctrl: cm_l4per_clkctrl@20 {

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Tero Kristo <t-kristo@ti.com>
Cc: tony@atomide.com, mturquette@baylibre.com,
	linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH DO NOT MERGE 5/6] ARM: dts: omap4: add some sample clkctrl data
Date: Tue, 7 Mar 2017 06:45:00 -0800	[thread overview]
Message-ID: <20170307144500.GE10239@codeaurora.org> (raw)
In-Reply-To: <1486992157-10673-6-git-send-email-t-kristo@ti.com>

On 02/13, Tero Kristo wrote:
> Adds clkctrl nodes for cm_l4per and cm_abe as example. Peripherals using
> @@ -131,27 +132,61 @@
>  			ranges = <0 0x4a000000 0x1000000>;
>  
>  			cm1: cm1@4000 {
> -				compatible = "ti,omap4-cm1";
> +				compatible = "ti,omap4-cm1", "simple-bus";
>  				reg = <0x4000 0x2000>;
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +				ranges = <0 0x4000 0x2000>;
>  
>  				cm1_clocks: clocks {
>  					#address-cells = <1>;
>  					#size-cells = <0>;
>  				};
>  
> +				cm_abe: cm_abe@0 {

The unit address should be 500 here.

> +					compatible = "ti,omap4-cm";
> +					reg = <0x500 0x100>;
> +					#address-cells = <1>;
> +					#size-cells = <1>;
> +					ranges = <0 0x500 0x100>;
> +
> +					cm_abe_clkctrl: cm_abe_clkctrl@20 {
> +						compatible = "ti,omap4-clkctrl";
> +						reg = <0x20 0x6c>;
> +						#clock-cells = <2>;
> +					};
> +				};
> +
>  				cm1_clockdomains: clockdomains {
>  				};
>  			};
>  
>  			cm2: cm2@8000 {
> -				compatible = "ti,omap4-cm2";
> +				compatible = "ti,omap4-cm2", "simple-bus";
>  				reg = <0x8000 0x3000>;
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +				ranges = <0 0x8000 0x3000>;
>  
>  				cm2_clocks: clocks {
>  					#address-cells = <1>;
>  					#size-cells = <0>;
>  				};
>  
> +				cm_l4per: cm_l4per@0 {

and 1400 here.

> +					compatible = "ti,omap4-cm";
> +					reg = <0x1400 0x200>;
> +					#address-cells = <1>;
> +					#size-cells = <1>;
> +					ranges = <0 0x1400 0x200>;
> +
> +					cm_l4per_clkctrl: cm_l4per_clkctrl@20 {

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH DO NOT MERGE 5/6] ARM: dts: omap4: add some sample clkctrl data
Date: Tue, 7 Mar 2017 06:45:00 -0800	[thread overview]
Message-ID: <20170307144500.GE10239@codeaurora.org> (raw)
In-Reply-To: <1486992157-10673-6-git-send-email-t-kristo@ti.com>

On 02/13, Tero Kristo wrote:
> Adds clkctrl nodes for cm_l4per and cm_abe as example. Peripherals using
> @@ -131,27 +132,61 @@
>  			ranges = <0 0x4a000000 0x1000000>;
>  
>  			cm1: cm1 at 4000 {
> -				compatible = "ti,omap4-cm1";
> +				compatible = "ti,omap4-cm1", "simple-bus";
>  				reg = <0x4000 0x2000>;
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +				ranges = <0 0x4000 0x2000>;
>  
>  				cm1_clocks: clocks {
>  					#address-cells = <1>;
>  					#size-cells = <0>;
>  				};
>  
> +				cm_abe: cm_abe at 0 {

The unit address should be 500 here.

> +					compatible = "ti,omap4-cm";
> +					reg = <0x500 0x100>;
> +					#address-cells = <1>;
> +					#size-cells = <1>;
> +					ranges = <0 0x500 0x100>;
> +
> +					cm_abe_clkctrl: cm_abe_clkctrl at 20 {
> +						compatible = "ti,omap4-clkctrl";
> +						reg = <0x20 0x6c>;
> +						#clock-cells = <2>;
> +					};
> +				};
> +
>  				cm1_clockdomains: clockdomains {
>  				};
>  			};
>  
>  			cm2: cm2 at 8000 {
> -				compatible = "ti,omap4-cm2";
> +				compatible = "ti,omap4-cm2", "simple-bus";
>  				reg = <0x8000 0x3000>;
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +				ranges = <0 0x8000 0x3000>;
>  
>  				cm2_clocks: clocks {
>  					#address-cells = <1>;
>  					#size-cells = <0>;
>  				};
>  
> +				cm_l4per: cm_l4per at 0 {

and 1400 here.

> +					compatible = "ti,omap4-cm";
> +					reg = <0x1400 0x200>;
> +					#address-cells = <1>;
> +					#size-cells = <1>;
> +					ranges = <0 0x1400 0x200>;
> +
> +					cm_l4per_clkctrl: cm_l4per_clkctrl at 20 {

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  parent reply	other threads:[~2017-03-07 14:45 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-13 13:22 clk: ti: clkctrl clock support Tero Kristo
2017-02-13 13:22 ` Tero Kristo
2017-02-13 13:22 ` Tero Kristo
2017-02-13 13:22 ` [PATCH 1/6] clk: ti: add support for clkctrl clocks Tero Kristo
2017-02-13 13:22   ` Tero Kristo
2017-02-13 13:22   ` Tero Kristo
2017-02-13 13:22 ` [PATCH 2/6] dt-bindings: clk: add omap4 clkctrl definitions Tero Kristo
2017-02-13 13:22   ` Tero Kristo
2017-02-13 13:22   ` Tero Kristo
2017-02-13 13:27   ` Tero Kristo
2017-02-13 13:27     ` Tero Kristo
2017-02-13 13:27     ` Tero Kristo
2017-02-13 13:22 ` [PATCH 3/6] clk: ti: omap4: add clkctrl clock data Tero Kristo
2017-02-13 13:22   ` Tero Kristo
2017-02-13 13:22   ` Tero Kristo
2017-02-13 13:22 ` [PATCH 4/6] ARM: OMAP2+: hwmod: assign hwmod-ck as main clock from DT if available Tero Kristo
2017-02-13 13:22   ` Tero Kristo
2017-02-13 13:22   ` Tero Kristo
2017-02-13 13:22 ` [PATCH DO NOT MERGE 5/6] ARM: dts: omap4: add some sample clkctrl data Tero Kristo
2017-02-13 13:22   ` Tero Kristo
2017-02-13 13:22   ` Tero Kristo
2017-03-02 17:45   ` Tony Lindgren
2017-03-02 17:45     ` Tony Lindgren
2017-03-02 18:43     ` Tero Kristo
2017-03-02 18:43       ` Tero Kristo
2017-03-02 18:43       ` Tero Kristo
2017-03-02 18:56       ` Tony Lindgren
2017-03-02 18:56         ` Tony Lindgren
2017-03-02 18:56         ` Tony Lindgren
2017-03-06 22:45   ` Tony Lindgren
2017-03-06 22:45     ` Tony Lindgren
2017-03-06 22:45     ` Tony Lindgren
2017-03-07  9:04     ` Tero Kristo
2017-03-07  9:04       ` Tero Kristo
2017-03-07  9:04       ` Tero Kristo
2017-03-07 14:45   ` Stephen Boyd [this message]
2017-03-07 14:45     ` Stephen Boyd
2017-03-07 14:45     ` Stephen Boyd
2017-03-07 22:09     ` Tero Kristo
2017-03-07 22:09       ` Tero Kristo
2017-03-07 22:09       ` Tero Kristo
2017-02-13 13:22 ` [PATCH DO NOT MERGE 6/6] ARM: OMAP4: hwmod_data: drop a few clkctrl setups replaced with clocks Tero Kristo
2017-02-13 13:22   ` Tero Kristo
2017-02-13 13:22   ` Tero Kristo
2017-02-13 16:55 ` clk: ti: clkctrl clock support Tony Lindgren
2017-02-13 16:55   ` Tony Lindgren
2017-03-02 18:57 ` Tony Lindgren
2017-03-02 18:57   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170307144500.GE10239@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.