From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org,
linux-fbdev@vger.kernel.org, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 3/3] staging: sm750fb: Alignment should match open parenthesis
Date: Tue, 07 Mar 2017 17:44:26 +0000 [thread overview]
Message-ID: <20170307174426.GM4171@mwanda> (raw)
In-Reply-To: <20170305112450.9066-4-arushisinghal19971997@gmail.com>
On Sun, Mar 05, 2017 at 04:54:50PM +0530, Arushi Singhal wrote:
> @@ -147,18 +146,18 @@ static int programModeRegisters(mode_parameter_t *pModeParam,
> PANEL_HORIZONTAL_SYNC_START_MASK));
>
> poke32(PANEL_VERTICAL_TOTAL,
> - (((pModeParam->vertical_total - 1) <<
> - PANEL_VERTICAL_TOTAL_TOTAL_SHIFT) &
> - PANEL_VERTICAL_TOTAL_TOTAL_MASK) |
> - ((pModeParam->vertical_display_end - 1) &
> - PANEL_VERTICAL_TOTAL_DISPLAY_END_MASK));
> + (((pModeParam->vertical_total - 1) <<
> + PANEL_VERTICAL_TOTAL_TOTAL_SHIFT) &
> + PANEL_VERTICAL_TOTAL_TOTAL_MASK) |
> + ((pModeParam->vertical_display_end - 1) &
> + ANEL_VERTICAL_TOTAL_DISPLAY_END_MASK));
^^^^
Missing P in PANEL means this won't compile.
>
> poke32(PANEL_VERTICAL_SYNC,
> - ((pModeParam->vertical_sync_height <<
> - PANEL_VERTICAL_SYNC_HEIGHT_SHIFT) &
> - PANEL_VERTICAL_SYNC_HEIGHT_MASK) |
> - ((pModeParam->vertical_sync_start - 1) &
> - PANEL_VERTICAL_SYNC_START_MASK));
> + ((pModeParam->vertical_sync_height <<
> + PANEL_VERTICAL_SYNC_HEIGHT_SHIFT) &
> + PANEL_VERTICAL_SYNC_HEIGHT_MASK) |
> + ((pModeParam->vertical_sync_start - 1) &
> + PANEL_VERTICAL_SYNC_START_MASK));
>
> tmp = DISPLAY_CTRL_TIMING | DISPLAY_CTRL_PLANE;
> if (pModeParam->vertical_sync_polarity)
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org,
linux-fbdev@vger.kernel.org, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 3/3] staging: sm750fb: Alignment should match open parenthesis
Date: Tue, 7 Mar 2017 20:44:26 +0300 [thread overview]
Message-ID: <20170307174426.GM4171@mwanda> (raw)
In-Reply-To: <20170305112450.9066-4-arushisinghal19971997@gmail.com>
On Sun, Mar 05, 2017 at 04:54:50PM +0530, Arushi Singhal wrote:
> @@ -147,18 +146,18 @@ static int programModeRegisters(mode_parameter_t *pModeParam,
> PANEL_HORIZONTAL_SYNC_START_MASK));
>
> poke32(PANEL_VERTICAL_TOTAL,
> - (((pModeParam->vertical_total - 1) <<
> - PANEL_VERTICAL_TOTAL_TOTAL_SHIFT) &
> - PANEL_VERTICAL_TOTAL_TOTAL_MASK) |
> - ((pModeParam->vertical_display_end - 1) &
> - PANEL_VERTICAL_TOTAL_DISPLAY_END_MASK));
> + (((pModeParam->vertical_total - 1) <<
> + PANEL_VERTICAL_TOTAL_TOTAL_SHIFT) &
> + PANEL_VERTICAL_TOTAL_TOTAL_MASK) |
> + ((pModeParam->vertical_display_end - 1) &
> + ANEL_VERTICAL_TOTAL_DISPLAY_END_MASK));
^^^^
Missing P in PANEL means this won't compile.
>
> poke32(PANEL_VERTICAL_SYNC,
> - ((pModeParam->vertical_sync_height <<
> - PANEL_VERTICAL_SYNC_HEIGHT_SHIFT) &
> - PANEL_VERTICAL_SYNC_HEIGHT_MASK) |
> - ((pModeParam->vertical_sync_start - 1) &
> - PANEL_VERTICAL_SYNC_START_MASK));
> + ((pModeParam->vertical_sync_height <<
> + PANEL_VERTICAL_SYNC_HEIGHT_SHIFT) &
> + PANEL_VERTICAL_SYNC_HEIGHT_MASK) |
> + ((pModeParam->vertical_sync_start - 1) &
> + PANEL_VERTICAL_SYNC_START_MASK));
>
> tmp = DISPLAY_CTRL_TIMING | DISPLAY_CTRL_PLANE;
> if (pModeParam->vertical_sync_polarity)
regards,
dan carpenter
next prev parent reply other threads:[~2017-03-07 17:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-05 11:24 [PATCH 0/3] multiple checkpatch issues Arushi Singhal
2017-03-05 11:36 ` Arushi Singhal
2017-03-05 11:24 ` [PATCH 1/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations Arushi Singhal
2017-03-05 11:36 ` Arushi Singhal
2017-03-06 19:34 ` Geert Uytterhoeven
2017-03-06 19:34 ` Geert Uytterhoeven
2017-03-07 17:39 ` Dan Carpenter
2017-03-07 17:39 ` Dan Carpenter
2017-03-05 11:24 ` [PATCH 2/3] staging: sm750fb: function prototype argument should have an identifier name Arushi Singhal
2017-03-05 11:36 ` Arushi Singhal
2017-03-05 11:24 ` [PATCH 3/3] staging: sm750fb: Alignment should match open parenthesis Arushi Singhal
2017-03-05 11:36 ` Arushi Singhal
2017-03-07 17:44 ` Dan Carpenter [this message]
2017-03-07 17:44 ` Dan Carpenter
2017-03-05 13:39 ` [PATCH 0/3] multiple checkpatch issues Joe Perches
2017-03-05 13:39 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2017-03-10 21:56 Arushi Singhal
2017-03-10 21:57 ` Arushi Singhal
2017-03-10 21:56 ` [PATCH 1/3] staging: sm750fb: function prototype argument should have an identifier name Arushi Singhal
2017-03-10 21:57 ` Arushi Singhal
2017-03-10 21:56 ` [PATCH 2/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations Arushi Singhal
2017-03-10 21:57 ` Arushi Singhal
2017-03-10 21:56 ` [PATCH 3/3] staging: sm750fb: Alignment should match open parenthesis Arushi Singhal
2017-03-10 21:58 ` Arushi Singhal
2017-03-10 22:05 ` [PATCH 0/3] multiple checkpatch issues Greg KH
2017-03-10 22:05 ` Greg KH
2017-03-11 3:36 [PATCH 0/3] staging: sm750fb: " Arushi Singhal
2017-03-11 3:24 ` [PATCH 3/3] staging: sm750fb: Alignment should match open parenthesis Arushi Singhal
2017-03-11 3:36 ` Arushi Singhal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307174426.GM4171@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arushisinghal19971997@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.