From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH] net/mlx5: fix TSO TCP checksum flag
Date: Thu, 9 Mar 2017 08:17:56 +0100 [thread overview]
Message-ID: <20170309071756.GQ22756@autoinstall.dev.6wind.com> (raw)
In-Reply-To: <1488887271-34342-1-git-send-email-shahafs@mellanox.com>
On Tue, Mar 07, 2017 at 01:47:51PM +0200, Shahaf Shuler wrote:
> Since PKT_TX_TCP_SEG implies PKT_TX_TCP_CKSUM, the PMD must force this
> flag.
> The fix applied for both tunneled and non-tunneled packets.
>
> Fixes: 19c5dc66b851 ("net/mlx5: add hardware TSO support")
> Fixes: 751f56489e31 ("net/mlx5: add hardware TSO support for VXLAN and GRE")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index 405836c..2d33f2d 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -499,6 +499,9 @@
> if (is_tunneled && txq->tunnel_en) {
> tso_header_sz += buf->outer_l2_len +
> buf->outer_l3_len;
> + cs_flags |= MLX5_ETH_WQE_L4_INNER_CSUM;
> + } else {
> + cs_flags |= MLX5_ETH_WQE_L4_CSUM;
> }
> if (unlikely(tso_header_sz >
> MLX5_MAX_TSO_HEADER))
> --
> 1.8.3.1
>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2017-03-09 7:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 11:47 [PATCH] net/mlx5: fix TSO TCP checksum flag Shahaf Shuler
2017-03-09 7:17 ` Nélio Laranjeiro [this message]
2017-03-09 16:07 ` [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309071756.GQ22756@autoinstall.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.