* [PATCH 0/2] Fix multiple checkpatch warnings
@ 2017-03-07 23:13 Sreya Mittal
2017-03-07 23:13 ` [PATCH 1/2] staging: wilc1000: Fix spelling error Sreya Mittal
2017-03-07 23:13 ` [PATCH 2/2] staging: wilc1000: Add blank line after a function Sreya Mittal
0 siblings, 2 replies; 4+ messages in thread
From: Sreya Mittal @ 2017-03-07 23:13 UTC (permalink / raw)
To: outreachy-kernel
Cc: Sreya Mittal, Aditya Shankar, Ganesh Krishna, Greg Kroah-Hartman
Fix spelling error of a variable from unkmown to unknown
and add a blank line after a function definition.
Sreya Mittal (2):
staging: wilc1000: Fix spelling error
staging: wilc1000: Add blank line after a function
drivers/staging/wilc1000/wilc_spi.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
--
2.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] staging: wilc1000: Fix spelling error
2017-03-07 23:13 [PATCH 0/2] Fix multiple checkpatch warnings Sreya Mittal
@ 2017-03-07 23:13 ` Sreya Mittal
2017-03-09 13:52 ` Greg Kroah-Hartman
2017-03-07 23:13 ` [PATCH 2/2] staging: wilc1000: Add blank line after a function Sreya Mittal
1 sibling, 1 reply; 4+ messages in thread
From: Sreya Mittal @ 2017-03-07 23:13 UTC (permalink / raw)
To: outreachy-kernel
Cc: Sreya Mittal, Aditya Shankar, Ganesh Krishna, Greg Kroah-Hartman
Fix the checkpatch issue:
'unkmown' may be misspelled - perhaps 'unknown'?
Signed-off-by: Sreya Mittal <sreyamittal5@gmail.com>
---
drivers/staging/wilc1000/wilc_spi.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
index 5e28adc..34661bb 100644
--- a/drivers/staging/wilc1000/wilc_spi.c
+++ b/drivers/staging/wilc1000/wilc_spi.c
@@ -965,12 +965,12 @@ static int wilc_spi_read_int(struct wilc *wilc, u32 *int_status)
}
{
- u32 unkmown_mask;
+ u32 unknown_mask;
- unkmown_mask = ~((1ul << g_spi.nint) - 1);
+ unknown_mask = ~((1ul << g_spi.nint) - 1);
- if ((tmp >> IRG_FLAGS_OFFSET) & unkmown_mask) {
- dev_err(&spi->dev, "Unexpected interrupt (2): j=%d, tmp=%x, mask=%x\n", j, tmp, unkmown_mask);
+ if ((tmp >> IRG_FLAGS_OFFSET) & unknown_mask) {
+ dev_err(&spi->dev, "Unexpected interrupt (2): j=%d, tmp=%x, mask=%x\n", j, tmp, unknown_mask);
happended = 1;
}
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] staging: wilc1000: Add blank line after a function
2017-03-07 23:13 [PATCH 0/2] Fix multiple checkpatch warnings Sreya Mittal
2017-03-07 23:13 ` [PATCH 1/2] staging: wilc1000: Fix spelling error Sreya Mittal
@ 2017-03-07 23:13 ` Sreya Mittal
1 sibling, 0 replies; 4+ messages in thread
From: Sreya Mittal @ 2017-03-07 23:13 UTC (permalink / raw)
To: outreachy-kernel
Cc: Sreya Mittal, Aditya Shankar, Ganesh Krishna, Greg Kroah-Hartman
Fix the checkpatch issue:
Please use a blank line after function/struct/union/enum declarations
Signed-off-by: Sreya Mittal <sreyamittal5@gmail.com>
---
drivers/staging/wilc1000/wilc_spi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
index 34661bb..9b55a06 100644
--- a/drivers/staging/wilc1000/wilc_spi.c
+++ b/drivers/staging/wilc1000/wilc_spi.c
@@ -1130,6 +1130,7 @@ static int wilc_spi_sync_ext(struct wilc *wilc, int nint)
return 1;
}
+
/********************************************
*
* Global spi HIF function table
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] staging: wilc1000: Fix spelling error
2017-03-07 23:13 ` [PATCH 1/2] staging: wilc1000: Fix spelling error Sreya Mittal
@ 2017-03-09 13:52 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2017-03-09 13:52 UTC (permalink / raw)
To: Sreya Mittal; +Cc: outreachy-kernel, Aditya Shankar, Ganesh Krishna
On Wed, Mar 08, 2017 at 04:43:19AM +0530, Sreya Mittal wrote:
> Fix the checkpatch issue:
> 'unkmown' may be misspelled - perhaps 'unknown'?
>
> Signed-off-by: Sreya Mittal <sreyamittal5@gmail.com>
> ---
> drivers/staging/wilc1000/wilc_spi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Both of these patches do not apply to my tree at all :(
Please rebase and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-09 13:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-07 23:13 [PATCH 0/2] Fix multiple checkpatch warnings Sreya Mittal
2017-03-07 23:13 ` [PATCH 1/2] staging: wilc1000: Fix spelling error Sreya Mittal
2017-03-09 13:52 ` Greg Kroah-Hartman
2017-03-07 23:13 ` [PATCH 2/2] staging: wilc1000: Add blank line after a function Sreya Mittal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.