From: Stephen Hemminger <stephen@networkplumber.org>
To: Philippe Reynes <tremyfr@gmail.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, davem@davemloft.net,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: hyperv: use new api ethtool_{get|set}_link_ksettings
Date: Thu, 9 Mar 2017 14:51:14 -0800 [thread overview]
Message-ID: <20170309145114.755fbff3@xeon-e3> (raw)
In-Reply-To: <1489012864-30810-1-git-send-email-tremyfr@gmail.com>
On Wed, 8 Mar 2017 23:41:04 +0100
Philippe Reynes <tremyfr@gmail.com> wrote:
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
No change in behavior. Same as before driver always reports duplex UNKNOWN and speed change
is not useful.
Tested-by: Stephen Hemminger <sthemmin@microsoft.com>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Philippe Reynes <tremyfr@gmail.com>
Cc: sthemmin@microsoft.com, netdev@vger.kernel.org,
haiyangz@microsoft.com, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, davem@davemloft.net
Subject: Re: [PATCH] net: hyperv: use new api ethtool_{get|set}_link_ksettings
Date: Thu, 9 Mar 2017 14:51:14 -0800 [thread overview]
Message-ID: <20170309145114.755fbff3@xeon-e3> (raw)
In-Reply-To: <1489012864-30810-1-git-send-email-tremyfr@gmail.com>
On Wed, 8 Mar 2017 23:41:04 +0100
Philippe Reynes <tremyfr@gmail.com> wrote:
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
No change in behavior. Same as before driver always reports duplex UNKNOWN and speed change
is not useful.
Tested-by: Stephen Hemminger <sthemmin@microsoft.com>
next prev parent reply other threads:[~2017-03-09 22:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 22:41 [PATCH] net: hyperv: use new api ethtool_{get|set}_link_ksettings Philippe Reynes
2017-03-08 22:41 ` Philippe Reynes
2017-03-09 22:51 ` Stephen Hemminger [this message]
2017-03-09 22:51 ` Stephen Hemminger
2017-03-13 2:28 ` David Miller
2017-03-13 2:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309145114.755fbff3@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=tremyfr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.