[Buildroot] [PATCH 1/1] test-pkg: Extend the logfile with the first command as well

[Buildroot] [PATCH 1/1] test-pkg: Extend the logfile with the first command as well

[Benoît Allard]

Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
---
 support/scripts/test-pkg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/scripts/test-pkg b/support/scripts/test-pkg
index a040ce1..0e7779d 100755
--- a/support/scripts/test-pkg
+++ b/support/scripts/test-pkg
@@ -108,7 +108,7 @@ build_one() {
 	_EOF_
     cat "${cfg}" >>"${dir}/.config"
 
-    if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then
+    if ! make O="${dir}" olddefconfig > "${dir}/logfile" 2>&1; then
         printf "FAILED\n"
         return 2
     fi
-- 
2.1.4

[Buildroot] [PATCH 1/1] test-pkg: Extend the logfile with the first command as well

[Thomas Petazzoni]

Hello,

On Thu,  9 Mar 2017 16:15:21 +0100, Beno?t Allard wrote:
> Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
> ---
>  support/scripts/test-pkg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied.

> diff --git a/support/scripts/test-pkg b/support/scripts/test-pkg
> index a040ce1..0e7779d 100755
> --- a/support/scripts/test-pkg
> +++ b/support/scripts/test-pkg
> @@ -108,7 +108,7 @@ build_one() {
>  	_EOF_
>      cat "${cfg}" >>"${dir}/.config"
>  
> -    if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then
> +    if ! make O="${dir}" olddefconfig > "${dir}/logfile" 2>&1; then

To be honest, I wasn't sure if we wanted > or >> here. It matters if
you restart the test-pkg command after fixing issues. Do you want
logfiles to contain the log of all previous builds, or just the current
build?

For now, I've applied your patch as-is, with just ">", which means the
logfile will only contain the output of the last build. It seems better
to me this way, but we'll see if other folks disagree.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] test-pkg: Extend the logfile with the first command as well

[Yann E. MORIN]

Thomas, Beno?t, All,

On 2017-03-09 21:36 +0100, Thomas Petazzoni spake thusly:
> On Thu,  9 Mar 2017 16:15:21 +0100, Beno?t Allard wrote:
> > Signed-off-by: Beno?t Allard <benoit.allard@greenbone.net>
> > ---
> >  support/scripts/test-pkg | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Thanks, applied.
> 
> > diff --git a/support/scripts/test-pkg b/support/scripts/test-pkg
> > index a040ce1..0e7779d 100755
> > --- a/support/scripts/test-pkg
> > +++ b/support/scripts/test-pkg
> > @@ -108,7 +108,7 @@ build_one() {
> >  	_EOF_
> >      cat "${cfg}" >>"${dir}/.config"
> >  
> > -    if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then
> > +    if ! make O="${dir}" olddefconfig > "${dir}/logfile" 2>&1; then
> 
> To be honest, I wasn't sure if we wanted > or >> here. It matters if
> you restart the test-pkg command after fixing issues. Do you want
> logfiles to contain the log of all previous builds, or just the current
> build?
> 
> For now, I've applied your patch as-is, with just ">", which means the
> logfile will only contain the output of the last build. It seems better
> to me this way, but we'll see if other folks disagree.

Using append-redirection is what we should have used here, because the
logfile is already created a few lines above, for olddefconfig.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] test-pkg: Extend the logfile with the first command as well

[Thomas Petazzoni]

Hello,

On Thu, 9 Mar 2017 23:00:44 +0100, Yann E. MORIN wrote:

> > > -    if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then
> > > +    if ! make O="${dir}" olddefconfig > "${dir}/logfile" 2>&1; then  
> > 
> > To be honest, I wasn't sure if we wanted > or >> here. It matters if
> > you restart the test-pkg command after fixing issues. Do you want
> > logfiles to contain the log of all previous builds, or just the current
> > build?
> > 
> > For now, I've applied your patch as-is, with just ">", which means the
> > logfile will only contain the output of the last build. It seems better
> > to me this way, but we'll see if other folks disagree.  
> 
> Using append-redirection is what we should have used here, because the
> logfile is already created a few lines above, for olddefconfig.

Hu? We're precisely changing the olddefconfig line in this patch. Am I
missing something?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] test-pkg: Extend the logfile with the first command as well

[Yann E. MORIN]

Thomas, All,

On 2017-03-09 23:02 +0100, Thomas Petazzoni spake thusly:
> On Thu, 9 Mar 2017 23:00:44 +0100, Yann E. MORIN wrote:
> > > > -    if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then
> > > > +    if ! make O="${dir}" olddefconfig > "${dir}/logfile" 2>&1; then  
> > > 
> > > To be honest, I wasn't sure if we wanted > or >> here. It matters if
> > > you restart the test-pkg command after fixing issues. Do you want
> > > logfiles to contain the log of all previous builds, or just the current
> > > build?
> > > 
> > > For now, I've applied your patch as-is, with just ">", which means the
> > > logfile will only contain the output of the last build. It seems better
> > > to me this way, but we'll see if other folks disagree.  
> > 
> > Using append-redirection is what we should have used here, because the
> > logfile is already created a few lines above, for olddefconfig.
> 
> Hu? We're precisely changing the olddefconfig line in this patch. Am I
> missing something?

It looks liek I borked something when rebasing my remaining patches...

I'll double-check. Sorry for the noise...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'