All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] conf/machine/include: enable hardfloat by default for ARMv6 and above
@ 2017-03-06 21:47 Andre McCurdy
  2017-03-06 22:37 ` Khem Raj
  0 siblings, 1 reply; 9+ messages in thread
From: Andre McCurdy @ 2017-03-06 21:47 UTC (permalink / raw)
  To: openembedded-core

Defaulting to softfp probably isn't the best choice anymore,
especially as there are now ARM BSP layers which leave DEFAULTTUNE
entirely up to the distro:

  https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
 meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
 meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
 meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
 meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
 meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
 meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/meta/conf/machine/include/arm/arch-armv6.inc b/meta/conf/machine/include/arm/arch-armv6.inc
index 91f0f07..5e1f973 100644
--- a/meta/conf/machine/include/arm/arch-armv6.inc
+++ b/meta/conf/machine/include/arm/arch-armv6.inc
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 TUNEVALID[armv6] = "Enable instructions for ARMv6"
 TUNECONFLICTS[armv6] = "armv4 armv5"
diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc b/meta/conf/machine/include/arm/arch-armv7a.inc
index 5446048..bad1c27 100644
--- a/meta/conf/machine/include/arm/arch-armv7a.inc
+++ b/meta/conf/machine/include/arm/arch-armv7a.inc
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a"
+DEFAULTTUNE ?= "armv7athf"
 
 TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
 TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
diff --git a/meta/conf/machine/include/arm/arch-armv7ve.inc b/meta/conf/machine/include/arm/arch-armv7ve.inc
index 42d8d04..4d9260f 100644
--- a/meta/conf/machine/include/arm/arch-armv7ve.inc
+++ b/meta/conf/machine/include/arm/arch-armv7ve.inc
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve"
+DEFAULTTUNE ?= "armv7vethf"
 
 TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
 TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
diff --git a/meta/conf/machine/include/tune-arm1136jf-s.inc b/meta/conf/machine/include/tune-arm1136jf-s.inc
index 53994ef..2cadbee 100644
--- a/meta/conf/machine/include/tune-arm1136jf-s.inc
+++ b/meta/conf/machine/include/tune-arm1136jf-s.inc
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv6"
+DEFAULTTUNE ?= "armv6thf"
 
 require conf/machine/include/arm/arch-armv6.inc
 
diff --git a/meta/conf/machine/include/tune-cortexa15.inc b/meta/conf/machine/include/tune-cortexa15.inc
index 03de602..25e99f9 100644
--- a/meta/conf/machine/include/tune-cortexa15.inc
+++ b/meta/conf/machine/include/tune-cortexa15.inc
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
diff --git a/meta/conf/machine/include/tune-cortexa17.inc b/meta/conf/machine/include/tune-cortexa17.inc
index f659a62..40392f9 100644
--- a/meta/conf/machine/include/tune-cortexa17.inc
+++ b/meta/conf/machine/include/tune-cortexa17.inc
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
diff --git a/meta/conf/machine/include/tune-cortexa5.inc b/meta/conf/machine/include/tune-cortexa5.inc
index 93f9ca4..1f0cda6 100644
--- a/meta/conf/machine/include/tune-cortexa5.inc
+++ b/meta/conf/machine/include/tune-cortexa5.inc
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
diff --git a/meta/conf/machine/include/tune-cortexa7.inc b/meta/conf/machine/include/tune-cortexa7.inc
index 52e06b8..52415d9 100644
--- a/meta/conf/machine/include/tune-cortexa7.inc
+++ b/meta/conf/machine/include/tune-cortexa7.inc
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7ve-neon"
+DEFAULTTUNE ?= "armv7vethf-neon"
 
 require conf/machine/include/arm/arch-armv7ve.inc
 
diff --git a/meta/conf/machine/include/tune-cortexa8.inc b/meta/conf/machine/include/tune-cortexa8.inc
index a831bd5..8ee8de9 100644
--- a/meta/conf/machine/include/tune-cortexa8.inc
+++ b/meta/conf/machine/include/tune-cortexa8.inc
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
diff --git a/meta/conf/machine/include/tune-cortexa9.inc b/meta/conf/machine/include/tune-cortexa9.inc
index 8b84e60..0cf323c 100644
--- a/meta/conf/machine/include/tune-cortexa9.inc
+++ b/meta/conf/machine/include/tune-cortexa9.inc
@@ -1,4 +1,4 @@
-DEFAULTTUNE ?= "armv7a-neon"
+DEFAULTTUNE ?= "armv7athf-neon"
 
 require conf/machine/include/arm/arch-armv7a.inc
 
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] conf/machine/include: enable hardfloat by default for ARMv6 and above
  2017-03-06 21:47 [PATCH] conf/machine/include: enable hardfloat by default for ARMv6 and above Andre McCurdy
@ 2017-03-06 22:37 ` Khem Raj
  2017-03-06 22:51   ` Andre McCurdy
  0 siblings, 1 reply; 9+ messages in thread
From: Khem Raj @ 2017-03-06 22:37 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: Patches and discussions about the oe-core layer

On Mon, Mar 6, 2017 at 1:47 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> Defaulting to softfp probably isn't the best choice anymore,
> especially as there are now ARM BSP layers which leave DEFAULTTUNE
> entirely up to the distro:
>
>   https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html
>

I like this patch and want to clarify that it changes the default ISA to thumb2
which we should use anyway due to size reasons and other distros use it as
default too.

I am not sure of we should change it for armv6 though. since some armv6
has t1 and some has t2 so lets leave that as it is.

> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
>  meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
>  meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
>  meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
>  meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
>  meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
>  meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
>  meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
>  meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
>  meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
>  meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
>  10 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/meta/conf/machine/include/arm/arch-armv6.inc b/meta/conf/machine/include/arm/arch-armv6.inc
> index 91f0f07..5e1f973 100644
> --- a/meta/conf/machine/include/arm/arch-armv6.inc
> +++ b/meta/conf/machine/include/arm/arch-armv6.inc
> @@ -1,4 +1,4 @@
> -DEFAULTTUNE ?= "armv6"
> +DEFAULTTUNE ?= "armv6thf"
>
>  TUNEVALID[armv6] = "Enable instructions for ARMv6"
>  TUNECONFLICTS[armv6] = "armv4 armv5"
> diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc b/meta/conf/machine/include/arm/arch-armv7a.inc
> index 5446048..bad1c27 100644
> --- a/meta/conf/machine/include/arm/arch-armv7a.inc
> +++ b/meta/conf/machine/include/arm/arch-armv7a.inc
> @@ -1,4 +1,4 @@
> -DEFAULTTUNE ?= "armv7a"
> +DEFAULTTUNE ?= "armv7athf"
>
>  TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
>  TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
> diff --git a/meta/conf/machine/include/arm/arch-armv7ve.inc b/meta/conf/machine/include/arm/arch-armv7ve.inc
> index 42d8d04..4d9260f 100644
> --- a/meta/conf/machine/include/arm/arch-armv7ve.inc
> +++ b/meta/conf/machine/include/arm/arch-armv7ve.inc
> @@ -1,4 +1,4 @@
> -DEFAULTTUNE ?= "armv7ve"
> +DEFAULTTUNE ?= "armv7vethf"
>
>  TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
>  TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
> diff --git a/meta/conf/machine/include/tune-arm1136jf-s.inc b/meta/conf/machine/include/tune-arm1136jf-s.inc
> index 53994ef..2cadbee 100644
> --- a/meta/conf/machine/include/tune-arm1136jf-s.inc
> +++ b/meta/conf/machine/include/tune-arm1136jf-s.inc
> @@ -1,4 +1,4 @@
> -DEFAULTTUNE ?= "armv6"
> +DEFAULTTUNE ?= "armv6thf"
>
>  require conf/machine/include/arm/arch-armv6.inc
>
> diff --git a/meta/conf/machine/include/tune-cortexa15.inc b/meta/conf/machine/include/tune-cortexa15.inc
> index 03de602..25e99f9 100644
> --- a/meta/conf/machine/include/tune-cortexa15.inc
> +++ b/meta/conf/machine/include/tune-cortexa15.inc
> @@ -1,4 +1,4 @@
> -DEFAULTTUNE ?= "armv7ve-neon"
> +DEFAULTTUNE ?= "armv7vethf-neon"
>
>  require conf/machine/include/arm/arch-armv7ve.inc
>
> diff --git a/meta/conf/machine/include/tune-cortexa17.inc b/meta/conf/machine/include/tune-cortexa17.inc
> index f659a62..40392f9 100644
> --- a/meta/conf/machine/include/tune-cortexa17.inc
> +++ b/meta/conf/machine/include/tune-cortexa17.inc
> @@ -1,4 +1,4 @@
> -DEFAULTTUNE ?= "armv7ve-neon"
> +DEFAULTTUNE ?= "armv7vethf-neon"
>
>  require conf/machine/include/arm/arch-armv7ve.inc
>
> diff --git a/meta/conf/machine/include/tune-cortexa5.inc b/meta/conf/machine/include/tune-cortexa5.inc
> index 93f9ca4..1f0cda6 100644
> --- a/meta/conf/machine/include/tune-cortexa5.inc
> +++ b/meta/conf/machine/include/tune-cortexa5.inc
> @@ -1,4 +1,4 @@
> -DEFAULTTUNE ?= "armv7a-neon"
> +DEFAULTTUNE ?= "armv7athf-neon"
>
>  require conf/machine/include/arm/arch-armv7a.inc
>
> diff --git a/meta/conf/machine/include/tune-cortexa7.inc b/meta/conf/machine/include/tune-cortexa7.inc
> index 52e06b8..52415d9 100644
> --- a/meta/conf/machine/include/tune-cortexa7.inc
> +++ b/meta/conf/machine/include/tune-cortexa7.inc
> @@ -1,4 +1,4 @@
> -DEFAULTTUNE ?= "armv7ve-neon"
> +DEFAULTTUNE ?= "armv7vethf-neon"
>
>  require conf/machine/include/arm/arch-armv7ve.inc
>
> diff --git a/meta/conf/machine/include/tune-cortexa8.inc b/meta/conf/machine/include/tune-cortexa8.inc
> index a831bd5..8ee8de9 100644
> --- a/meta/conf/machine/include/tune-cortexa8.inc
> +++ b/meta/conf/machine/include/tune-cortexa8.inc
> @@ -1,4 +1,4 @@
> -DEFAULTTUNE ?= "armv7a-neon"
> +DEFAULTTUNE ?= "armv7athf-neon"
>
>  require conf/machine/include/arm/arch-armv7a.inc
>
> diff --git a/meta/conf/machine/include/tune-cortexa9.inc b/meta/conf/machine/include/tune-cortexa9.inc
> index 8b84e60..0cf323c 100644
> --- a/meta/conf/machine/include/tune-cortexa9.inc
> +++ b/meta/conf/machine/include/tune-cortexa9.inc
> @@ -1,4 +1,4 @@
> -DEFAULTTUNE ?= "armv7a-neon"
> +DEFAULTTUNE ?= "armv7athf-neon"
>
>  require conf/machine/include/arm/arch-armv7a.inc
>
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] conf/machine/include: enable hardfloat by default for ARMv6 and above
  2017-03-06 22:37 ` Khem Raj
@ 2017-03-06 22:51   ` Andre McCurdy
  2017-03-06 23:06     ` Andre McCurdy
  2017-03-06 23:35     ` Khem Raj
  0 siblings, 2 replies; 9+ messages in thread
From: Andre McCurdy @ 2017-03-06 22:51 UTC (permalink / raw)
  To: Khem Raj; +Cc: Patches and discussions about the oe-core layer

On Mon, Mar 6, 2017 at 2:37 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Mon, Mar 6, 2017 at 1:47 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>> Defaulting to softfp probably isn't the best choice anymore,
>> especially as there are now ARM BSP layers which leave DEFAULTTUNE
>> entirely up to the distro:
>>
>>   https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html
>>
>
> I like this patch and want to clarify that it changes the default ISA to thumb2
> which we should use anyway due to size reasons and other distros use it as
> default too.

No, it doesn't. The choice between ARM and Thumb(2) is made by the
ARM_INSTRUCTION_SET variable. Adding 't' to DEFAULTTUNE simply means
that the ARM_INSTRUCTION_SET variable will not be ignored (it's really
a long standing bug that we ever defined DEFAULTTUNE options for ARMv6
and above which ignore ARM_INSTRUCTION_SET, but that's a separate
topic).

> I am not sure of we should change it for armv6 though. since some armv6
> has t1 and some has t2 so lets leave that as it is.

I'm not aware of any ARMv6 cores which don't support Thumb2. Do you
have a reference?

(But again, to be clear, this commit doesn't change the default in
terms of instruction set - all builds will still use ARM).

>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>> ---
>>  meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
>>  meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
>>  meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
>>  meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
>>  meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
>>  meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
>>  meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
>>  meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
>>  meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
>>  meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
>>  10 files changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/meta/conf/machine/include/arm/arch-armv6.inc b/meta/conf/machine/include/arm/arch-armv6.inc
>> index 91f0f07..5e1f973 100644
>> --- a/meta/conf/machine/include/arm/arch-armv6.inc
>> +++ b/meta/conf/machine/include/arm/arch-armv6.inc
>> @@ -1,4 +1,4 @@
>> -DEFAULTTUNE ?= "armv6"
>> +DEFAULTTUNE ?= "armv6thf"
>>
>>  TUNEVALID[armv6] = "Enable instructions for ARMv6"
>>  TUNECONFLICTS[armv6] = "armv4 armv5"
>> diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc b/meta/conf/machine/include/arm/arch-armv7a.inc
>> index 5446048..bad1c27 100644
>> --- a/meta/conf/machine/include/arm/arch-armv7a.inc
>> +++ b/meta/conf/machine/include/arm/arch-armv7a.inc
>> @@ -1,4 +1,4 @@
>> -DEFAULTTUNE ?= "armv7a"
>> +DEFAULTTUNE ?= "armv7athf"
>>
>>  TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
>>  TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
>> diff --git a/meta/conf/machine/include/arm/arch-armv7ve.inc b/meta/conf/machine/include/arm/arch-armv7ve.inc
>> index 42d8d04..4d9260f 100644
>> --- a/meta/conf/machine/include/arm/arch-armv7ve.inc
>> +++ b/meta/conf/machine/include/arm/arch-armv7ve.inc
>> @@ -1,4 +1,4 @@
>> -DEFAULTTUNE ?= "armv7ve"
>> +DEFAULTTUNE ?= "armv7vethf"
>>
>>  TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
>>  TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
>> diff --git a/meta/conf/machine/include/tune-arm1136jf-s.inc b/meta/conf/machine/include/tune-arm1136jf-s.inc
>> index 53994ef..2cadbee 100644
>> --- a/meta/conf/machine/include/tune-arm1136jf-s.inc
>> +++ b/meta/conf/machine/include/tune-arm1136jf-s.inc
>> @@ -1,4 +1,4 @@
>> -DEFAULTTUNE ?= "armv6"
>> +DEFAULTTUNE ?= "armv6thf"
>>
>>  require conf/machine/include/arm/arch-armv6.inc
>>
>> diff --git a/meta/conf/machine/include/tune-cortexa15.inc b/meta/conf/machine/include/tune-cortexa15.inc
>> index 03de602..25e99f9 100644
>> --- a/meta/conf/machine/include/tune-cortexa15.inc
>> +++ b/meta/conf/machine/include/tune-cortexa15.inc
>> @@ -1,4 +1,4 @@
>> -DEFAULTTUNE ?= "armv7ve-neon"
>> +DEFAULTTUNE ?= "armv7vethf-neon"
>>
>>  require conf/machine/include/arm/arch-armv7ve.inc
>>
>> diff --git a/meta/conf/machine/include/tune-cortexa17.inc b/meta/conf/machine/include/tune-cortexa17.inc
>> index f659a62..40392f9 100644
>> --- a/meta/conf/machine/include/tune-cortexa17.inc
>> +++ b/meta/conf/machine/include/tune-cortexa17.inc
>> @@ -1,4 +1,4 @@
>> -DEFAULTTUNE ?= "armv7ve-neon"
>> +DEFAULTTUNE ?= "armv7vethf-neon"
>>
>>  require conf/machine/include/arm/arch-armv7ve.inc
>>
>> diff --git a/meta/conf/machine/include/tune-cortexa5.inc b/meta/conf/machine/include/tune-cortexa5.inc
>> index 93f9ca4..1f0cda6 100644
>> --- a/meta/conf/machine/include/tune-cortexa5.inc
>> +++ b/meta/conf/machine/include/tune-cortexa5.inc
>> @@ -1,4 +1,4 @@
>> -DEFAULTTUNE ?= "armv7a-neon"
>> +DEFAULTTUNE ?= "armv7athf-neon"
>>
>>  require conf/machine/include/arm/arch-armv7a.inc
>>
>> diff --git a/meta/conf/machine/include/tune-cortexa7.inc b/meta/conf/machine/include/tune-cortexa7.inc
>> index 52e06b8..52415d9 100644
>> --- a/meta/conf/machine/include/tune-cortexa7.inc
>> +++ b/meta/conf/machine/include/tune-cortexa7.inc
>> @@ -1,4 +1,4 @@
>> -DEFAULTTUNE ?= "armv7ve-neon"
>> +DEFAULTTUNE ?= "armv7vethf-neon"
>>
>>  require conf/machine/include/arm/arch-armv7ve.inc
>>
>> diff --git a/meta/conf/machine/include/tune-cortexa8.inc b/meta/conf/machine/include/tune-cortexa8.inc
>> index a831bd5..8ee8de9 100644
>> --- a/meta/conf/machine/include/tune-cortexa8.inc
>> +++ b/meta/conf/machine/include/tune-cortexa8.inc
>> @@ -1,4 +1,4 @@
>> -DEFAULTTUNE ?= "armv7a-neon"
>> +DEFAULTTUNE ?= "armv7athf-neon"
>>
>>  require conf/machine/include/arm/arch-armv7a.inc
>>
>> diff --git a/meta/conf/machine/include/tune-cortexa9.inc b/meta/conf/machine/include/tune-cortexa9.inc
>> index 8b84e60..0cf323c 100644
>> --- a/meta/conf/machine/include/tune-cortexa9.inc
>> +++ b/meta/conf/machine/include/tune-cortexa9.inc
>> @@ -1,4 +1,4 @@
>> -DEFAULTTUNE ?= "armv7a-neon"
>> +DEFAULTTUNE ?= "armv7athf-neon"
>>
>>  require conf/machine/include/arm/arch-armv7a.inc
>>
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] conf/machine/include: enable hardfloat by default for ARMv6 and above
  2017-03-06 22:51   ` Andre McCurdy
@ 2017-03-06 23:06     ` Andre McCurdy
  2017-03-06 23:35     ` Khem Raj
  1 sibling, 0 replies; 9+ messages in thread
From: Andre McCurdy @ 2017-03-06 23:06 UTC (permalink / raw)
  To: Khem Raj; +Cc: Patches and discussions about the oe-core layer

On Mon, Mar 6, 2017 at 2:51 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Mon, Mar 6, 2017 at 2:37 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> On Mon, Mar 6, 2017 at 1:47 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>>> Defaulting to softfp probably isn't the best choice anymore,
>>> especially as there are now ARM BSP layers which leave DEFAULTTUNE
>>> entirely up to the distro:
>>>
>>>   https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html
>>>
>>
>> I like this patch and want to clarify that it changes the default ISA to thumb2
>> which we should use anyway due to size reasons and other distros use it as
>> default too.
>
> No, it doesn't. The choice between ARM and Thumb(2) is made by the
> ARM_INSTRUCTION_SET variable. Adding 't' to DEFAULTTUNE simply means
> that the ARM_INSTRUCTION_SET variable will not be ignored (it's really
> a long standing bug that we ever defined DEFAULTTUNE options for ARMv6
> and above which ignore ARM_INSTRUCTION_SET, but that's a separate
> topic).
>
>> I am not sure of we should change it for armv6 though. since some armv6
>> has t1 and some has t2 so lets leave that as it is.
>
> I'm not aware of any ARMv6 cores which don't support Thumb2. Do you
> have a reference?

Well, google does find a few examples, so to avoid any possible risk
of somehow trying to use Thumb-1 I'll send a v2 which drops the 't'
for ARMv6.

> (But again, to be clear, this commit doesn't change the default in
> terms of instruction set - all builds will still use ARM).
>
>>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>>> ---
>>>  meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
>>>  meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
>>>  meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
>>>  meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
>>>  meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
>>>  meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
>>>  meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
>>>  meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
>>>  meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
>>>  meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
>>>  10 files changed, 10 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/meta/conf/machine/include/arm/arch-armv6.inc b/meta/conf/machine/include/arm/arch-armv6.inc
>>> index 91f0f07..5e1f973 100644
>>> --- a/meta/conf/machine/include/arm/arch-armv6.inc
>>> +++ b/meta/conf/machine/include/arm/arch-armv6.inc
>>> @@ -1,4 +1,4 @@
>>> -DEFAULTTUNE ?= "armv6"
>>> +DEFAULTTUNE ?= "armv6thf"
>>>
>>>  TUNEVALID[armv6] = "Enable instructions for ARMv6"
>>>  TUNECONFLICTS[armv6] = "armv4 armv5"
>>> diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc b/meta/conf/machine/include/arm/arch-armv7a.inc
>>> index 5446048..bad1c27 100644
>>> --- a/meta/conf/machine/include/arm/arch-armv7a.inc
>>> +++ b/meta/conf/machine/include/arm/arch-armv7a.inc
>>> @@ -1,4 +1,4 @@
>>> -DEFAULTTUNE ?= "armv7a"
>>> +DEFAULTTUNE ?= "armv7athf"
>>>
>>>  TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
>>>  TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
>>> diff --git a/meta/conf/machine/include/arm/arch-armv7ve.inc b/meta/conf/machine/include/arm/arch-armv7ve.inc
>>> index 42d8d04..4d9260f 100644
>>> --- a/meta/conf/machine/include/arm/arch-armv7ve.inc
>>> +++ b/meta/conf/machine/include/arm/arch-armv7ve.inc
>>> @@ -1,4 +1,4 @@
>>> -DEFAULTTUNE ?= "armv7ve"
>>> +DEFAULTTUNE ?= "armv7vethf"
>>>
>>>  TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
>>>  TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
>>> diff --git a/meta/conf/machine/include/tune-arm1136jf-s.inc b/meta/conf/machine/include/tune-arm1136jf-s.inc
>>> index 53994ef..2cadbee 100644
>>> --- a/meta/conf/machine/include/tune-arm1136jf-s.inc
>>> +++ b/meta/conf/machine/include/tune-arm1136jf-s.inc
>>> @@ -1,4 +1,4 @@
>>> -DEFAULTTUNE ?= "armv6"
>>> +DEFAULTTUNE ?= "armv6thf"
>>>
>>>  require conf/machine/include/arm/arch-armv6.inc
>>>
>>> diff --git a/meta/conf/machine/include/tune-cortexa15.inc b/meta/conf/machine/include/tune-cortexa15.inc
>>> index 03de602..25e99f9 100644
>>> --- a/meta/conf/machine/include/tune-cortexa15.inc
>>> +++ b/meta/conf/machine/include/tune-cortexa15.inc
>>> @@ -1,4 +1,4 @@
>>> -DEFAULTTUNE ?= "armv7ve-neon"
>>> +DEFAULTTUNE ?= "armv7vethf-neon"
>>>
>>>  require conf/machine/include/arm/arch-armv7ve.inc
>>>
>>> diff --git a/meta/conf/machine/include/tune-cortexa17.inc b/meta/conf/machine/include/tune-cortexa17.inc
>>> index f659a62..40392f9 100644
>>> --- a/meta/conf/machine/include/tune-cortexa17.inc
>>> +++ b/meta/conf/machine/include/tune-cortexa17.inc
>>> @@ -1,4 +1,4 @@
>>> -DEFAULTTUNE ?= "armv7ve-neon"
>>> +DEFAULTTUNE ?= "armv7vethf-neon"
>>>
>>>  require conf/machine/include/arm/arch-armv7ve.inc
>>>
>>> diff --git a/meta/conf/machine/include/tune-cortexa5.inc b/meta/conf/machine/include/tune-cortexa5.inc
>>> index 93f9ca4..1f0cda6 100644
>>> --- a/meta/conf/machine/include/tune-cortexa5.inc
>>> +++ b/meta/conf/machine/include/tune-cortexa5.inc
>>> @@ -1,4 +1,4 @@
>>> -DEFAULTTUNE ?= "armv7a-neon"
>>> +DEFAULTTUNE ?= "armv7athf-neon"
>>>
>>>  require conf/machine/include/arm/arch-armv7a.inc
>>>
>>> diff --git a/meta/conf/machine/include/tune-cortexa7.inc b/meta/conf/machine/include/tune-cortexa7.inc
>>> index 52e06b8..52415d9 100644
>>> --- a/meta/conf/machine/include/tune-cortexa7.inc
>>> +++ b/meta/conf/machine/include/tune-cortexa7.inc
>>> @@ -1,4 +1,4 @@
>>> -DEFAULTTUNE ?= "armv7ve-neon"
>>> +DEFAULTTUNE ?= "armv7vethf-neon"
>>>
>>>  require conf/machine/include/arm/arch-armv7ve.inc
>>>
>>> diff --git a/meta/conf/machine/include/tune-cortexa8.inc b/meta/conf/machine/include/tune-cortexa8.inc
>>> index a831bd5..8ee8de9 100644
>>> --- a/meta/conf/machine/include/tune-cortexa8.inc
>>> +++ b/meta/conf/machine/include/tune-cortexa8.inc
>>> @@ -1,4 +1,4 @@
>>> -DEFAULTTUNE ?= "armv7a-neon"
>>> +DEFAULTTUNE ?= "armv7athf-neon"
>>>
>>>  require conf/machine/include/arm/arch-armv7a.inc
>>>
>>> diff --git a/meta/conf/machine/include/tune-cortexa9.inc b/meta/conf/machine/include/tune-cortexa9.inc
>>> index 8b84e60..0cf323c 100644
>>> --- a/meta/conf/machine/include/tune-cortexa9.inc
>>> +++ b/meta/conf/machine/include/tune-cortexa9.inc
>>> @@ -1,4 +1,4 @@
>>> -DEFAULTTUNE ?= "armv7a-neon"
>>> +DEFAULTTUNE ?= "armv7athf-neon"
>>>
>>>  require conf/machine/include/arm/arch-armv7a.inc
>>>
>>> --
>>> 1.9.1
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] conf/machine/include: enable hardfloat by default for ARMv6 and above
  2017-03-06 22:51   ` Andre McCurdy
  2017-03-06 23:06     ` Andre McCurdy
@ 2017-03-06 23:35     ` Khem Raj
  2017-03-09  8:18       ` Martin Jansa
  1 sibling, 1 reply; 9+ messages in thread
From: Khem Raj @ 2017-03-06 23:35 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 6925 bytes --]

On Mon, Mar 6, 2017 at 2:51 PM Andre McCurdy <armccurdy@gmail.com> wrote:

> On Mon, Mar 6, 2017 at 2:37 PM, Khem Raj <raj.khem@gmail.com> wrote:
> > On Mon, Mar 6, 2017 at 1:47 PM, Andre McCurdy <armccurdy@gmail.com>
> wrote:
> >> Defaulting to softfp probably isn't the best choice anymore,
> >> especially as there are now ARM BSP layers which leave DEFAULTTUNE
> >> entirely up to the distro:
> >>
> >>
> https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html
> >>
> >
> > I like this patch and want to clarify that it changes the default ISA to
> thumb2
> > which we should use anyway due to size reasons and other distros use it
> as
> > default too.
>
> No, it doesn't.


That's right I wanted to say to make that default while you are at it

The choice between ARM and Thumb(2) is made by the
> ARM_INSTRUCTION_SET variable. Adding 't' to DEFAULTTUNE simply means
> that the ARM_INSTRUCTION_SET variable will not be ignored (it's really
> a long standing bug that we ever defined DEFAULTTUNE options for ARMv6
> and above which ignore ARM_INSTRUCTION_SET, but that's a separate
> topic).
>
> > I am not sure of we should change it for armv6 though. since some armv6
> > has t1 and some has t2 so lets leave that as it is.
>
> I'm not aware of any ARMv6 cores which don't support Thumb2. Do you
> have a reference?
>
> (But again, to be clear, this commit doesn't change the default in
> terms of instruction set - all builds will still use ARM).
>
> >> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> >> ---
> >>  meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
> >>  meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
> >>  meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
> >>  meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
> >>  meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
> >>  meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
> >>  meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
> >>  meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
> >>  meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
> >>  meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
> >>  10 files changed, 10 insertions(+), 10 deletions(-)
> >>
> >> diff --git a/meta/conf/machine/include/arm/arch-armv6.inc
> b/meta/conf/machine/include/arm/arch-armv6.inc
> >> index 91f0f07..5e1f973 100644
> >> --- a/meta/conf/machine/include/arm/arch-armv6.inc
> >> +++ b/meta/conf/machine/include/arm/arch-armv6.inc
> >> @@ -1,4 +1,4 @@
> >> -DEFAULTTUNE ?= "armv6"
> >> +DEFAULTTUNE ?= "armv6thf"
> >>
> >>  TUNEVALID[armv6] = "Enable instructions for ARMv6"
> >>  TUNECONFLICTS[armv6] = "armv4 armv5"
> >> diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc
> b/meta/conf/machine/include/arm/arch-armv7a.inc
> >> index 5446048..bad1c27 100644
> >> --- a/meta/conf/machine/include/arm/arch-armv7a.inc
> >> +++ b/meta/conf/machine/include/arm/arch-armv7a.inc
> >> @@ -1,4 +1,4 @@
> >> -DEFAULTTUNE ?= "armv7a"
> >> +DEFAULTTUNE ?= "armv7athf"
> >>
> >>  TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
> >>  TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
> >> diff --git a/meta/conf/machine/include/arm/arch-armv7ve.inc
> b/meta/conf/machine/include/arm/arch-armv7ve.inc
> >> index 42d8d04..4d9260f 100644
> >> --- a/meta/conf/machine/include/arm/arch-armv7ve.inc
> >> +++ b/meta/conf/machine/include/arm/arch-armv7ve.inc
> >> @@ -1,4 +1,4 @@
> >> -DEFAULTTUNE ?= "armv7ve"
> >> +DEFAULTTUNE ?= "armv7vethf"
> >>
> >>  TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
> >>  TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
> >> diff --git a/meta/conf/machine/include/tune-arm1136jf-s.inc
> b/meta/conf/machine/include/tune-arm1136jf-s.inc
> >> index 53994ef..2cadbee 100644
> >> --- a/meta/conf/machine/include/tune-arm1136jf-s.inc
> >> +++ b/meta/conf/machine/include/tune-arm1136jf-s.inc
> >> @@ -1,4 +1,4 @@
> >> -DEFAULTTUNE ?= "armv6"
> >> +DEFAULTTUNE ?= "armv6thf"
> >>
> >>  require conf/machine/include/arm/arch-armv6.inc
> >>
> >> diff --git a/meta/conf/machine/include/tune-cortexa15.inc
> b/meta/conf/machine/include/tune-cortexa15.inc
> >> index 03de602..25e99f9 100644
> >> --- a/meta/conf/machine/include/tune-cortexa15.inc
> >> +++ b/meta/conf/machine/include/tune-cortexa15.inc
> >> @@ -1,4 +1,4 @@
> >> -DEFAULTTUNE ?= "armv7ve-neon"
> >> +DEFAULTTUNE ?= "armv7vethf-neon"
> >>
> >>  require conf/machine/include/arm/arch-armv7ve.inc
> >>
> >> diff --git a/meta/conf/machine/include/tune-cortexa17.inc
> b/meta/conf/machine/include/tune-cortexa17.inc
> >> index f659a62..40392f9 100644
> >> --- a/meta/conf/machine/include/tune-cortexa17.inc
> >> +++ b/meta/conf/machine/include/tune-cortexa17.inc
> >> @@ -1,4 +1,4 @@
> >> -DEFAULTTUNE ?= "armv7ve-neon"
> >> +DEFAULTTUNE ?= "armv7vethf-neon"
> >>
> >>  require conf/machine/include/arm/arch-armv7ve.inc
> >>
> >> diff --git a/meta/conf/machine/include/tune-cortexa5.inc
> b/meta/conf/machine/include/tune-cortexa5.inc
> >> index 93f9ca4..1f0cda6 100644
> >> --- a/meta/conf/machine/include/tune-cortexa5.inc
> >> +++ b/meta/conf/machine/include/tune-cortexa5.inc
> >> @@ -1,4 +1,4 @@
> >> -DEFAULTTUNE ?= "armv7a-neon"
> >> +DEFAULTTUNE ?= "armv7athf-neon"
> >>
> >>  require conf/machine/include/arm/arch-armv7a.inc
> >>
> >> diff --git a/meta/conf/machine/include/tune-cortexa7.inc
> b/meta/conf/machine/include/tune-cortexa7.inc
> >> index 52e06b8..52415d9 100644
> >> --- a/meta/conf/machine/include/tune-cortexa7.inc
> >> +++ b/meta/conf/machine/include/tune-cortexa7.inc
> >> @@ -1,4 +1,4 @@
> >> -DEFAULTTUNE ?= "armv7ve-neon"
> >> +DEFAULTTUNE ?= "armv7vethf-neon"
> >>
> >>  require conf/machine/include/arm/arch-armv7ve.inc
> >>
> >> diff --git a/meta/conf/machine/include/tune-cortexa8.inc
> b/meta/conf/machine/include/tune-cortexa8.inc
> >> index a831bd5..8ee8de9 100644
> >> --- a/meta/conf/machine/include/tune-cortexa8.inc
> >> +++ b/meta/conf/machine/include/tune-cortexa8.inc
> >> @@ -1,4 +1,4 @@
> >> -DEFAULTTUNE ?= "armv7a-neon"
> >> +DEFAULTTUNE ?= "armv7athf-neon"
> >>
> >>  require conf/machine/include/arm/arch-armv7a.inc
> >>
> >> diff --git a/meta/conf/machine/include/tune-cortexa9.inc
> b/meta/conf/machine/include/tune-cortexa9.inc
> >> index 8b84e60..0cf323c 100644
> >> --- a/meta/conf/machine/include/tune-cortexa9.inc
> >> +++ b/meta/conf/machine/include/tune-cortexa9.inc
> >> @@ -1,4 +1,4 @@
> >> -DEFAULTTUNE ?= "armv7a-neon"
> >> +DEFAULTTUNE ?= "armv7athf-neon"
> >>
> >>  require conf/machine/include/arm/arch-armv7a.inc
> >>
> >> --
> >> 1.9.1
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 12011 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] conf/machine/include: enable hardfloat by default for ARMv6 and above
  2017-03-06 23:35     ` Khem Raj
@ 2017-03-09  8:18       ` Martin Jansa
  2017-03-09 20:09         ` Andre McCurdy
  0 siblings, 1 reply; 9+ messages in thread
From: Martin Jansa @ 2017-03-09  8:18 UTC (permalink / raw)
  To: Khem Raj; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 7528 bytes --]

Shouldn't we change default ARM_INSTRUCTION_SET while we're at it as well?

https://bugzilla.yoctoproject.org/show_bug.cgi?id=9213

On Tue, Mar 7, 2017 at 12:35 AM, Khem Raj <raj.khem@gmail.com> wrote:

>
> On Mon, Mar 6, 2017 at 2:51 PM Andre McCurdy <armccurdy@gmail.com> wrote:
>
>> On Mon, Mar 6, 2017 at 2:37 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> > On Mon, Mar 6, 2017 at 1:47 PM, Andre McCurdy <armccurdy@gmail.com>
>> wrote:
>> >> Defaulting to softfp probably isn't the best choice anymore,
>> >> especially as there are now ARM BSP layers which leave DEFAULTTUNE
>> >> entirely up to the distro:
>> >>
>> >>   https://lists.yoctoproject.org/pipermail/yocto/2017-
>> February/034637.html
>> >>
>> >
>> > I like this patch and want to clarify that it changes the default ISA
>> to thumb2
>> > which we should use anyway due to size reasons and other distros use it
>> as
>> > default too.
>>
>> No, it doesn't.
>
>
> That's right I wanted to say to make that default while you are at it
>
> The choice between ARM and Thumb(2) is made by the
>> ARM_INSTRUCTION_SET variable. Adding 't' to DEFAULTTUNE simply means
>> that the ARM_INSTRUCTION_SET variable will not be ignored (it's really
>> a long standing bug that we ever defined DEFAULTTUNE options for ARMv6
>> and above which ignore ARM_INSTRUCTION_SET, but that's a separate
>> topic).
>>
>> > I am not sure of we should change it for armv6 though. since some armv6
>> > has t1 and some has t2 so lets leave that as it is.
>>
>> I'm not aware of any ARMv6 cores which don't support Thumb2. Do you
>> have a reference?
>>
>> (But again, to be clear, this commit doesn't change the default in
>> terms of instruction set - all builds will still use ARM).
>>
>> >> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>> >> ---
>> >>  meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
>> >>  meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
>> >>  meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
>> >>  meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
>> >>  meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
>> >>  meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
>> >>  meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
>> >>  meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
>> >>  meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
>> >>  meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
>> >>  10 files changed, 10 insertions(+), 10 deletions(-)
>> >>
>> >> diff --git a/meta/conf/machine/include/arm/arch-armv6.inc
>> b/meta/conf/machine/include/arm/arch-armv6.inc
>> >> index 91f0f07..5e1f973 100644
>> >> --- a/meta/conf/machine/include/arm/arch-armv6.inc
>> >> +++ b/meta/conf/machine/include/arm/arch-armv6.inc
>> >> @@ -1,4 +1,4 @@
>> >> -DEFAULTTUNE ?= "armv6"
>> >> +DEFAULTTUNE ?= "armv6thf"
>> >>
>> >>  TUNEVALID[armv6] = "Enable instructions for ARMv6"
>> >>  TUNECONFLICTS[armv6] = "armv4 armv5"
>> >> diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc
>> b/meta/conf/machine/include/arm/arch-armv7a.inc
>> >> index 5446048..bad1c27 100644
>> >> --- a/meta/conf/machine/include/arm/arch-armv7a.inc
>> >> +++ b/meta/conf/machine/include/arm/arch-armv7a.inc
>> >> @@ -1,4 +1,4 @@
>> >> -DEFAULTTUNE ?= "armv7a"
>> >> +DEFAULTTUNE ?= "armv7athf"
>> >>
>> >>  TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
>> >>  TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
>> >> diff --git a/meta/conf/machine/include/arm/arch-armv7ve.inc
>> b/meta/conf/machine/include/arm/arch-armv7ve.inc
>> >> index 42d8d04..4d9260f 100644
>> >> --- a/meta/conf/machine/include/arm/arch-armv7ve.inc
>> >> +++ b/meta/conf/machine/include/arm/arch-armv7ve.inc
>> >> @@ -1,4 +1,4 @@
>> >> -DEFAULTTUNE ?= "armv7ve"
>> >> +DEFAULTTUNE ?= "armv7vethf"
>> >>
>> >>  TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
>> >>  TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
>> >> diff --git a/meta/conf/machine/include/tune-arm1136jf-s.inc
>> b/meta/conf/machine/include/tune-arm1136jf-s.inc
>> >> index 53994ef..2cadbee 100644
>> >> --- a/meta/conf/machine/include/tune-arm1136jf-s.inc
>> >> +++ b/meta/conf/machine/include/tune-arm1136jf-s.inc
>> >> @@ -1,4 +1,4 @@
>> >> -DEFAULTTUNE ?= "armv6"
>> >> +DEFAULTTUNE ?= "armv6thf"
>> >>
>> >>  require conf/machine/include/arm/arch-armv6.inc
>> >>
>> >> diff --git a/meta/conf/machine/include/tune-cortexa15.inc
>> b/meta/conf/machine/include/tune-cortexa15.inc
>> >> index 03de602..25e99f9 100644
>> >> --- a/meta/conf/machine/include/tune-cortexa15.inc
>> >> +++ b/meta/conf/machine/include/tune-cortexa15.inc
>> >> @@ -1,4 +1,4 @@
>> >> -DEFAULTTUNE ?= "armv7ve-neon"
>> >> +DEFAULTTUNE ?= "armv7vethf-neon"
>> >>
>> >>  require conf/machine/include/arm/arch-armv7ve.inc
>> >>
>> >> diff --git a/meta/conf/machine/include/tune-cortexa17.inc
>> b/meta/conf/machine/include/tune-cortexa17.inc
>> >> index f659a62..40392f9 100644
>> >> --- a/meta/conf/machine/include/tune-cortexa17.inc
>> >> +++ b/meta/conf/machine/include/tune-cortexa17.inc
>> >> @@ -1,4 +1,4 @@
>> >> -DEFAULTTUNE ?= "armv7ve-neon"
>> >> +DEFAULTTUNE ?= "armv7vethf-neon"
>> >>
>> >>  require conf/machine/include/arm/arch-armv7ve.inc
>> >>
>> >> diff --git a/meta/conf/machine/include/tune-cortexa5.inc
>> b/meta/conf/machine/include/tune-cortexa5.inc
>> >> index 93f9ca4..1f0cda6 100644
>> >> --- a/meta/conf/machine/include/tune-cortexa5.inc
>> >> +++ b/meta/conf/machine/include/tune-cortexa5.inc
>> >> @@ -1,4 +1,4 @@
>> >> -DEFAULTTUNE ?= "armv7a-neon"
>> >> +DEFAULTTUNE ?= "armv7athf-neon"
>> >>
>> >>  require conf/machine/include/arm/arch-armv7a.inc
>> >>
>> >> diff --git a/meta/conf/machine/include/tune-cortexa7.inc
>> b/meta/conf/machine/include/tune-cortexa7.inc
>> >> index 52e06b8..52415d9 100644
>> >> --- a/meta/conf/machine/include/tune-cortexa7.inc
>> >> +++ b/meta/conf/machine/include/tune-cortexa7.inc
>> >> @@ -1,4 +1,4 @@
>> >> -DEFAULTTUNE ?= "armv7ve-neon"
>> >> +DEFAULTTUNE ?= "armv7vethf-neon"
>> >>
>> >>  require conf/machine/include/arm/arch-armv7ve.inc
>> >>
>> >> diff --git a/meta/conf/machine/include/tune-cortexa8.inc
>> b/meta/conf/machine/include/tune-cortexa8.inc
>> >> index a831bd5..8ee8de9 100644
>> >> --- a/meta/conf/machine/include/tune-cortexa8.inc
>> >> +++ b/meta/conf/machine/include/tune-cortexa8.inc
>> >> @@ -1,4 +1,4 @@
>> >> -DEFAULTTUNE ?= "armv7a-neon"
>> >> +DEFAULTTUNE ?= "armv7athf-neon"
>> >>
>> >>  require conf/machine/include/arm/arch-armv7a.inc
>> >>
>> >> diff --git a/meta/conf/machine/include/tune-cortexa9.inc
>> b/meta/conf/machine/include/tune-cortexa9.inc
>> >> index 8b84e60..0cf323c 100644
>> >> --- a/meta/conf/machine/include/tune-cortexa9.inc
>> >> +++ b/meta/conf/machine/include/tune-cortexa9.inc
>> >> @@ -1,4 +1,4 @@
>> >> -DEFAULTTUNE ?= "armv7a-neon"
>> >> +DEFAULTTUNE ?= "armv7athf-neon"
>> >>
>> >>  require conf/machine/include/arm/arch-armv7a.inc
>> >>
>> >> --
>> >> 1.9.1
>> >>
>> >> --
>> >> _______________________________________________
>> >> Openembedded-core mailing list
>> >> Openembedded-core@lists.openembedded.org
>> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>

[-- Attachment #2: Type: text/html, Size: 16825 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] conf/machine/include: enable hardfloat by default for ARMv6 and above
  2017-03-09  8:18       ` Martin Jansa
@ 2017-03-09 20:09         ` Andre McCurdy
  2017-03-09 23:09           ` Martin Jansa
  0 siblings, 1 reply; 9+ messages in thread
From: Andre McCurdy @ 2017-03-09 20:09 UTC (permalink / raw)
  To: Martin Jansa; +Cc: Patches and discussions about the oe-core layer

On Thu, Mar 9, 2017 at 12:18 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> Shouldn't we change default ARM_INSTRUCTION_SET while we're at it as well?

Yes, that's the longer term goal. It needs to be done a little
carefully though - ie in a way which doesn't ever enable Thumb by
default for cores which only support Thumb1.

> https://bugzilla.yoctoproject.org/show_bug.cgi?id=9213
>
> On Tue, Mar 7, 2017 at 12:35 AM, Khem Raj <raj.khem@gmail.com> wrote:
>>
>>
>> On Mon, Mar 6, 2017 at 2:51 PM Andre McCurdy <armccurdy@gmail.com> wrote:
>>>
>>> On Mon, Mar 6, 2017 at 2:37 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>> > On Mon, Mar 6, 2017 at 1:47 PM, Andre McCurdy <armccurdy@gmail.com>
>>> > wrote:
>>> >> Defaulting to softfp probably isn't the best choice anymore,
>>> >> especially as there are now ARM BSP layers which leave DEFAULTTUNE
>>> >> entirely up to the distro:
>>> >>
>>> >>
>>> >> https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html
>>> >>
>>> >
>>> > I like this patch and want to clarify that it changes the default ISA
>>> > to thumb2
>>> > which we should use anyway due to size reasons and other distros use it
>>> > as
>>> > default too.
>>>
>>> No, it doesn't.
>>
>>
>> That's right I wanted to say to make that default while you are at it
>>
>>> The choice between ARM and Thumb(2) is made by the
>>> ARM_INSTRUCTION_SET variable. Adding 't' to DEFAULTTUNE simply means
>>> that the ARM_INSTRUCTION_SET variable will not be ignored (it's really
>>> a long standing bug that we ever defined DEFAULTTUNE options for ARMv6
>>> and above which ignore ARM_INSTRUCTION_SET, but that's a separate
>>> topic).
>>>
>>> > I am not sure of we should change it for armv6 though. since some armv6
>>> > has t1 and some has t2 so lets leave that as it is.
>>>
>>> I'm not aware of any ARMv6 cores which don't support Thumb2. Do you
>>> have a reference?
>>>
>>> (But again, to be clear, this commit doesn't change the default in
>>> terms of instruction set - all builds will still use ARM).
>>>
>>> >> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>>> >> ---
>>> >>  meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
>>> >>  meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
>>> >>  meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
>>> >>  meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
>>> >>  meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
>>> >>  meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
>>> >>  meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
>>> >>  meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
>>> >>  meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
>>> >>  meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
>>> >>  10 files changed, 10 insertions(+), 10 deletions(-)
>>> >>
>>> >> diff --git a/meta/conf/machine/include/arm/arch-armv6.inc
>>> >> b/meta/conf/machine/include/arm/arch-armv6.inc
>>> >> index 91f0f07..5e1f973 100644
>>> >> --- a/meta/conf/machine/include/arm/arch-armv6.inc
>>> >> +++ b/meta/conf/machine/include/arm/arch-armv6.inc
>>> >> @@ -1,4 +1,4 @@
>>> >> -DEFAULTTUNE ?= "armv6"
>>> >> +DEFAULTTUNE ?= "armv6thf"
>>> >>
>>> >>  TUNEVALID[armv6] = "Enable instructions for ARMv6"
>>> >>  TUNECONFLICTS[armv6] = "armv4 armv5"
>>> >> diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc
>>> >> b/meta/conf/machine/include/arm/arch-armv7a.inc
>>> >> index 5446048..bad1c27 100644
>>> >> --- a/meta/conf/machine/include/arm/arch-armv7a.inc
>>> >> +++ b/meta/conf/machine/include/arm/arch-armv7a.inc
>>> >> @@ -1,4 +1,4 @@
>>> >> -DEFAULTTUNE ?= "armv7a"
>>> >> +DEFAULTTUNE ?= "armv7athf"
>>> >>
>>> >>  TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
>>> >>  TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
>>> >> diff --git a/meta/conf/machine/include/arm/arch-armv7ve.inc
>>> >> b/meta/conf/machine/include/arm/arch-armv7ve.inc
>>> >> index 42d8d04..4d9260f 100644
>>> >> --- a/meta/conf/machine/include/arm/arch-armv7ve.inc
>>> >> +++ b/meta/conf/machine/include/arm/arch-armv7ve.inc
>>> >> @@ -1,4 +1,4 @@
>>> >> -DEFAULTTUNE ?= "armv7ve"
>>> >> +DEFAULTTUNE ?= "armv7vethf"
>>> >>
>>> >>  TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
>>> >>  TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
>>> >> diff --git a/meta/conf/machine/include/tune-arm1136jf-s.inc
>>> >> b/meta/conf/machine/include/tune-arm1136jf-s.inc
>>> >> index 53994ef..2cadbee 100644
>>> >> --- a/meta/conf/machine/include/tune-arm1136jf-s.inc
>>> >> +++ b/meta/conf/machine/include/tune-arm1136jf-s.inc
>>> >> @@ -1,4 +1,4 @@
>>> >> -DEFAULTTUNE ?= "armv6"
>>> >> +DEFAULTTUNE ?= "armv6thf"
>>> >>
>>> >>  require conf/machine/include/arm/arch-armv6.inc
>>> >>
>>> >> diff --git a/meta/conf/machine/include/tune-cortexa15.inc
>>> >> b/meta/conf/machine/include/tune-cortexa15.inc
>>> >> index 03de602..25e99f9 100644
>>> >> --- a/meta/conf/machine/include/tune-cortexa15.inc
>>> >> +++ b/meta/conf/machine/include/tune-cortexa15.inc
>>> >> @@ -1,4 +1,4 @@
>>> >> -DEFAULTTUNE ?= "armv7ve-neon"
>>> >> +DEFAULTTUNE ?= "armv7vethf-neon"
>>> >>
>>> >>  require conf/machine/include/arm/arch-armv7ve.inc
>>> >>
>>> >> diff --git a/meta/conf/machine/include/tune-cortexa17.inc
>>> >> b/meta/conf/machine/include/tune-cortexa17.inc
>>> >> index f659a62..40392f9 100644
>>> >> --- a/meta/conf/machine/include/tune-cortexa17.inc
>>> >> +++ b/meta/conf/machine/include/tune-cortexa17.inc
>>> >> @@ -1,4 +1,4 @@
>>> >> -DEFAULTTUNE ?= "armv7ve-neon"
>>> >> +DEFAULTTUNE ?= "armv7vethf-neon"
>>> >>
>>> >>  require conf/machine/include/arm/arch-armv7ve.inc
>>> >>
>>> >> diff --git a/meta/conf/machine/include/tune-cortexa5.inc
>>> >> b/meta/conf/machine/include/tune-cortexa5.inc
>>> >> index 93f9ca4..1f0cda6 100644
>>> >> --- a/meta/conf/machine/include/tune-cortexa5.inc
>>> >> +++ b/meta/conf/machine/include/tune-cortexa5.inc
>>> >> @@ -1,4 +1,4 @@
>>> >> -DEFAULTTUNE ?= "armv7a-neon"
>>> >> +DEFAULTTUNE ?= "armv7athf-neon"
>>> >>
>>> >>  require conf/machine/include/arm/arch-armv7a.inc
>>> >>
>>> >> diff --git a/meta/conf/machine/include/tune-cortexa7.inc
>>> >> b/meta/conf/machine/include/tune-cortexa7.inc
>>> >> index 52e06b8..52415d9 100644
>>> >> --- a/meta/conf/machine/include/tune-cortexa7.inc
>>> >> +++ b/meta/conf/machine/include/tune-cortexa7.inc
>>> >> @@ -1,4 +1,4 @@
>>> >> -DEFAULTTUNE ?= "armv7ve-neon"
>>> >> +DEFAULTTUNE ?= "armv7vethf-neon"
>>> >>
>>> >>  require conf/machine/include/arm/arch-armv7ve.inc
>>> >>
>>> >> diff --git a/meta/conf/machine/include/tune-cortexa8.inc
>>> >> b/meta/conf/machine/include/tune-cortexa8.inc
>>> >> index a831bd5..8ee8de9 100644
>>> >> --- a/meta/conf/machine/include/tune-cortexa8.inc
>>> >> +++ b/meta/conf/machine/include/tune-cortexa8.inc
>>> >> @@ -1,4 +1,4 @@
>>> >> -DEFAULTTUNE ?= "armv7a-neon"
>>> >> +DEFAULTTUNE ?= "armv7athf-neon"
>>> >>
>>> >>  require conf/machine/include/arm/arch-armv7a.inc
>>> >>
>>> >> diff --git a/meta/conf/machine/include/tune-cortexa9.inc
>>> >> b/meta/conf/machine/include/tune-cortexa9.inc
>>> >> index 8b84e60..0cf323c 100644
>>> >> --- a/meta/conf/machine/include/tune-cortexa9.inc
>>> >> +++ b/meta/conf/machine/include/tune-cortexa9.inc
>>> >> @@ -1,4 +1,4 @@
>>> >> -DEFAULTTUNE ?= "armv7a-neon"
>>> >> +DEFAULTTUNE ?= "armv7athf-neon"
>>> >>
>>> >>  require conf/machine/include/arm/arch-armv7a.inc
>>> >>
>>> >> --
>>> >> 1.9.1
>>> >>
>>> >> --
>>> >> _______________________________________________
>>> >> Openembedded-core mailing list
>>> >> Openembedded-core@lists.openembedded.org
>>> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>


^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] conf/machine/include: enable hardfloat by default for ARMv6 and above
  2017-03-09 20:09         ` Andre McCurdy
@ 2017-03-09 23:09           ` Martin Jansa
  2017-03-09 23:24             ` Andre McCurdy
  0 siblings, 1 reply; 9+ messages in thread
From: Martin Jansa @ 2017-03-09 23:09 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 8910 bytes --]

On Thu, Mar 09, 2017 at 12:09:51PM -0800, Andre McCurdy wrote:
> On Thu, Mar 9, 2017 at 12:18 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > Shouldn't we change default ARM_INSTRUCTION_SET while we're at it as well?
> 
> Yes, that's the longer term goal. It needs to be done a little
> carefully though - ie in a way which doesn't ever enable Thumb by
> default for cores which only support Thumb1.

Why carefully? If we assume that DISTRO maintainers will select
DEFAULTTUNE correctly then we can assume that they will enable thumb
only for MACHINEs which support Thumb2. I think it's smaller change for
OE users than this already merged change of DEFAULTTUNEs.

And if they decide to use thumb also for qemuarm like I do in bitbake
world builds, then it should work as well.

> > https://bugzilla.yoctoproject.org/show_bug.cgi?id=9213
> >
> > On Tue, Mar 7, 2017 at 12:35 AM, Khem Raj <raj.khem@gmail.com> wrote:
> >>
> >>
> >> On Mon, Mar 6, 2017 at 2:51 PM Andre McCurdy <armccurdy@gmail.com> wrote:
> >>>
> >>> On Mon, Mar 6, 2017 at 2:37 PM, Khem Raj <raj.khem@gmail.com> wrote:
> >>> > On Mon, Mar 6, 2017 at 1:47 PM, Andre McCurdy <armccurdy@gmail.com>
> >>> > wrote:
> >>> >> Defaulting to softfp probably isn't the best choice anymore,
> >>> >> especially as there are now ARM BSP layers which leave DEFAULTTUNE
> >>> >> entirely up to the distro:
> >>> >>
> >>> >>
> >>> >> https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html
> >>> >>
> >>> >
> >>> > I like this patch and want to clarify that it changes the default ISA
> >>> > to thumb2
> >>> > which we should use anyway due to size reasons and other distros use it
> >>> > as
> >>> > default too.
> >>>
> >>> No, it doesn't.
> >>
> >>
> >> That's right I wanted to say to make that default while you are at it
> >>
> >>> The choice between ARM and Thumb(2) is made by the
> >>> ARM_INSTRUCTION_SET variable. Adding 't' to DEFAULTTUNE simply means
> >>> that the ARM_INSTRUCTION_SET variable will not be ignored (it's really
> >>> a long standing bug that we ever defined DEFAULTTUNE options for ARMv6
> >>> and above which ignore ARM_INSTRUCTION_SET, but that's a separate
> >>> topic).
> >>>
> >>> > I am not sure of we should change it for armv6 though. since some armv6
> >>> > has t1 and some has t2 so lets leave that as it is.
> >>>
> >>> I'm not aware of any ARMv6 cores which don't support Thumb2. Do you
> >>> have a reference?
> >>>
> >>> (But again, to be clear, this commit doesn't change the default in
> >>> terms of instruction set - all builds will still use ARM).
> >>>
> >>> >> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> >>> >> ---
> >>> >>  meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
> >>> >>  meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
> >>> >>  meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
> >>> >>  meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
> >>> >>  meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
> >>> >>  meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
> >>> >>  meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
> >>> >>  meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
> >>> >>  meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
> >>> >>  meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
> >>> >>  10 files changed, 10 insertions(+), 10 deletions(-)
> >>> >>
> >>> >> diff --git a/meta/conf/machine/include/arm/arch-armv6.inc
> >>> >> b/meta/conf/machine/include/arm/arch-armv6.inc
> >>> >> index 91f0f07..5e1f973 100644
> >>> >> --- a/meta/conf/machine/include/arm/arch-armv6.inc
> >>> >> +++ b/meta/conf/machine/include/arm/arch-armv6.inc
> >>> >> @@ -1,4 +1,4 @@
> >>> >> -DEFAULTTUNE ?= "armv6"
> >>> >> +DEFAULTTUNE ?= "armv6thf"
> >>> >>
> >>> >>  TUNEVALID[armv6] = "Enable instructions for ARMv6"
> >>> >>  TUNECONFLICTS[armv6] = "armv4 armv5"
> >>> >> diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc
> >>> >> b/meta/conf/machine/include/arm/arch-armv7a.inc
> >>> >> index 5446048..bad1c27 100644
> >>> >> --- a/meta/conf/machine/include/arm/arch-armv7a.inc
> >>> >> +++ b/meta/conf/machine/include/arm/arch-armv7a.inc
> >>> >> @@ -1,4 +1,4 @@
> >>> >> -DEFAULTTUNE ?= "armv7a"
> >>> >> +DEFAULTTUNE ?= "armv7athf"
> >>> >>
> >>> >>  TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
> >>> >>  TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
> >>> >> diff --git a/meta/conf/machine/include/arm/arch-armv7ve.inc
> >>> >> b/meta/conf/machine/include/arm/arch-armv7ve.inc
> >>> >> index 42d8d04..4d9260f 100644
> >>> >> --- a/meta/conf/machine/include/arm/arch-armv7ve.inc
> >>> >> +++ b/meta/conf/machine/include/arm/arch-armv7ve.inc
> >>> >> @@ -1,4 +1,4 @@
> >>> >> -DEFAULTTUNE ?= "armv7ve"
> >>> >> +DEFAULTTUNE ?= "armv7vethf"
> >>> >>
> >>> >>  TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
> >>> >>  TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
> >>> >> diff --git a/meta/conf/machine/include/tune-arm1136jf-s.inc
> >>> >> b/meta/conf/machine/include/tune-arm1136jf-s.inc
> >>> >> index 53994ef..2cadbee 100644
> >>> >> --- a/meta/conf/machine/include/tune-arm1136jf-s.inc
> >>> >> +++ b/meta/conf/machine/include/tune-arm1136jf-s.inc
> >>> >> @@ -1,4 +1,4 @@
> >>> >> -DEFAULTTUNE ?= "armv6"
> >>> >> +DEFAULTTUNE ?= "armv6thf"
> >>> >>
> >>> >>  require conf/machine/include/arm/arch-armv6.inc
> >>> >>
> >>> >> diff --git a/meta/conf/machine/include/tune-cortexa15.inc
> >>> >> b/meta/conf/machine/include/tune-cortexa15.inc
> >>> >> index 03de602..25e99f9 100644
> >>> >> --- a/meta/conf/machine/include/tune-cortexa15.inc
> >>> >> +++ b/meta/conf/machine/include/tune-cortexa15.inc
> >>> >> @@ -1,4 +1,4 @@
> >>> >> -DEFAULTTUNE ?= "armv7ve-neon"
> >>> >> +DEFAULTTUNE ?= "armv7vethf-neon"
> >>> >>
> >>> >>  require conf/machine/include/arm/arch-armv7ve.inc
> >>> >>
> >>> >> diff --git a/meta/conf/machine/include/tune-cortexa17.inc
> >>> >> b/meta/conf/machine/include/tune-cortexa17.inc
> >>> >> index f659a62..40392f9 100644
> >>> >> --- a/meta/conf/machine/include/tune-cortexa17.inc
> >>> >> +++ b/meta/conf/machine/include/tune-cortexa17.inc
> >>> >> @@ -1,4 +1,4 @@
> >>> >> -DEFAULTTUNE ?= "armv7ve-neon"
> >>> >> +DEFAULTTUNE ?= "armv7vethf-neon"
> >>> >>
> >>> >>  require conf/machine/include/arm/arch-armv7ve.inc
> >>> >>
> >>> >> diff --git a/meta/conf/machine/include/tune-cortexa5.inc
> >>> >> b/meta/conf/machine/include/tune-cortexa5.inc
> >>> >> index 93f9ca4..1f0cda6 100644
> >>> >> --- a/meta/conf/machine/include/tune-cortexa5.inc
> >>> >> +++ b/meta/conf/machine/include/tune-cortexa5.inc
> >>> >> @@ -1,4 +1,4 @@
> >>> >> -DEFAULTTUNE ?= "armv7a-neon"
> >>> >> +DEFAULTTUNE ?= "armv7athf-neon"
> >>> >>
> >>> >>  require conf/machine/include/arm/arch-armv7a.inc
> >>> >>
> >>> >> diff --git a/meta/conf/machine/include/tune-cortexa7.inc
> >>> >> b/meta/conf/machine/include/tune-cortexa7.inc
> >>> >> index 52e06b8..52415d9 100644
> >>> >> --- a/meta/conf/machine/include/tune-cortexa7.inc
> >>> >> +++ b/meta/conf/machine/include/tune-cortexa7.inc
> >>> >> @@ -1,4 +1,4 @@
> >>> >> -DEFAULTTUNE ?= "armv7ve-neon"
> >>> >> +DEFAULTTUNE ?= "armv7vethf-neon"
> >>> >>
> >>> >>  require conf/machine/include/arm/arch-armv7ve.inc
> >>> >>
> >>> >> diff --git a/meta/conf/machine/include/tune-cortexa8.inc
> >>> >> b/meta/conf/machine/include/tune-cortexa8.inc
> >>> >> index a831bd5..8ee8de9 100644
> >>> >> --- a/meta/conf/machine/include/tune-cortexa8.inc
> >>> >> +++ b/meta/conf/machine/include/tune-cortexa8.inc
> >>> >> @@ -1,4 +1,4 @@
> >>> >> -DEFAULTTUNE ?= "armv7a-neon"
> >>> >> +DEFAULTTUNE ?= "armv7athf-neon"
> >>> >>
> >>> >>  require conf/machine/include/arm/arch-armv7a.inc
> >>> >>
> >>> >> diff --git a/meta/conf/machine/include/tune-cortexa9.inc
> >>> >> b/meta/conf/machine/include/tune-cortexa9.inc
> >>> >> index 8b84e60..0cf323c 100644
> >>> >> --- a/meta/conf/machine/include/tune-cortexa9.inc
> >>> >> +++ b/meta/conf/machine/include/tune-cortexa9.inc
> >>> >> @@ -1,4 +1,4 @@
> >>> >> -DEFAULTTUNE ?= "armv7a-neon"
> >>> >> +DEFAULTTUNE ?= "armv7athf-neon"
> >>> >>
> >>> >>  require conf/machine/include/arm/arch-armv7a.inc
> >>> >>
> >>> >> --
> >>> >> 1.9.1
> >>> >>
> >>> >> --
> >>> >> _______________________________________________
> >>> >> Openembedded-core mailing list
> >>> >> Openembedded-core@lists.openembedded.org
> >>> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >>
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >>
> >

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] conf/machine/include: enable hardfloat by default for ARMv6 and above
  2017-03-09 23:09           ` Martin Jansa
@ 2017-03-09 23:24             ` Andre McCurdy
  0 siblings, 0 replies; 9+ messages in thread
From: Andre McCurdy @ 2017-03-09 23:24 UTC (permalink / raw)
  To: Martin Jansa; +Cc: Patches and discussions about the oe-core layer

On Thu, Mar 9, 2017 at 3:09 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Thu, Mar 09, 2017 at 12:09:51PM -0800, Andre McCurdy wrote:
>> On Thu, Mar 9, 2017 at 12:18 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> > Shouldn't we change default ARM_INSTRUCTION_SET while we're at it as well?
>>
>> Yes, that's the longer term goal. It needs to be done a little
>> carefully though - ie in a way which doesn't ever enable Thumb by
>> default for cores which only support Thumb1.
>
> Why carefully? If we assume that DISTRO maintainers will select
> DEFAULTTUNE correctly then we can assume that they will enable thumb
> only for MACHINEs which support Thumb2. I think it's smaller change for
> OE users than this already merged change of DEFAULTTUNEs.

I don't think you can assume that distro maintainers will set
DEFAULTTUNE or ARM_INSTRUCTION_SET correctly (poky certainly doesn't)
so the defaults in oe-core should be sensible (ie safe but reasonably
up to date).

> And if they decide to use thumb also for qemuarm like I do in bitbake
> world builds, then it should work as well.

Thumb1 is basically dead at this point. Even if it builds, who knows
what runtime issues might show up. Enabling Thumb1 by default in
oe-core is not something we should be doing (in my opinion anyway).

>> > https://bugzilla.yoctoproject.org/show_bug.cgi?id=9213
>> >
>> > On Tue, Mar 7, 2017 at 12:35 AM, Khem Raj <raj.khem@gmail.com> wrote:
>> >>
>> >>
>> >> On Mon, Mar 6, 2017 at 2:51 PM Andre McCurdy <armccurdy@gmail.com> wrote:
>> >>>
>> >>> On Mon, Mar 6, 2017 at 2:37 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> >>> > On Mon, Mar 6, 2017 at 1:47 PM, Andre McCurdy <armccurdy@gmail.com>
>> >>> > wrote:
>> >>> >> Defaulting to softfp probably isn't the best choice anymore,
>> >>> >> especially as there are now ARM BSP layers which leave DEFAULTTUNE
>> >>> >> entirely up to the distro:
>> >>> >>
>> >>> >>
>> >>> >> https://lists.yoctoproject.org/pipermail/yocto/2017-February/034637.html
>> >>> >>
>> >>> >
>> >>> > I like this patch and want to clarify that it changes the default ISA
>> >>> > to thumb2
>> >>> > which we should use anyway due to size reasons and other distros use it
>> >>> > as
>> >>> > default too.
>> >>>
>> >>> No, it doesn't.
>> >>
>> >>
>> >> That's right I wanted to say to make that default while you are at it
>> >>
>> >>> The choice between ARM and Thumb(2) is made by the
>> >>> ARM_INSTRUCTION_SET variable. Adding 't' to DEFAULTTUNE simply means
>> >>> that the ARM_INSTRUCTION_SET variable will not be ignored (it's really
>> >>> a long standing bug that we ever defined DEFAULTTUNE options for ARMv6
>> >>> and above which ignore ARM_INSTRUCTION_SET, but that's a separate
>> >>> topic).
>> >>>
>> >>> > I am not sure of we should change it for armv6 though. since some armv6
>> >>> > has t1 and some has t2 so lets leave that as it is.
>> >>>
>> >>> I'm not aware of any ARMv6 cores which don't support Thumb2. Do you
>> >>> have a reference?
>> >>>
>> >>> (But again, to be clear, this commit doesn't change the default in
>> >>> terms of instruction set - all builds will still use ARM).
>> >>>
>> >>> >> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>> >>> >> ---
>> >>> >>  meta/conf/machine/include/arm/arch-armv6.inc   | 2 +-
>> >>> >>  meta/conf/machine/include/arm/arch-armv7a.inc  | 2 +-
>> >>> >>  meta/conf/machine/include/arm/arch-armv7ve.inc | 2 +-
>> >>> >>  meta/conf/machine/include/tune-arm1136jf-s.inc | 2 +-
>> >>> >>  meta/conf/machine/include/tune-cortexa15.inc   | 2 +-
>> >>> >>  meta/conf/machine/include/tune-cortexa17.inc   | 2 +-
>> >>> >>  meta/conf/machine/include/tune-cortexa5.inc    | 2 +-
>> >>> >>  meta/conf/machine/include/tune-cortexa7.inc    | 2 +-
>> >>> >>  meta/conf/machine/include/tune-cortexa8.inc    | 2 +-
>> >>> >>  meta/conf/machine/include/tune-cortexa9.inc    | 2 +-
>> >>> >>  10 files changed, 10 insertions(+), 10 deletions(-)
>> >>> >>
>> >>> >> diff --git a/meta/conf/machine/include/arm/arch-armv6.inc
>> >>> >> b/meta/conf/machine/include/arm/arch-armv6.inc
>> >>> >> index 91f0f07..5e1f973 100644
>> >>> >> --- a/meta/conf/machine/include/arm/arch-armv6.inc
>> >>> >> +++ b/meta/conf/machine/include/arm/arch-armv6.inc
>> >>> >> @@ -1,4 +1,4 @@
>> >>> >> -DEFAULTTUNE ?= "armv6"
>> >>> >> +DEFAULTTUNE ?= "armv6thf"
>> >>> >>
>> >>> >>  TUNEVALID[armv6] = "Enable instructions for ARMv6"
>> >>> >>  TUNECONFLICTS[armv6] = "armv4 armv5"
>> >>> >> diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc
>> >>> >> b/meta/conf/machine/include/arm/arch-armv7a.inc
>> >>> >> index 5446048..bad1c27 100644
>> >>> >> --- a/meta/conf/machine/include/arm/arch-armv7a.inc
>> >>> >> +++ b/meta/conf/machine/include/arm/arch-armv7a.inc
>> >>> >> @@ -1,4 +1,4 @@
>> >>> >> -DEFAULTTUNE ?= "armv7a"
>> >>> >> +DEFAULTTUNE ?= "armv7athf"
>> >>> >>
>> >>> >>  TUNEVALID[armv7a] = "Enable instructions for ARMv7-a"
>> >>> >>  TUNECONFLICTS[armv7a] = "armv4 armv5 armv6 armv7"
>> >>> >> diff --git a/meta/conf/machine/include/arm/arch-armv7ve.inc
>> >>> >> b/meta/conf/machine/include/arm/arch-armv7ve.inc
>> >>> >> index 42d8d04..4d9260f 100644
>> >>> >> --- a/meta/conf/machine/include/arm/arch-armv7ve.inc
>> >>> >> +++ b/meta/conf/machine/include/arm/arch-armv7ve.inc
>> >>> >> @@ -1,4 +1,4 @@
>> >>> >> -DEFAULTTUNE ?= "armv7ve"
>> >>> >> +DEFAULTTUNE ?= "armv7vethf"
>> >>> >>
>> >>> >>  TUNEVALID[armv7ve] = "Enable instructions for ARMv7ve"
>> >>> >>  TUNECONFLICTS[armv7ve] = "armv4 armv5 armv6 armv7 armv7a"
>> >>> >> diff --git a/meta/conf/machine/include/tune-arm1136jf-s.inc
>> >>> >> b/meta/conf/machine/include/tune-arm1136jf-s.inc
>> >>> >> index 53994ef..2cadbee 100644
>> >>> >> --- a/meta/conf/machine/include/tune-arm1136jf-s.inc
>> >>> >> +++ b/meta/conf/machine/include/tune-arm1136jf-s.inc
>> >>> >> @@ -1,4 +1,4 @@
>> >>> >> -DEFAULTTUNE ?= "armv6"
>> >>> >> +DEFAULTTUNE ?= "armv6thf"
>> >>> >>
>> >>> >>  require conf/machine/include/arm/arch-armv6.inc
>> >>> >>
>> >>> >> diff --git a/meta/conf/machine/include/tune-cortexa15.inc
>> >>> >> b/meta/conf/machine/include/tune-cortexa15.inc
>> >>> >> index 03de602..25e99f9 100644
>> >>> >> --- a/meta/conf/machine/include/tune-cortexa15.inc
>> >>> >> +++ b/meta/conf/machine/include/tune-cortexa15.inc
>> >>> >> @@ -1,4 +1,4 @@
>> >>> >> -DEFAULTTUNE ?= "armv7ve-neon"
>> >>> >> +DEFAULTTUNE ?= "armv7vethf-neon"
>> >>> >>
>> >>> >>  require conf/machine/include/arm/arch-armv7ve.inc
>> >>> >>
>> >>> >> diff --git a/meta/conf/machine/include/tune-cortexa17.inc
>> >>> >> b/meta/conf/machine/include/tune-cortexa17.inc
>> >>> >> index f659a62..40392f9 100644
>> >>> >> --- a/meta/conf/machine/include/tune-cortexa17.inc
>> >>> >> +++ b/meta/conf/machine/include/tune-cortexa17.inc
>> >>> >> @@ -1,4 +1,4 @@
>> >>> >> -DEFAULTTUNE ?= "armv7ve-neon"
>> >>> >> +DEFAULTTUNE ?= "armv7vethf-neon"
>> >>> >>
>> >>> >>  require conf/machine/include/arm/arch-armv7ve.inc
>> >>> >>
>> >>> >> diff --git a/meta/conf/machine/include/tune-cortexa5.inc
>> >>> >> b/meta/conf/machine/include/tune-cortexa5.inc
>> >>> >> index 93f9ca4..1f0cda6 100644
>> >>> >> --- a/meta/conf/machine/include/tune-cortexa5.inc
>> >>> >> +++ b/meta/conf/machine/include/tune-cortexa5.inc
>> >>> >> @@ -1,4 +1,4 @@
>> >>> >> -DEFAULTTUNE ?= "armv7a-neon"
>> >>> >> +DEFAULTTUNE ?= "armv7athf-neon"
>> >>> >>
>> >>> >>  require conf/machine/include/arm/arch-armv7a.inc
>> >>> >>
>> >>> >> diff --git a/meta/conf/machine/include/tune-cortexa7.inc
>> >>> >> b/meta/conf/machine/include/tune-cortexa7.inc
>> >>> >> index 52e06b8..52415d9 100644
>> >>> >> --- a/meta/conf/machine/include/tune-cortexa7.inc
>> >>> >> +++ b/meta/conf/machine/include/tune-cortexa7.inc
>> >>> >> @@ -1,4 +1,4 @@
>> >>> >> -DEFAULTTUNE ?= "armv7ve-neon"
>> >>> >> +DEFAULTTUNE ?= "armv7vethf-neon"
>> >>> >>
>> >>> >>  require conf/machine/include/arm/arch-armv7ve.inc
>> >>> >>
>> >>> >> diff --git a/meta/conf/machine/include/tune-cortexa8.inc
>> >>> >> b/meta/conf/machine/include/tune-cortexa8.inc
>> >>> >> index a831bd5..8ee8de9 100644
>> >>> >> --- a/meta/conf/machine/include/tune-cortexa8.inc
>> >>> >> +++ b/meta/conf/machine/include/tune-cortexa8.inc
>> >>> >> @@ -1,4 +1,4 @@
>> >>> >> -DEFAULTTUNE ?= "armv7a-neon"
>> >>> >> +DEFAULTTUNE ?= "armv7athf-neon"
>> >>> >>
>> >>> >>  require conf/machine/include/arm/arch-armv7a.inc
>> >>> >>
>> >>> >> diff --git a/meta/conf/machine/include/tune-cortexa9.inc
>> >>> >> b/meta/conf/machine/include/tune-cortexa9.inc
>> >>> >> index 8b84e60..0cf323c 100644
>> >>> >> --- a/meta/conf/machine/include/tune-cortexa9.inc
>> >>> >> +++ b/meta/conf/machine/include/tune-cortexa9.inc
>> >>> >> @@ -1,4 +1,4 @@
>> >>> >> -DEFAULTTUNE ?= "armv7a-neon"
>> >>> >> +DEFAULTTUNE ?= "armv7athf-neon"
>> >>> >>
>> >>> >>  require conf/machine/include/arm/arch-armv7a.inc
>> >>> >>
>> >>> >> --
>> >>> >> 1.9.1
>> >>> >>
>> >>> >> --
>> >>> >> _______________________________________________
>> >>> >> Openembedded-core mailing list
>> >>> >> Openembedded-core@lists.openembedded.org
>> >>> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> >>
>> >>
>> >> --
>> >> _______________________________________________
>> >> Openembedded-core mailing list
>> >> Openembedded-core@lists.openembedded.org
>> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> >>
>> >
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com


^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-03-09 23:24 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-06 21:47 [PATCH] conf/machine/include: enable hardfloat by default for ARMv6 and above Andre McCurdy
2017-03-06 22:37 ` Khem Raj
2017-03-06 22:51   ` Andre McCurdy
2017-03-06 23:06     ` Andre McCurdy
2017-03-06 23:35     ` Khem Raj
2017-03-09  8:18       ` Martin Jansa
2017-03-09 20:09         ` Andre McCurdy
2017-03-09 23:09           ` Martin Jansa
2017-03-09 23:24             ` Andre McCurdy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.