From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
konishi.ryusuke@lab.ntt.co.jp, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-nilfs@vger.kernel.org, ross.zwisler@linux.intel.com,
jack@suse.cz, neilb@suse.com, openosd@gmail.com,
adilger@dilger.ca, James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH v2 5/9] dax: set error in mapping when writeback fails
Date: Thu, 9 Mar 2017 17:21:06 -0700 [thread overview]
Message-ID: <20170310002106.GD30285@linux.intel.com> (raw)
In-Reply-To: <20170308162934.21989-6-jlayton@redhat.com>
On Wed, Mar 08, 2017 at 11:29:30AM -0500, Jeff Layton wrote:
> In order to get proper error codes from fsync, we must set an error in
> the mapping range when writeback fails.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
Yep, paired with the changes to filmap_write_and_wait() and
filemap_write_and_wait_range(), this seems fine.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
konishi.ryusuke@lab.ntt.co.jp, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-nilfs@vger.kernel.org, ross.zwisler@linux.intel.com,
jack@suse.cz, neilb@suse.com, openosd@gmail.com,
adilger@dilger.ca, James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH v2 5/9] dax: set error in mapping when writeback fails
Date: Thu, 9 Mar 2017 17:21:06 -0700 [thread overview]
Message-ID: <20170310002106.GD30285@linux.intel.com> (raw)
In-Reply-To: <20170308162934.21989-6-jlayton@redhat.com>
On Wed, Mar 08, 2017 at 11:29:30AM -0500, Jeff Layton wrote:
> In order to get proper error codes from fsync, we must set an error in
> the mapping range when writeback fails.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
Yep, paired with the changes to filmap_write_and_wait() and
filemap_write_and_wait_range(), this seems fine.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
next prev parent reply other threads:[~2017-03-10 0:21 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 16:29 [PATCH v2 0/9] mm/fs: get PG_error out of the writeback reporting business Jeff Layton
2017-03-08 16:29 ` Jeff Layton
2017-03-08 16:29 ` [PATCH v2 1/9] mm: fix mapping_set_error call in me_pagecache_dirty Jeff Layton
2017-03-08 16:29 ` Jeff Layton
2017-03-10 0:06 ` Ross Zwisler
2017-03-10 0:06 ` Ross Zwisler
2017-03-08 16:29 ` [PATCH v2 2/9] mm: drop "wait" parameter from write_one_page Jeff Layton
2017-03-08 16:29 ` Jeff Layton
2017-03-10 0:07 ` Ross Zwisler
2017-03-10 0:07 ` Ross Zwisler
2017-03-08 16:29 ` [PATCH v2 3/9] mm: clear any AS_* errors when returning error on any fsync or close Jeff Layton
2017-03-08 16:29 ` Jeff Layton
2017-03-08 21:23 ` NeilBrown
2017-03-09 0:10 ` Jeff Layton
2017-03-09 0:10 ` Jeff Layton
2017-03-10 0:09 ` Ross Zwisler
2017-03-10 0:09 ` Ross Zwisler
2017-03-10 3:08 ` Jeff Layton
2017-03-10 3:08 ` Jeff Layton
2017-03-10 3:08 ` Jeff Layton
2017-03-10 3:08 ` Jeff Layton
2017-03-08 16:29 ` [PATCH v2 4/9] nilfs2: set the mapping error when calling SetPageError on writeback Jeff Layton
2017-03-08 16:29 ` Jeff Layton
2017-03-08 16:29 ` [PATCH v2 5/9] dax: set error in mapping when writeback fails Jeff Layton
2017-03-08 16:29 ` Jeff Layton
2017-03-10 0:21 ` Ross Zwisler [this message]
2017-03-10 0:21 ` Ross Zwisler
2017-03-08 16:29 ` [PATCH v2 6/9] mm: set mapping error when launder_pages fails Jeff Layton
2017-03-08 16:29 ` Jeff Layton
2017-03-08 18:01 ` Trond Myklebust
2017-03-08 18:01 ` Trond Myklebust
2017-03-08 18:38 ` Jeff Layton
2017-03-08 18:38 ` Jeff Layton
2017-03-08 18:38 ` Jeff Layton
2017-03-08 19:16 ` Trond Myklebust
2017-03-08 21:28 ` NeilBrown
2017-03-08 21:28 ` NeilBrown
2017-03-08 16:29 ` [PATCH v2 7/9] mm: ensure that we set mapping error if writeout() fails Jeff Layton
2017-03-08 16:29 ` Jeff Layton
2017-03-08 16:29 ` [PATCH v2 8/9] mm: don't TestClearPageError in __filemap_fdatawait_range Jeff Layton
2017-03-08 16:29 ` Jeff Layton
2017-03-08 16:29 ` [PATCH v2 9/9] Documentation: document what to do on a writeback error Jeff Layton
2017-03-08 16:29 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170310002106.GD30285@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=adilger@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=jlayton@redhat.com \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=neilb@suse.com \
--cc=openosd@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.