All of lore.kernel.org
 help / color / mirror / Atom feed
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: xilinx: Make Xilinx VDMA support ARC
Date: Fri, 10 Mar 2017 10:03:11 +0530	[thread overview]
Message-ID: <20170310043311.GV2843@localhost> (raw)
In-Reply-To: <c1285d07-f925-2c3a-c90c-1ef9ee948b80@synopsys.com>

On Thu, Mar 09, 2017 at 09:55:59AM +0000, Ramiro Oliveira wrote:
> Hi Mike
> 
> On 3/9/2017 7:37 AM, Mike Looijmans wrote:
> > On 06-03-17 13:27, Ramiro Oliveira wrote:
> >> Add option in Kconfig to use Xilinx VDMA in ARC processors.
> >>
> >> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
> >> ---
> >>  drivers/dma/Kconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> >> index 263495d0adbd..b6b6c0581ad7 100644
> >> --- a/drivers/dma/Kconfig
> >> +++ b/drivers/dma/Kconfig
> >> @@ -546,7 +546,7 @@ config XGENE_DMA
> >>
> >>  config XILINX_DMA
> >>      tristate "Xilinx AXI DMAS Engine"
> >> -    depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> >> +    depends on (ARCH_ZYNQ || MICROBLAZE || ARM64|| ARC)
> > 
> > One can put a Xilinx FPGA on a PCIe card, instantiate a PCIe-AXI bridge and then
> > use it on any platform that supports PCIe.
> > 
> > I've had to remove this line in order to be able to use the engine on an x86
> > desktop.
> > 
> > How about plainly removing this "depends on" line and be done with it, instead
> > of adding platforms one by one?
> > 
> > 
> 
> I agree with you. From my point of view it would be better to remove this line
> entirely. I'm just not sure if everyone agrees.

if it works on others, compiles fine then there should not be an issue to
remove.

Feel free to send the patch.

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Ramiro Oliveira
	<Ramiro.Oliveira-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
Cc: Mike Looijmans <mike.looijmans-Oq418RWZeHk@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Dan Williams
	<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	CARLOS.PALMINHA-HKixBCOQz3hWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH] dma: xilinx: Make Xilinx VDMA support ARC
Date: Fri, 10 Mar 2017 10:03:11 +0530	[thread overview]
Message-ID: <20170310043311.GV2843@localhost> (raw)
In-Reply-To: <c1285d07-f925-2c3a-c90c-1ef9ee948b80-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>

On Thu, Mar 09, 2017 at 09:55:59AM +0000, Ramiro Oliveira wrote:
> Hi Mike
> 
> On 3/9/2017 7:37 AM, Mike Looijmans wrote:
> > On 06-03-17 13:27, Ramiro Oliveira wrote:
> >> Add option in Kconfig to use Xilinx VDMA in ARC processors.
> >>
> >> Signed-off-by: Ramiro Oliveira <roliveir-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
> >> ---
> >>  drivers/dma/Kconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> >> index 263495d0adbd..b6b6c0581ad7 100644
> >> --- a/drivers/dma/Kconfig
> >> +++ b/drivers/dma/Kconfig
> >> @@ -546,7 +546,7 @@ config XGENE_DMA
> >>
> >>  config XILINX_DMA
> >>      tristate "Xilinx AXI DMAS Engine"
> >> -    depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> >> +    depends on (ARCH_ZYNQ || MICROBLAZE || ARM64|| ARC)
> > 
> > One can put a Xilinx FPGA on a PCIe card, instantiate a PCIe-AXI bridge and then
> > use it on any platform that supports PCIe.
> > 
> > I've had to remove this line in order to be able to use the engine on an x86
> > desktop.
> > 
> > How about plainly removing this "depends on" line and be done with it, instead
> > of adding platforms one by one?
> > 
> > 
> 
> I agree with you. From my point of view it would be better to remove this line
> entirely. I'm just not sure if everyone agrees.

if it works on others, compiles fine then there should not be an issue to
remove.

Feel free to send the patch.

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Ramiro Oliveira <Ramiro.Oliveira@synopsys.com>
Cc: Mike Looijmans <mike.looijmans@topic.nl>,
	linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Dan Williams <dan.j.williams@intel.com>,
	CARLOS.PALMINHA@synopsys.com
Subject: Re: [PATCH] dma: xilinx: Make Xilinx VDMA support ARC
Date: Fri, 10 Mar 2017 10:03:11 +0530	[thread overview]
Message-ID: <20170310043311.GV2843@localhost> (raw)
In-Reply-To: <c1285d07-f925-2c3a-c90c-1ef9ee948b80@synopsys.com>

On Thu, Mar 09, 2017 at 09:55:59AM +0000, Ramiro Oliveira wrote:
> Hi Mike
> 
> On 3/9/2017 7:37 AM, Mike Looijmans wrote:
> > On 06-03-17 13:27, Ramiro Oliveira wrote:
> >> Add option in Kconfig to use Xilinx VDMA in ARC processors.
> >>
> >> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
> >> ---
> >>  drivers/dma/Kconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> >> index 263495d0adbd..b6b6c0581ad7 100644
> >> --- a/drivers/dma/Kconfig
> >> +++ b/drivers/dma/Kconfig
> >> @@ -546,7 +546,7 @@ config XGENE_DMA
> >>
> >>  config XILINX_DMA
> >>      tristate "Xilinx AXI DMAS Engine"
> >> -    depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> >> +    depends on (ARCH_ZYNQ || MICROBLAZE || ARM64|| ARC)
> > 
> > One can put a Xilinx FPGA on a PCIe card, instantiate a PCIe-AXI bridge and then
> > use it on any platform that supports PCIe.
> > 
> > I've had to remove this line in order to be able to use the engine on an x86
> > desktop.
> > 
> > How about plainly removing this "depends on" line and be done with it, instead
> > of adding platforms one by one?
> > 
> > 
> 
> I agree with you. From my point of view it would be better to remove this line
> entirely. I'm just not sure if everyone agrees.

if it works on others, compiles fine then there should not be an issue to
remove.

Feel free to send the patch.

-- 
~Vinod

  reply	other threads:[~2017-03-10  4:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-06 12:27 [PATCH] dma: xilinx: Make Xilinx VDMA support ARC Ramiro Oliveira
2017-03-06 12:27 ` Ramiro Oliveira
2017-03-06 12:27 ` Ramiro Oliveira
2017-03-09  7:37 ` Mike Looijmans
2017-03-09  7:37   ` Mike Looijmans
2017-03-09  7:37   ` Mike Looijmans
2017-03-09  9:55   ` Ramiro Oliveira
2017-03-09  9:55     ` Ramiro Oliveira
2017-03-09  9:55     ` Ramiro Oliveira
2017-03-10  4:33     ` Vinod Koul [this message]
2017-03-10  4:33       ` Vinod Koul
2017-03-10  4:33       ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170310043311.GV2843@localhost \
    --to=vinod.koul@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.