[PATCH 0/7] staging: wilc1000: Improve code readability

[PATCH 0/7] staging: wilc1000: Improve code readability

[Tamara Diaconita]

Improve code readability in wilc_spi.c file in wilc1000 driver.

Tamara Diaconita (7):
  staging: wilc1000: Remove unnecessary brackets
  staging: wilc1000: Declare variables at top of function
  staging: wilc1000: Correct name of variables
  staging: wilc1000: Add blank line
  staging: wilc1000: Removing extra tabs
  staging: wilc1000: Use kernel preferred commenting style
  staging: wilc1000: Rearrange code

 drivers/staging/wilc1000/wilc_spi.c | 101 +++++++++++++++++++-----------------
 1 file changed, 54 insertions(+), 47 deletions(-)

-- 
2.9.3

Re: [Outreachy kernel] [PATCH 0/7] staging: wilc1000: Improve code readability

[Alison Schofield]

On Fri, Mar 10, 2017 at 09:06:06PM +0200, Tamara Diaconita wrote:
> Improve code readability in wilc_spi.c file in wilc1000 driver.

Hi Tamara,

Just realized why my inbox is getting disorganized.  These patchsets
need to be sent 'threaded' so they stick together.  See how to do
that in the first patch tutorial.  

I'm already in the middle of your last patchset, so I will keep
going with that, but I think I'd like you to do a [PATCH RESEND]
on this one and send it threaded.  Basically the PATCH RESEND
says nothing has changed inside it.

Thanks,
alisons

> 
> Tamara Diaconita (7):
>   staging: wilc1000: Remove unnecessary brackets
>   staging: wilc1000: Declare variables at top of function
>   staging: wilc1000: Correct name of variables
>   staging: wilc1000: Add blank line
>   staging: wilc1000: Removing extra tabs
>   staging: wilc1000: Use kernel preferred commenting style
>   staging: wilc1000: Rearrange code
> 
>  drivers/staging/wilc1000/wilc_spi.c | 101 +++++++++++++++++++-----------------
>  1 file changed, 54 insertions(+), 47 deletions(-)
> 
> -- 
> 2.9.3
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170310190606.19766-1-diaconita.tamara%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.

Re: [Outreachy kernel] [PATCH 0/7] staging: wilc1000: Improve code readability

[Alison Schofield]

On Fri, Mar 10, 2017 at 11:20:57AM -0800, Alison Schofield wrote:
> On Fri, Mar 10, 2017 at 09:06:06PM +0200, Tamara Diaconita wrote:
> > Improve code readability in wilc_spi.c file in wilc1000 driver.
> 
> Hi Tamara,
> 
> Just realized why my inbox is getting disorganized.  These patchsets
> need to be sent 'threaded' so they stick together.  See how to do
> that in the first patch tutorial.  
> 
> I'm already in the middle of your last patchset, so I will keep
> going with that, but I think I'd like you to do a [PATCH RESEND]
> on this one and send it threaded.  Basically the PATCH RESEND
> says nothing has changed inside it.

Tamara,

OK...i peeked at it.  Please don't RESEND as is.  
The first 3 patches make a great set.  Improving the 
single func wilc_spi_read_int().

Can you resend just those top 3 as a single patch set,
and reflect that in your cover letter that you are

Note - I'm not disregarding patches 4-7, just don't think
they belong in the set. Hold onto them.

alisons




> 
> Thanks,
> alisons
> 
> > 
> > Tamara Diaconita (7):
> >   staging: wilc1000: Remove unnecessary brackets
> >   staging: wilc1000: Declare variables at top of function
> >   staging: wilc1000: Correct name of variables
> >   staging: wilc1000: Add blank line
> >   staging: wilc1000: Removing extra tabs
> >   staging: wilc1000: Use kernel preferred commenting style
> >   staging: wilc1000: Rearrange code
> > 
> >  drivers/staging/wilc1000/wilc_spi.c | 101 +++++++++++++++++++-----------------
> >  1 file changed, 54 insertions(+), 47 deletions(-)
> > 
> > -- 
> > 2.9.3
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170310190606.19766-1-diaconita.tamara%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.