Re: [Outreachy kernel] Doubt regarding use of a function

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Mar 10, 2017 at 06:50:22PM +0100, Julia Lawall wrote:
> 
> 
> On Fri, 10 Mar 2017, sayli karnik wrote:
> 
> > On Fri, Mar 10, 2017 at 10:56 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> > >
> > >
> > > On Fri, 10 Mar 2017, sayli karnik wrote:
> > >
> > >> ieee80211 has the following function which to me does nothing-
> > >> void ieee80211_tkip_null(void)
> > >> {
> > >>      printk("============>%s()\n", __func__);
> >
> > This printk is commented..forgot the '//' before it
> >
> > >>      return;
> > >> }
> > >>
> > >> Before its function call there is this comment-
> > >> /* These function were added to load crypte module autoly */
> > >>          ieee80211_tkip_null();
> > >>
> > >> Is this function needed in the driver? If not, can I send in a patch
> > >> removing it?
> > >
> > > Are there any maintainers associated with the file?  They would know
> > > better.  I can't see that the function is doing anything useful.
> > >
> > maintainer.pl just displays Greg.
> 
> Greg,
> 
> Is there a general policy about:
> 
> functions that do nothing
> code under comments
> boring logging message
> 
> Can we assume that the code as it is in staging basically works, and while
> these things may have been a useful reminder in the past, now they can go?

Yes.

> Or is that too much to assume for a general rule?

Nope, delete away!

But note, this code does do something, so that functionality needs to be
preserved.

thanks,

greg k-h