Re: [Outreachy kernel] Doubt regarding use of a function

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Mar 11, 2017 at 12:14:47PM +0530, sayli karnik wrote:
> On Sat, Mar 11, 2017 at 2:57 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Fri, Mar 10, 2017 at 10:54:10PM +0530, sayli karnik wrote:
> >> ieee80211 has the following function which to me does nothing-
> >> void ieee80211_tkip_null(void)
> >> {
> >>      printk("============>%s()\n", __func__);
> >>      return;
> >> }
> >
> > What exactly directory/file is this?
> >
> staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c: function definition
> staging/rtl8192u/ieee80211/ieee80211_module.c: function call

Ah, that trainwreck :(

> >> Before its function call there is this comment-
> >> /* These function were added to load crypte module autoly */
> >>          ieee80211_tkip_null();
> >>
> >> Is this function needed in the driver?
> >
> > Yes, the function says what it is there for.
> >
> >> If not, can I send in a patch removing it?
> >
> > If you do, you have to fix the auto-loading of the module properly :)
> >
> Is there a way to do that apart from the one currently used?

First determine if the comment is really correct or not.  Then you can
answer this question.  Maybe I was originally wrong in my statement,
I'll leave it up to you to do the research and figure it out :)

thanks,

greg k-h