All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/7] arm: dts: imx6qdl-icore: Add backlight support for lvds
Date: Mon, 13 Mar 2017 19:59:46 +0800	[thread overview]
Message-ID: <20170313115944.GD3618@dragon> (raw)
In-Reply-To: <1488957477-5621-1-git-send-email-jagan@openedev.com>

On Wed, Mar 08, 2017 at 12:47:51PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
> 
> This patch add support for lvds backlight on i.CoreM6 QDL
> variant boards.
> 
> Cc: Domenico Acri <domenico.acri@engicam.com>
> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

For sake of consistency, please use 'ARM: ...' than 'arm: ...' in
subject prefix for i.MX patches.

> ---
> Changes for v4, v3, v2:
> - none
> 
>  arch/arm/boot/dts/imx6qdl-icore.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi
> index 55bebfc..7dda608 100644
> --- a/arch/arm/boot/dts/imx6qdl-icore.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi
> @@ -48,6 +48,14 @@
>  		reg = <0x10000000 0x80000000>;
>  	};
>  
> +	backlight {
> +		compatible = "pwm-backlight";
> +		pwms = <&pwm3 0 100000>;
> +		brightness-levels = <0 4 8 16 32 64 128 255>;
> +		default-brightness-level = <7>;
> +		status = "okay";

The okay status doesn't make a difference for such case, and can be
saved.

> +	};
> +
>  	reg_3p3v: regulator-3p3v {
>  		compatible = "regulator-fixed";
>  		regulator-name = "3P3V";
> @@ -136,6 +144,12 @@
>  	status = "okay";
>  };
>  
> +&pwm3 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_pwm3>;
> +	status = "okay";
> +};
> +
>  &uart4 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_uart4>;
> @@ -246,6 +260,12 @@
>  		>;
>  	};
>  
> +	pinctrl_pwm3: pwm3grp-1 {

The '-1' suffix is meaningless.

Shawn

> +		fsl,pins = <
> +			MX6QDL_PAD_SD4_DAT1__PWM3_OUT 0x1b0b1
> +		>;
> +	};
> +
>  	pinctrl_usbotg: usbotggrp {
>  		fsl,pins = <
>  			MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
> -- 
> 1.9.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jagan Teki <jagan-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Matteo Lisi <matteo.lisi-4s7YQHO/iPVBDgjK7y7TUQ@public.gmane.org>,
	Michael Trimarchi
	<michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>,
	Jagan Teki
	<jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>,
	Domenico Acri
	<domenico.acri-4s7YQHO/iPVBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v4 1/7] arm: dts: imx6qdl-icore: Add backlight support for lvds
Date: Mon, 13 Mar 2017 19:59:46 +0800	[thread overview]
Message-ID: <20170313115944.GD3618@dragon> (raw)
In-Reply-To: <1488957477-5621-1-git-send-email-jagan-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>

On Wed, Mar 08, 2017 at 12:47:51PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
> 
> This patch add support for lvds backlight on i.CoreM6 QDL
> variant boards.
> 
> Cc: Domenico Acri <domenico.acri-4s7YQHO/iPVBDgjK7y7TUQ@public.gmane.org>
> Cc: Matteo Lisi <matteo.lisi-4s7YQHO/iPVBDgjK7y7TUQ@public.gmane.org>
> Cc: Michael Trimarchi <michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
> Cc: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>

For sake of consistency, please use 'ARM: ...' than 'arm: ...' in
subject prefix for i.MX patches.

> ---
> Changes for v4, v3, v2:
> - none
> 
>  arch/arm/boot/dts/imx6qdl-icore.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi
> index 55bebfc..7dda608 100644
> --- a/arch/arm/boot/dts/imx6qdl-icore.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi
> @@ -48,6 +48,14 @@
>  		reg = <0x10000000 0x80000000>;
>  	};
>  
> +	backlight {
> +		compatible = "pwm-backlight";
> +		pwms = <&pwm3 0 100000>;
> +		brightness-levels = <0 4 8 16 32 64 128 255>;
> +		default-brightness-level = <7>;
> +		status = "okay";

The okay status doesn't make a difference for such case, and can be
saved.

> +	};
> +
>  	reg_3p3v: regulator-3p3v {
>  		compatible = "regulator-fixed";
>  		regulator-name = "3P3V";
> @@ -136,6 +144,12 @@
>  	status = "okay";
>  };
>  
> +&pwm3 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_pwm3>;
> +	status = "okay";
> +};
> +
>  &uart4 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_uart4>;
> @@ -246,6 +260,12 @@
>  		>;
>  	};
>  
> +	pinctrl_pwm3: pwm3grp-1 {

The '-1' suffix is meaningless.

Shawn

> +		fsl,pins = <
> +			MX6QDL_PAD_SD4_DAT1__PWM3_OUT 0x1b0b1
> +		>;
> +	};
> +
>  	pinctrl_usbotg: usbotggrp {
>  		fsl,pins = <
>  			MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Jagan Teki <jagan@openedev.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Matteo Lisi <matteo.lisi@engicam.com>,
	Michael Trimarchi <michael@amarulasolutions.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Domenico Acri <domenico.acri@engicam.com>
Subject: Re: [PATCH v4 1/7] arm: dts: imx6qdl-icore: Add backlight support for lvds
Date: Mon, 13 Mar 2017 19:59:46 +0800	[thread overview]
Message-ID: <20170313115944.GD3618@dragon> (raw)
In-Reply-To: <1488957477-5621-1-git-send-email-jagan@openedev.com>

On Wed, Mar 08, 2017 at 12:47:51PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
> 
> This patch add support for lvds backlight on i.CoreM6 QDL
> variant boards.
> 
> Cc: Domenico Acri <domenico.acri@engicam.com>
> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

For sake of consistency, please use 'ARM: ...' than 'arm: ...' in
subject prefix for i.MX patches.

> ---
> Changes for v4, v3, v2:
> - none
> 
>  arch/arm/boot/dts/imx6qdl-icore.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi
> index 55bebfc..7dda608 100644
> --- a/arch/arm/boot/dts/imx6qdl-icore.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi
> @@ -48,6 +48,14 @@
>  		reg = <0x10000000 0x80000000>;
>  	};
>  
> +	backlight {
> +		compatible = "pwm-backlight";
> +		pwms = <&pwm3 0 100000>;
> +		brightness-levels = <0 4 8 16 32 64 128 255>;
> +		default-brightness-level = <7>;
> +		status = "okay";

The okay status doesn't make a difference for such case, and can be
saved.

> +	};
> +
>  	reg_3p3v: regulator-3p3v {
>  		compatible = "regulator-fixed";
>  		regulator-name = "3P3V";
> @@ -136,6 +144,12 @@
>  	status = "okay";
>  };
>  
> +&pwm3 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_pwm3>;
> +	status = "okay";
> +};
> +
>  &uart4 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_uart4>;
> @@ -246,6 +260,12 @@
>  		>;
>  	};
>  
> +	pinctrl_pwm3: pwm3grp-1 {

The '-1' suffix is meaningless.

Shawn

> +		fsl,pins = <
> +			MX6QDL_PAD_SD4_DAT1__PWM3_OUT 0x1b0b1
> +		>;
> +	};
> +
>  	pinctrl_usbotg: usbotggrp {
>  		fsl,pins = <
>  			MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
> -- 
> 1.9.1
> 

  parent reply	other threads:[~2017-03-13 11:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08  7:17 [PATCH v4 1/7] arm: dts: imx6qdl-icore: Add backlight support for lvds Jagan Teki
2017-03-08  7:17 ` Jagan Teki
2017-03-08  7:17 ` Jagan Teki
2017-03-08  7:17 ` [PATCH v4 2/7] arm: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual OpenFrame Cap 10.1 initial support Jagan Teki
2017-03-08  7:17   ` Jagan Teki
2017-03-08  7:17   ` Jagan Teki
2017-03-08  7:17 ` [PATCH v4 3/7] arm: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual OpenFrame Cap 12.3 " Jagan Teki
2017-03-08  7:17   ` Jagan Teki
2017-03-08  7:17   ` Jagan Teki
2017-03-08  7:17 ` [PATCH v4 4/7] arm: dts: imx6q-icore: Add LVDS support Jagan Teki
2017-03-08  7:17   ` Jagan Teki
2017-03-08  7:17   ` Jagan Teki
2017-03-08  7:17 ` [PATCH v4 5/7] arm: dts: imx6q-icore: Add touchscreen node Jagan Teki
2017-03-08  7:17   ` Jagan Teki
2017-03-13 12:22   ` Shawn Guo
2017-03-13 12:22     ` Shawn Guo
2017-03-08  7:17 ` [PATCH v4 6/7] arm: imx_v6_v7_defconfig: Select max11801_ts touchscreen driver Jagan Teki
2017-03-08  7:17   ` Jagan Teki
2017-03-08  7:17 ` [PATCH v4 7/7] arm: imx_v6_v7_defconfig: Select hid-multitouchdriver Jagan Teki
2017-03-08  7:17   ` Jagan Teki
2017-03-08  7:17   ` Jagan Teki
2017-03-13 11:59 ` Shawn Guo [this message]
2017-03-13 11:59   ` [PATCH v4 1/7] arm: dts: imx6qdl-icore: Add backlight support for lvds Shawn Guo
2017-03-13 11:59   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170313115944.GD3618@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.