From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Craig Inches <Craig@craiginches.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
oleg.drokin@intel.com, andreas.dilger@intel.com,
lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH] staging: lustre fix constant comparision style issue in lu_object.h
Date: Mon, 13 Mar 2017 15:11:10 +0300 [thread overview]
Message-ID: <20170313121110.GD4136@mwanda> (raw)
In-Reply-To: <20170312133722.GC27791@kroah.com>
On Sun, Mar 12, 2017 at 02:37:22PM +0100, Greg KH wrote:
> On Sat, Mar 11, 2017 at 01:07:40PM +0000, Craig Inches wrote:
> > This patch resolves the "Comparisons should place the constant on
> > the right side of the test" found with checkpatch tool.
>
> Both are constants, I think checkpatch is the thing that is wrong here,
> don't you agree?
Sort of constant-ish... The sizeof(*value) changes each time the macro
is used. I feel like checkpatch is right.
regads,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Craig Inches <Craig@craiginches.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
oleg.drokin@intel.com, andreas.dilger@intel.com,
lustre-devel@lists.lustre.org
Subject: Re: [PATCH] staging: lustre fix constant comparision style issue in lu_object.h
Date: Mon, 13 Mar 2017 15:11:10 +0300 [thread overview]
Message-ID: <20170313121110.GD4136@mwanda> (raw)
In-Reply-To: <20170312133722.GC27791@kroah.com>
On Sun, Mar 12, 2017 at 02:37:22PM +0100, Greg KH wrote:
> On Sat, Mar 11, 2017 at 01:07:40PM +0000, Craig Inches wrote:
> > This patch resolves the "Comparisons should place the constant on
> > the right side of the test" found with checkpatch tool.
>
> Both are constants, I think checkpatch is the thing that is wrong here,
> don't you agree?
Sort of constant-ish... The sizeof(*value) changes each time the macro
is used. I feel like checkpatch is right.
regads,
dan carpenter
next prev parent reply other threads:[~2017-03-13 12:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 13:07 [lustre-devel] [PATCH] staging: lustre fix constant comparision style issue in lu_object.h Craig Inches
2017-03-11 13:07 ` Craig Inches
2017-03-12 13:37 ` [lustre-devel] " Greg KH
2017-03-12 13:37 ` Greg KH
2017-03-13 12:11 ` Dan Carpenter [this message]
2017-03-13 12:11 ` Dan Carpenter
2017-03-13 13:13 ` [lustre-devel] " Craig Inches
2017-03-13 13:13 ` Craig Inches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313121110.GD4136@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Craig@craiginches.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.