Re: [PATCH v1 09/10] mm: make rmap_one boolean function

[Minchan Kim <minchan@kernel.org>]

Hi Andrew,

On Mon, Mar 13, 2017 at 12:45:00PM -0700, Andrew Morton wrote:
> On Mon, 13 Mar 2017 09:35:52 +0900 Minchan Kim <minchan@kernel.org> wrote:
> 
> > rmap_one's return value controls whether rmap_work should contine to
> > scan other ptes or not so it's target for changing to boolean.
> > Return true if the scan should be continued. Otherwise, return false
> > to stop the scanning.
> > 
> > This patch makes rmap_one's return value to boolean.
> 
> "SWAP_AGAIN" conveys meaning to the reader, whereas the meaning of
> "true" is unclear.  So it would be better to document the return value
> of these functions.

Fair enough.
I will add description like this.

        /*
         * Return false if page table scanning in rmap_walk should be stopped.
         * Otherwise, return true.
         */
        bool (*rmap_one)(struct page *page, struct vm_area_struct *vma,
                                        unsigned long addr, void *arg);


I will wait by noon tomorrow and if there are no further comment,
I will resend v2.

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>