From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] ARM: omap2: mark omap_init_rng as __init
Date: Tue, 14 Mar 2017 14:27:46 -0700 [thread overview]
Message-ID: <20170314212746.GH20572@atomide.com> (raw)
In-Reply-To: <20170314212500.3612283-1-arnd@arndb.de>
* Arnd Bergmann <arnd@arndb.de> [170314 14:27]:
> I found this section mismatch when building with an older
> compiler release:
>
> WARNING: vmlinux.o(.text+0x3051c): Section mismatch in reference from the function omap_init_rng() to the function .init.text:omap_device_build()
>
> Obviously this one function should be __init as well. Normally
> we don't get a warning as the function gets inlined into its
> caller.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> Originally submitted on Dec 16. Tony, could you pick it up for v4.12?
> We haven't started merging stuff yet, and I forgot to apply it earlier
> but want to get it out of my backlog.
OK will pick it up thanks.
Tony
> ---
> arch/arm/mach-omap2/devices.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index 3fdb94599184..473951203104 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -121,7 +121,7 @@ static inline void omap_init_mcspi(void) {}
> *
> * Bind the RNG hwmod to the RNG omap_device. No return value.
> */
> -static void omap_init_rng(void)
> +static void __init omap_init_rng(void)
> {
> struct omap_hwmod *oh;
> struct platform_device *pdev;
> --
> 2.9.0
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH] ARM: omap2: mark omap_init_rng as __init
Date: Tue, 14 Mar 2017 14:27:46 -0700 [thread overview]
Message-ID: <20170314212746.GH20572@atomide.com> (raw)
In-Reply-To: <20170314212500.3612283-1-arnd@arndb.de>
* Arnd Bergmann <arnd@arndb.de> [170314 14:27]:
> I found this section mismatch when building with an older
> compiler release:
>
> WARNING: vmlinux.o(.text+0x3051c): Section mismatch in reference from the function omap_init_rng() to the function .init.text:omap_device_build()
>
> Obviously this one function should be __init as well. Normally
> we don't get a warning as the function gets inlined into its
> caller.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> Originally submitted on Dec 16. Tony, could you pick it up for v4.12?
> We haven't started merging stuff yet, and I forgot to apply it earlier
> but want to get it out of my backlog.
OK will pick it up thanks.
Tony
> ---
> arch/arm/mach-omap2/devices.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index 3fdb94599184..473951203104 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -121,7 +121,7 @@ static inline void omap_init_mcspi(void) {}
> *
> * Bind the RNG hwmod to the RNG omap_device. No return value.
> */
> -static void omap_init_rng(void)
> +static void __init omap_init_rng(void)
> {
> struct omap_hwmod *oh;
> struct platform_device *pdev;
> --
> 2.9.0
>
next prev parent reply other threads:[~2017-03-14 21:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 21:24 [RESEND PATCH] ARM: omap2: mark omap_init_rng as __init Arnd Bergmann
2017-03-14 21:24 ` Arnd Bergmann
2017-03-14 21:24 ` Arnd Bergmann
2017-03-14 21:27 ` Tony Lindgren [this message]
2017-03-14 21:27 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314212746.GH20572@atomide.com \
--to=tony@atomide.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.