All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	Florian Westphal <fw@strlen.de>,
	linux-kernel@vger.kernel.org, coreteam@netfilter.org,
	netfilter-devel@vger.kernel.org,
	Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH net] bridge: ebtables: fix reception of frames DNAT-ed to bridge device
Date: Wed, 15 Mar 2017 23:06:05 +0100	[thread overview]
Message-ID: <20170315220605.GA1766@salvia> (raw)
In-Reply-To: <20170315211619.GA3464@otheros>

On Wed, Mar 15, 2017 at 10:16:19PM +0100, Linus Lüssing wrote:
> On Wed, Mar 15, 2017 at 07:15:39PM +0100, Pablo Neira Ayuso wrote:
> > Could you update ebtables dnat to check if the ethernet address
> > matches the one of the input bridge interface, so we mangle the
> > ->pkt_type accordingly from there, instead of doing this from the
> > core?
> 
> Actually, that was the approach I thought about and went for first
> (and it would probably work for me). Just checking against the
> bridge device's net_device::dev_addr.
> 
> I scratched it though, as I was afraid that the issue might still
> exist for people using some other upper device on top of the bridge
> device. For instance, macvlan? And iterating over the
> net_device::dev_addrs list seemed too costly for fast path to me.

I was more thinking of following the simple approach that we follow in
ebt_redirect_tg() by taking the input interface.

Anyway, I'm ok with this.

WARNING: multiple messages have this Message-ID (diff)
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	Florian Westphal <fw@strlen.de>,
	linux-kernel@vger.kernel.org, coreteam@netfilter.org,
	netfilter-devel@vger.kernel.org,
	Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net] bridge: ebtables: fix reception of frames DNAT-ed to bridge device
Date: Wed, 15 Mar 2017 23:06:05 +0100	[thread overview]
Message-ID: <20170315220605.GA1766@salvia> (raw)
In-Reply-To: <20170315211619.GA3464@otheros>

On Wed, Mar 15, 2017 at 10:16:19PM +0100, Linus Lüssing wrote:
> On Wed, Mar 15, 2017 at 07:15:39PM +0100, Pablo Neira Ayuso wrote:
> > Could you update ebtables dnat to check if the ethernet address
> > matches the one of the input bridge interface, so we mangle the
> > ->pkt_type accordingly from there, instead of doing this from the
> > core?
> 
> Actually, that was the approach I thought about and went for first
> (and it would probably work for me). Just checking against the
> bridge device's net_device::dev_addr.
> 
> I scratched it though, as I was afraid that the issue might still
> exist for people using some other upper device on top of the bridge
> device. For instance, macvlan? And iterating over the
> net_device::dev_addrs list seemed too costly for fast path to me.

I was more thinking of following the simple approach that we follow in
ebt_redirect_tg() by taking the input interface.

Anyway, I'm ok with this.

WARNING: multiple messages have this Message-ID (diff)
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: Florian Westphal <fw@strlen.de>,
	netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
	bridge@lists.linux-foundation.org,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] bridge: ebtables: fix reception of frames DNAT-ed to bridge device
Date: Wed, 15 Mar 2017 23:06:05 +0100	[thread overview]
Message-ID: <20170315220605.GA1766@salvia> (raw)
In-Reply-To: <20170315211619.GA3464@otheros>

On Wed, Mar 15, 2017 at 10:16:19PM +0100, Linus Lüssing wrote:
> On Wed, Mar 15, 2017 at 07:15:39PM +0100, Pablo Neira Ayuso wrote:
> > Could you update ebtables dnat to check if the ethernet address
> > matches the one of the input bridge interface, so we mangle the
> > ->pkt_type accordingly from there, instead of doing this from the
> > core?
> 
> Actually, that was the approach I thought about and went for first
> (and it would probably work for me). Just checking against the
> bridge device's net_device::dev_addr.
> 
> I scratched it though, as I was afraid that the issue might still
> exist for people using some other upper device on top of the bridge
> device. For instance, macvlan? And iterating over the
> net_device::dev_addrs list seemed too costly for fast path to me.

I was more thinking of following the simple approach that we follow in
ebt_redirect_tg() by taking the input interface.

Anyway, I'm ok with this.

  reply	other threads:[~2017-03-15 22:06 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15  3:18 [Bridge] [PATCH net] bridge: ebtables: fix reception of frames DNAT-ed to bridge device Linus Lüssing
2017-03-15  3:18 ` Linus Lüssing
2017-03-15  3:18 ` Linus Lüssing
2017-03-15 10:26 ` [Bridge] " Florian Westphal
2017-03-15 10:26   ` Florian Westphal
2017-03-15 10:42   ` [Bridge] " Pablo Neira Ayuso
2017-03-15 10:42     ` Pablo Neira Ayuso
2017-03-15 10:42     ` Pablo Neira Ayuso
2017-03-15 14:27     ` [Bridge] " Linus Lüssing
2017-03-15 14:27       ` Linus Lüssing
2017-03-15 14:27       ` Linus Lüssing
2017-03-15 18:15       ` [Bridge] " Pablo Neira Ayuso
2017-03-15 18:15         ` Pablo Neira Ayuso
2017-03-15 18:15         ` Pablo Neira Ayuso
2017-03-15 21:16         ` [Bridge] " Linus Lüssing
2017-03-15 21:16           ` Linus Lüssing
2017-03-15 22:06           ` Pablo Neira Ayuso [this message]
2017-03-15 22:06             ` Pablo Neira Ayuso
2017-03-15 22:06             ` Pablo Neira Ayuso
2017-03-17 13:10             ` [Bridge] " Pablo Neira Ayuso
2017-03-17 13:10               ` Pablo Neira Ayuso
2017-03-17 13:10               ` Pablo Neira Ayuso
2017-03-19 16:55               ` [Bridge] " Linus Lüssing
2017-03-19 16:55                 ` Linus Lüssing
2017-03-19 16:55                 ` Linus Lüssing
2017-03-21  0:09                 ` [Bridge] " Linus Lüssing
2017-03-21  0:09                   ` Linus Lüssing
2017-03-21 10:11                   ` [Bridge] " Pablo Neira Ayuso
2017-03-21 10:11                     ` Pablo Neira Ayuso
2017-03-15 10:34 ` [Bridge] " Pablo Neira Ayuso
2017-03-15 10:34   ` Pablo Neira Ayuso
2017-03-15 10:34   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170315220605.GA1766@salvia \
    --to=pablo@netfilter.org \
    --cc=bridge@lists.linux-foundation.org \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=linus.luessing@c0d3.blue \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.