* [PATCH] vc04_services: Fixing coding guideline error
@ 2017-03-15 6:31 ` Pushkar Jambhlekar
0 siblings, 0 replies; 10+ messages in thread
From: Pushkar Jambhlekar @ 2017-03-15 6:31 UTC (permalink / raw)
To: linux-arm-kernel
Fixing 'if' block coding style. '{' should follow 'if' for multiline block
Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
index 48984ab..ca896a5 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
@@ -797,8 +797,7 @@ int32_t vchi_get_peer_version(const VCHI_SERVICE_HANDLE_T handle, short *peer_ve
{
int32_t ret = -1;
SHIM_SERVICE_T *service = (SHIM_SERVICE_T *)handle;
- if (service)
- {
+ if (service) {
VCHIQ_STATUS_T status;
status = vchiq_get_peer_version(service->handle, peer_version);
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] vc04_services: Fixing coding guideline error @ 2017-03-15 6:31 ` Pushkar Jambhlekar 0 siblings, 0 replies; 10+ messages in thread From: Pushkar Jambhlekar @ 2017-03-15 6:31 UTC (permalink / raw) To: Stephen Warren, Lee Jones, Eric Anholt, Greg Kroah-Hartman, Michael Zoran, Daniel Stone, Stefan Wahren, Noralf Trønnes, Stafford Horne, Pushkar Jambhlekar, popcornmix Cc: moderated list:BROADCOM BCM2835 ARM ARCHITECTURE, moderated list:BROADCOM BCM2835 ARM ARCHITECTURE, open list:STAGING SUBSYSTEM, open list Fixing 'if' block coding style. '{' should follow 'if' for multiline block Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c index 48984ab..ca896a5 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c @@ -797,8 +797,7 @@ int32_t vchi_get_peer_version(const VCHI_SERVICE_HANDLE_T handle, short *peer_ve { int32_t ret = -1; SHIM_SERVICE_T *service = (SHIM_SERVICE_T *)handle; - if (service) - { + if (service) { VCHIQ_STATUS_T status; status = vchiq_get_peer_version(service->handle, peer_version); -- 2.7.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] vc04_services: Fixing coding guideline error 2017-03-15 6:31 ` Pushkar Jambhlekar @ 2017-03-16 5:31 ` Pushkar Jambhlekar -1 siblings, 0 replies; 10+ messages in thread From: Pushkar Jambhlekar @ 2017-03-16 5:31 UTC (permalink / raw) To: linux-arm-kernel Any comment? On Wed, Mar 15, 2017 at 12:01 PM, Pushkar Jambhlekar <pushkar.iit@gmail.com> wrote: > Fixing 'if' block coding style. '{' should follow 'if' for multiline block > > Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com> > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c > index 48984ab..ca896a5 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c > @@ -797,8 +797,7 @@ int32_t vchi_get_peer_version(const VCHI_SERVICE_HANDLE_T handle, short *peer_ve > { > int32_t ret = -1; > SHIM_SERVICE_T *service = (SHIM_SERVICE_T *)handle; > - if (service) > - { > + if (service) { > VCHIQ_STATUS_T status; > > status = vchiq_get_peer_version(service->handle, peer_version); > -- > 2.7.4 > -- Jambhlekar Pushkar Arun M.Tech IIT Roorkee ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] vc04_services: Fixing coding guideline error @ 2017-03-16 5:31 ` Pushkar Jambhlekar 0 siblings, 0 replies; 10+ messages in thread From: Pushkar Jambhlekar @ 2017-03-16 5:31 UTC (permalink / raw) To: Stephen Warren, Lee Jones, Eric Anholt, Greg Kroah-Hartman, Michael Zoran, Daniel Stone, Stefan Wahren, Noralf Trønnes, Stafford Horne, Pushkar Jambhlekar, popcornmix Cc: moderated list:BROADCOM BCM2835 ARM ARCHITECTURE, moderated list:BROADCOM BCM2835 ARM ARCHITECTURE, open list:STAGING SUBSYSTEM, open list Any comment? On Wed, Mar 15, 2017 at 12:01 PM, Pushkar Jambhlekar <pushkar.iit@gmail.com> wrote: > Fixing 'if' block coding style. '{' should follow 'if' for multiline block > > Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com> > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c > index 48984ab..ca896a5 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c > @@ -797,8 +797,7 @@ int32_t vchi_get_peer_version(const VCHI_SERVICE_HANDLE_T handle, short *peer_ve > { > int32_t ret = -1; > SHIM_SERVICE_T *service = (SHIM_SERVICE_T *)handle; > - if (service) > - { > + if (service) { > VCHIQ_STATUS_T status; > > status = vchiq_get_peer_version(service->handle, peer_version); > -- > 2.7.4 > -- Jambhlekar Pushkar Arun M.Tech IIT Roorkee ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] vc04_services: Fixing coding guideline error 2017-03-16 5:31 ` Pushkar Jambhlekar @ 2017-03-16 6:36 ` Greg Kroah-Hartman -1 siblings, 0 replies; 10+ messages in thread From: Greg Kroah-Hartman @ 2017-03-16 6:36 UTC (permalink / raw) To: linux-arm-kernel On Thu, Mar 16, 2017 at 11:01:38AM +0530, Pushkar Jambhlekar wrote: > Any comment? > > On Wed, Mar 15, 2017 at 12:01 PM, Pushkar Jambhlekar One day's response? Hah, give me a few weeks at best for trivial stuff like this please. Actually, I totally missed this in my last sweep of staging patches, because you forgot to include "Staging" in the subject line, so it will have to wait a few more days at the earliest. thanks, greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] vc04_services: Fixing coding guideline error @ 2017-03-16 6:36 ` Greg Kroah-Hartman 0 siblings, 0 replies; 10+ messages in thread From: Greg Kroah-Hartman @ 2017-03-16 6:36 UTC (permalink / raw) To: Pushkar Jambhlekar Cc: Stephen Warren, Lee Jones, Eric Anholt, Michael Zoran, Daniel Stone, Stefan Wahren, Noralf Trønnes, Stafford Horne, popcornmix, open list:STAGING SUBSYSTEM, moderated list:BROADCOM BCM2835 ARM ARCHITECTURE, moderated list:BROADCOM BCM2835 ARM ARCHITECTURE, open list On Thu, Mar 16, 2017 at 11:01:38AM +0530, Pushkar Jambhlekar wrote: > Any comment? > > On Wed, Mar 15, 2017 at 12:01 PM, Pushkar Jambhlekar One day's response? Hah, give me a few weeks at best for trivial stuff like this please. Actually, I totally missed this in my last sweep of staging patches, because you forgot to include "Staging" in the subject line, so it will have to wait a few more days at the earliest. thanks, greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] vc04_services: Fixing coding guideline error 2017-03-16 5:31 ` Pushkar Jambhlekar @ 2017-03-16 11:40 ` Dan Carpenter -1 siblings, 0 replies; 10+ messages in thread From: Dan Carpenter @ 2017-03-16 11:40 UTC (permalink / raw) To: linux-arm-kernel On Thu, Mar 16, 2017 at 11:01:38AM +0530, Pushkar Jambhlekar wrote: > Any comment? > You're too impatient. Wait for 2 weeks before asking for responses. regards, dan carpenter ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] vc04_services: Fixing coding guideline error @ 2017-03-16 11:40 ` Dan Carpenter 0 siblings, 0 replies; 10+ messages in thread From: Dan Carpenter @ 2017-03-16 11:40 UTC (permalink / raw) To: Pushkar Jambhlekar Cc: Stephen Warren, Lee Jones, Eric Anholt, Greg Kroah-Hartman, Michael Zoran, Daniel Stone, Stefan Wahren, Noralf Trønnes, Stafford Horne, popcornmix, open list:STAGING SUBSYSTEM, moderated list:BROADCOM BCM2835 ARM ARCHITECTURE, moderated list:BROADCOM BCM2835 ARM ARCHITECTURE, open list On Thu, Mar 16, 2017 at 11:01:38AM +0530, Pushkar Jambhlekar wrote: > Any comment? > You're too impatient. Wait for 2 weeks before asking for responses. regards, dan carpenter ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] vc04_services: Fixing coding guideline error 2017-03-15 6:31 ` Pushkar Jambhlekar @ 2017-03-21 7:37 ` Greg Kroah-Hartman -1 siblings, 0 replies; 10+ messages in thread From: Greg Kroah-Hartman @ 2017-03-21 7:37 UTC (permalink / raw) To: linux-arm-kernel On Wed, Mar 15, 2017 at 12:01:08PM +0530, Pushkar Jambhlekar wrote: > Fixing 'if' block coding style. '{' should follow 'if' for multiline block > > Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com> > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Patch does not apply to my tree at all, please rebase and refresh and resend. thanks, greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] vc04_services: Fixing coding guideline error @ 2017-03-21 7:37 ` Greg Kroah-Hartman 0 siblings, 0 replies; 10+ messages in thread From: Greg Kroah-Hartman @ 2017-03-21 7:37 UTC (permalink / raw) To: Pushkar Jambhlekar Cc: Stephen Warren, Lee Jones, Eric Anholt, Michael Zoran, Daniel Stone, Stefan Wahren, Noralf Trønnes, Stafford Horne, popcornmix, moderated list:BROADCOM BCM2835 ARM ARCHITECTURE, moderated list:BROADCOM BCM2835 ARM ARCHITECTURE, open list:STAGING SUBSYSTEM, open list On Wed, Mar 15, 2017 at 12:01:08PM +0530, Pushkar Jambhlekar wrote: > Fixing 'if' block coding style. '{' should follow 'if' for multiline block > > Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com> > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Patch does not apply to my tree at all, please rebase and refresh and resend. thanks, greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-03-21 7:38 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-03-15 6:31 [PATCH] vc04_services: Fixing coding guideline error Pushkar Jambhlekar 2017-03-15 6:31 ` Pushkar Jambhlekar 2017-03-16 5:31 ` Pushkar Jambhlekar 2017-03-16 5:31 ` Pushkar Jambhlekar 2017-03-16 6:36 ` Greg Kroah-Hartman 2017-03-16 6:36 ` Greg Kroah-Hartman 2017-03-16 11:40 ` Dan Carpenter 2017-03-16 11:40 ` Dan Carpenter 2017-03-21 7:37 ` Greg Kroah-Hartman 2017-03-21 7:37 ` Greg Kroah-Hartman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.