All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Wang Nan <wangnan0@huawei.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 'perf test tsc' failing, bisected to "sched/clock: Provide better clock continuity"
Date: Thu, 16 Mar 2017 16:22:31 -0300	[thread overview]
Message-ID: <20170316192231.GB12825@kernel.org> (raw)
In-Reply-To: <20170316192138.GA12825@kernel.org>

Em Thu, Mar 16, 2017 at 04:21:38PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Mar 16, 2017 at 03:36:17PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Thu, Mar 16, 2017 at 07:11:21PM +0100, Peter Zijlstra escreveu:
> > > On Thu, Mar 16, 2017 at 03:53:11PM +0100, Peter Zijlstra wrote:
> > > > On Thu, Mar 16, 2017 at 11:01:03AM -0300, Arnaldo Carvalho de Melo wrote:
> > > > > [root@jouet ~]# perf test -v tsc
> > > > > 55: Convert perf time to TSC                   :
> > > > > Convert perf time to TSC: FAILED!
> > > > >     sched/clock: Provide better clock continuity
> > 
> > > > Right, ahunter also complained about this. I had a half arsed fugly
> > > > patch in the works. Let me see if I can improve and finish.
> >  
> > > The below seems to cure things for me...
> > 
> > Building...
> 
> Didn't apply to perf/urgent:
> 
> [acme@jouet linux]$ patch -p1 < /wb/1.patch 
> patching file arch/x86/events/core.c
> Hunk #1 succeeded at 2243 (offset -1 lines).
> Hunk #2 succeeded at 2251 (offset -1 lines).
> Hunk #3 succeeded at 2265 (offset -1 lines).
> Hunk #4 succeeded at 2273 (offset -1 lines).
> patching file arch/x86/include/asm/timer.h
> patching file arch/x86/kernel/tsc.c
> Hunk #1 FAILED at 328.

perf/core almost super clean:

[acme@felicio linux]$ patch -p1 < /wb/1.patch 
patching file arch/x86/events/core.c
patching file arch/x86/include/asm/timer.h
patching file arch/x86/kernel/tsc.c
patching file include/linux/sched/clock.h
patching file kernel/sched/clock.c
Hunk #3 succeeded at 154 with fuzz 2 (offset -7 lines).
Hunk #4 succeeded at 231 (offset -7 lines).
Hunk #5 succeeded at 317 (offset -7 lines).
[acme@felicio linux]$

Building...

  reply	other threads:[~2017-03-16 19:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-16 14:01 'perf test tsc' failing, bisected to "sched/clock: Provide better clock continuity" Arnaldo Carvalho de Melo
2017-03-16 14:53 ` Peter Zijlstra
2017-03-16 18:11   ` Peter Zijlstra
2017-03-16 18:36     ` Arnaldo Carvalho de Melo
2017-03-16 19:21       ` Arnaldo Carvalho de Melo
2017-03-16 19:22         ` Arnaldo Carvalho de Melo [this message]
2017-03-20 13:20           ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170316192231.GB12825@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=arnaldo.melo@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.