From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: kernel test robot <fengguang.wu@intel.com>, LKP <lkp@01.org>,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
wfg@linux.intel.com
Subject: [rtc-linux] Re: [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690 kobject_put
Date: Fri, 17 Mar 2017 15:13:34 +0900 [thread overview]
Message-ID: <20170317061334.GA2847@kroah.com> (raw)
In-Reply-To: <20170317061137.GA21612@kroah.com>
On Fri, Mar 17, 2017 at 03:11:37PM +0900, Greg Kroah-Hartman wrote:
> On Thu, Mar 16, 2017 at 11:23:26PM -0600, Logan Gunthorpe wrote:
> > Hey,
> >
> > I think I see the issue here: in a couple of error conditions, the RTC
> > code will not initialize and ask for the cdev. However, my change will
> > always call cdev_add and cdev_del even though the rtc code did not call
> > cdev_init. I'll have to add a guard around dev->devt in the new
> > cdev_device functions. I'll prepare another patch tomorrow.
> >
> > I also noticed that I neglected to remove the prototypes for the two RTC
> > function I removed. I'll fix that too.
>
> Ok, I'm just going to drop this series from my tree so that other
> patches in it can get pushed out to linux-next. Please resend the full
> series after you have fixed it up, and I'll be glad to queue it up
> again.
Also, when you resend, if you can collect the acks from the subsystem
maintainers, and add them to the patches, that would be very good.
thanks,
greg k-h
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: lkp@lists.01.org
Subject: Re: [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690 kobject_put
Date: Fri, 17 Mar 2017 15:13:34 +0900 [thread overview]
Message-ID: <20170317061334.GA2847@kroah.com> (raw)
In-Reply-To: <20170317061137.GA21612@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]
On Fri, Mar 17, 2017 at 03:11:37PM +0900, Greg Kroah-Hartman wrote:
> On Thu, Mar 16, 2017 at 11:23:26PM -0600, Logan Gunthorpe wrote:
> > Hey,
> >
> > I think I see the issue here: in a couple of error conditions, the RTC
> > code will not initialize and ask for the cdev. However, my change will
> > always call cdev_add and cdev_del even though the rtc code did not call
> > cdev_init. I'll have to add a guard around dev->devt in the new
> > cdev_device functions. I'll prepare another patch tomorrow.
> >
> > I also noticed that I neglected to remove the prototypes for the two RTC
> > function I removed. I'll fix that too.
>
> Ok, I'm just going to drop this series from my tree so that other
> patches in it can get pushed out to linux-next. Please resend the full
> series after you have fixed it up, and I'll be glad to queue it up
> again.
Also, when you resend, if you can collect the acks from the subsystem
maintainers, and add them to the patches, that would be very good.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: kernel test robot <fengguang.wu@intel.com>, LKP <lkp@01.org>,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
wfg@linux.intel.com
Subject: Re: [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690 kobject_put
Date: Fri, 17 Mar 2017 15:13:34 +0900 [thread overview]
Message-ID: <20170317061334.GA2847@kroah.com> (raw)
In-Reply-To: <20170317061137.GA21612@kroah.com>
On Fri, Mar 17, 2017 at 03:11:37PM +0900, Greg Kroah-Hartman wrote:
> On Thu, Mar 16, 2017 at 11:23:26PM -0600, Logan Gunthorpe wrote:
> > Hey,
> >
> > I think I see the issue here: in a couple of error conditions, the RTC
> > code will not initialize and ask for the cdev. However, my change will
> > always call cdev_add and cdev_del even though the rtc code did not call
> > cdev_init. I'll have to add a guard around dev->devt in the new
> > cdev_device functions. I'll prepare another patch tomorrow.
> >
> > I also noticed that I neglected to remove the prototypes for the two RTC
> > function I removed. I'll fix that too.
>
> Ok, I'm just going to drop this series from my tree so that other
> patches in it can get pushed out to linux-next. Please resend the full
> series after you have fixed it up, and I'll be glad to queue it up
> again.
Also, when you resend, if you can collect the acks from the subsystem
maintainers, and add them to the patches, that would be very good.
thanks,
greg k-h
next prev parent reply other threads:[~2017-03-17 6:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 4:57 [rtc-linux] [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690 kobject_put kernel test robot
2017-03-17 4:57 ` kernel test robot
2017-03-17 4:57 ` kernel test robot
2017-03-17 5:23 ` [rtc-linux] " Logan Gunthorpe
2017-03-17 5:23 ` Logan Gunthorpe
2017-03-17 6:11 ` [rtc-linux] " Greg Kroah-Hartman
2017-03-17 6:11 ` Greg Kroah-Hartman
2017-03-17 6:11 ` Greg Kroah-Hartman
2017-03-17 6:13 ` Greg Kroah-Hartman [this message]
2017-03-17 6:13 ` Greg Kroah-Hartman
2017-03-17 6:13 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317061334.GA2847@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=logang@deltatee.com \
--cc=rtc-linux@googlegroups.com \
--cc=wfg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.