All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org, linux-raid@vger.kernel.org,
	dm-devel@redhat.com, Shaohua Li <shli@kernel.org>,
	Milan Broz <gmazyland@gmail.com>,
	Alasdair Kergon <agk@redhat.com>
Subject: Re: dm crypt: remove an impossible condition
Date: Fri, 17 Mar 2017 17:38:19 -0400	[thread overview]
Message-ID: <20170317213819.GC6475@redhat.com> (raw)
In-Reply-To: <20170317204655.GA28261@mwanda>

On Fri, Mar 17 2017 at  4:46pm -0400,
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> Static checkers complain that it doesn't make sense to check if "sval"
> is NULL.  The intention was to check if strchr() returned NULL, but in
> that situation "sval" would be "NULL + 1" so the check doesn't work.  We
> know from the sscanf() that there is a ':' character in the string so
> the check is unnecessary and can be removed.
> 
> Now that the check doesn't depend on "sval" it can be moved earlier
> for readability.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks Dan, I've folded this fix into the original commit, see:
https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.12&id=cf22cd5f3afe7335afee5659f7450000e8fa2a15

I didn't add your Signed-off-by though, I can backfill that if you
like.. it is just I didn't want to taint you with all the extensive
changes in that commit.

Mike

WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org, linux-raid@vger.kernel.org,
	dm-devel@redhat.com, Shaohua Li <shli@kernel.org>,
	Milan Broz <gmazyland@gmail.com>,
	Alasdair Kergon <agk@redhat.com>
Subject: Re: dm crypt: remove an impossible condition
Date: Fri, 17 Mar 2017 21:38:19 +0000	[thread overview]
Message-ID: <20170317213819.GC6475@redhat.com> (raw)
In-Reply-To: <20170317204655.GA28261@mwanda>

On Fri, Mar 17 2017 at  4:46pm -0400,
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> Static checkers complain that it doesn't make sense to check if "sval"
> is NULL.  The intention was to check if strchr() returned NULL, but in
> that situation "sval" would be "NULL + 1" so the check doesn't work.  We
> know from the sscanf() that there is a ':' character in the string so
> the check is unnecessary and can be removed.
> 
> Now that the check doesn't depend on "sval" it can be moved earlier
> for readability.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks Dan, I've folded this fix into the original commit, see:
https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.12&idÏ22cd5f3afe7335afee5659f7450000e8fa2a15

I didn't add your Signed-off-by though, I can backfill that if you
like.. it is just I didn't want to taint you with all the extensive
changes in that commit.

Mike
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-03-17 21:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17 20:46 [PATCH] dm crypt: remove an impossible condition Dan Carpenter
2017-03-17 20:46 ` Dan Carpenter
2017-03-17 21:38 ` Mike Snitzer [this message]
2017-03-17 21:38   ` Mike Snitzer
2017-03-18  4:14   ` Dan Carpenter
2017-03-18  4:14     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170317213819.GC6475@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dm-devel@redhat.com \
    --cc=gmazyland@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=shli@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.