From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org,
alan@linux.intel.com, singhalsimran0@gmail.com,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/4] staging: atomisp: remove useless condition in if-statements
Date: Mon, 20 Mar 2017 11:14:51 +0000 [thread overview]
Message-ID: <20170320111451.GC4343@mwanda> (raw)
In-Reply-To: <20170320110006.GA17811@SEL-JYOUN-D1>
On Mon, Mar 20, 2017 at 08:00:06PM +0900, Daeseok Youn wrote:
> The css_pipe_id was checked with 'CSS_PIPE_ID_COPY' in previous if-
> statement. In this case, if the css_pipe_id equals to 'CSS_PIPE_ID_COPY',
> it could not enter the next if-statement. But the "next" if-statement
> has the condition to check whether the css_pipe_id equals to
> 'CSS_PIPE_ID_COPY' or not. It should be removed.
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
The patch is correct but the changelog is not.
s/CSS_PIPE_ID_COPY/CSS_PIPE_ID_YUVPP/
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org,
alan@linux.intel.com, singhalsimran0@gmail.com,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/4] staging: atomisp: remove useless condition in if-statements
Date: Mon, 20 Mar 2017 14:14:51 +0300 [thread overview]
Message-ID: <20170320111451.GC4343@mwanda> (raw)
In-Reply-To: <20170320110006.GA17811@SEL-JYOUN-D1>
On Mon, Mar 20, 2017 at 08:00:06PM +0900, Daeseok Youn wrote:
> The css_pipe_id was checked with 'CSS_PIPE_ID_COPY' in previous if-
> statement. In this case, if the css_pipe_id equals to 'CSS_PIPE_ID_COPY',
> it could not enter the next if-statement. But the "next" if-statement
> has the condition to check whether the css_pipe_id equals to
> 'CSS_PIPE_ID_COPY' or not. It should be removed.
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
The patch is correct but the changelog is not.
s/CSS_PIPE_ID_COPY/CSS_PIPE_ID_YUVPP/
regards,
dan carpenter
next prev parent reply other threads:[~2017-03-20 11:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 5:55 [PATCH 3/4] staging: atomisp: remove useless #ifdef ISP2401 on top of atomisp_cmd.c Daeseok Youn
2017-03-15 5:55 ` Daeseok Youn
2017-03-20 11:00 ` [PATCH 3/4] staging: atomisp: remove useless condition in if-statements Daeseok Youn
2017-03-20 11:00 ` Daeseok Youn
2017-03-20 11:14 ` Dan Carpenter [this message]
2017-03-20 11:14 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320111451.GC4343@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alan@linux.intel.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=singhalsimran0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.