From: Ido Schimmel <idosch@idosch.org>
To: Colin King <colin.king@canonical.com>
Cc: Jiri Pirko <jiri@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes
Date: Mon, 20 Mar 2017 12:16:19 +0000 [thread overview]
Message-ID: <20170320121619.GA12091@splinter.mtl.com> (raw)
In-Reply-To: <20170320113722.30311-1-colin.king@canonical.com>
On Mon, Mar 20, 2017 at 11:37:22AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The arguments packets and bytes to call mlxsw_sp_acl_rule_get_stats are
> in the wrong order. Fix this by swapping them.
>
> Detected by CoverityScan, CID#1419705 ("Arguments in wrong order")
>
> Fixes: 7c1b8eb175b69add8ea ("mlxsw: spectrum: Add support for TC flower offload statistics")
Only need first 12 characters.
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Ido Schimmel <idosch@mellanox.com>
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@idosch.org>
To: Colin King <colin.king@canonical.com>
Cc: Jiri Pirko <jiri@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes
Date: Mon, 20 Mar 2017 14:16:19 +0200 [thread overview]
Message-ID: <20170320121619.GA12091@splinter.mtl.com> (raw)
In-Reply-To: <20170320113722.30311-1-colin.king@canonical.com>
On Mon, Mar 20, 2017 at 11:37:22AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The arguments packets and bytes to call mlxsw_sp_acl_rule_get_stats are
> in the wrong order. Fix this by swapping them.
>
> Detected by CoverityScan, CID#1419705 ("Arguments in wrong order")
>
> Fixes: 7c1b8eb175b69add8ea ("mlxsw: spectrum: Add support for TC flower offload statistics")
Only need first 12 characters.
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Ido Schimmel <idosch@mellanox.com>
Thanks!
next prev parent reply other threads:[~2017-03-20 12:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 11:37 [PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes Colin King
2017-03-20 12:16 ` Ido Schimmel [this message]
2017-03-20 12:16 ` Ido Schimmel
2017-03-20 12:20 ` Jiri Pirko
2017-03-20 12:20 ` Jiri Pirko
2017-03-22 18:13 ` David Miller
2017-03-22 18:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320121619.GA12091@splinter.mtl.com \
--to=idosch@idosch.org \
--cc=colin.king@canonical.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.