From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 15/17] arm64: arch_timer: Workaround for Cortex-A73 erratum 858921
Date: Mon, 20 Mar 2017 14:58:03 +0000 [thread overview]
Message-ID: <20170320145803.GI31213@leverpostej> (raw)
In-Reply-To: <20170306112622.13853-16-marc.zyngier@arm.com>
On Mon, Mar 06, 2017 at 11:26:20AM +0000, Marc Zyngier wrote:
> Cortex-A73 (all versions) counter read can return a wrong value
> when the counter crosses a 32bit boundary.
>
> The workaround involves performing the read twice, and to return
> one or the other depending on whether a transition has taken place.
> +#ifdef CONFIG_ARM64_ERRATUM_858921
> +static u64 notrace arm64_858921_read_cntvct_el0(void)
> +{
> + u64 _old, _new;
> +
> + _old = read_sysreg(cntvct_el0);
> + _new = read_sysreg(cntvct_el0);
> + return (((_old ^ _new) >> 32) & 1) ? _old : _new;
> +}
> +#endif
Given this is a static inline, I think we can drop the underscores here.
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Scott Wood <oss@buserror.net>, Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Hanjun Guo <hanjun.guo@linaro.org>,
Ding Tianhong <dingtianhong@huawei.com>
Subject: Re: [PATCH 15/17] arm64: arch_timer: Workaround for Cortex-A73 erratum 858921
Date: Mon, 20 Mar 2017 14:58:03 +0000 [thread overview]
Message-ID: <20170320145803.GI31213@leverpostej> (raw)
In-Reply-To: <20170306112622.13853-16-marc.zyngier@arm.com>
On Mon, Mar 06, 2017 at 11:26:20AM +0000, Marc Zyngier wrote:
> Cortex-A73 (all versions) counter read can return a wrong value
> when the counter crosses a 32bit boundary.
>
> The workaround involves performing the read twice, and to return
> one or the other depending on whether a transition has taken place.
> +#ifdef CONFIG_ARM64_ERRATUM_858921
> +static u64 notrace arm64_858921_read_cntvct_el0(void)
> +{
> + u64 _old, _new;
> +
> + _old = read_sysreg(cntvct_el0);
> + _new = read_sysreg(cntvct_el0);
> + return (((_old ^ _new) >> 32) & 1) ? _old : _new;
> +}
> +#endif
Given this is a static inline, I think we can drop the underscores here.
Thanks,
Mark.
next prev parent reply other threads:[~2017-03-20 14:58 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 11:26 [PATCH 00/17] clocksource/arch_timer: Errara workaround infrastructure rework Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-06 11:26 ` [PATCH 01/17] arm64: arch_timer: Add infrastructure for multiple erratum detection methods Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-07 13:03 ` Hanjun Guo
2017-03-07 13:03 ` Hanjun Guo
2017-03-20 13:51 ` Mark Rutland
2017-03-20 13:51 ` Mark Rutland
2017-03-06 11:26 ` [PATCH 02/17] arm64: arch_timer: Add erratum handler for globally defined capability Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-06 11:26 ` [PATCH 03/17] arm64: Allow checking of a CPU-local erratum Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-20 13:56 ` Mark Rutland
2017-03-20 13:56 ` Mark Rutland
2017-03-20 14:09 ` Suzuki K Poulose
2017-03-20 14:09 ` Suzuki K Poulose
2017-03-06 11:26 ` [PATCH 04/17] arm64: arch_timer: Add erratum handler for CPU-specific capability Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-06 11:26 ` [PATCH 05/17] arm64: arch_timer: Move arch_timer_reg_read/write around Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-20 13:59 ` Mark Rutland
2017-03-20 13:59 ` Mark Rutland
2017-03-06 11:26 ` [PATCH 06/17] arm64: arch_timer: Get rid of erratum_workaround_set_sne Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-20 14:06 ` Mark Rutland
2017-03-20 14:06 ` Mark Rutland
2017-03-20 16:59 ` Marc Zyngier
2017-03-20 16:59 ` Marc Zyngier
2017-03-06 11:26 ` [PATCH 07/17] arm64: arch_timer: Rework the set_next_event workarounds Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-07 13:25 ` Hanjun Guo
2017-03-07 13:25 ` Hanjun Guo
2017-03-06 11:26 ` [PATCH 08/17] arm64: arch_timer: Make workaround methods optional Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-06 11:26 ` [PATCH 09/17] arm64: arch_timer: Allows a CPU-specific erratum to only affect a subset of CPUs Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-06 11:26 ` [PATCH 10/17] arm64: Add CNTVCT_EL0 trap handler Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-20 14:52 ` Mark Rutland
2017-03-20 14:52 ` Mark Rutland
2017-03-06 11:26 ` [PATCH 11/17] arm64: arch_timer: Move clocksource_counter and co around Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-06 11:26 ` [PATCH 12/17] arm64: arch_timer: Enable CNTVCT_EL0 trap if workaround is enabled Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-06 11:26 ` [PATCH 13/17] arm64: cpu_errata: Allow an erratum to be match for all revisions of a core Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-20 14:56 ` Mark Rutland
2017-03-20 14:56 ` Mark Rutland
2017-03-20 15:30 ` Suzuki K Poulose
2017-03-20 15:30 ` Suzuki K Poulose
2017-03-06 11:26 ` [PATCH 14/17] arm64: Define Cortex-A73 MIDR Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-06 11:26 ` [PATCH 15/17] arm64: arch_timer: Workaround for Cortex-A73 erratum 858921 Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-20 14:58 ` Mark Rutland [this message]
2017-03-20 14:58 ` Mark Rutland
2017-03-06 11:26 ` [PATCH 16/17] arm64: arch_timer: Allow erratum matching with ACPI OEM information Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-07 13:12 ` Hanjun Guo
2017-03-07 13:12 ` Hanjun Guo
2017-03-06 11:26 ` [PATCH 17/17] arm64: arch_timer: Add HISILICON_ERRATUM_161010101 ACPI matching data Marc Zyngier
2017-03-06 11:26 ` Marc Zyngier
2017-03-07 13:19 ` Hanjun Guo
2017-03-07 13:19 ` Hanjun Guo
2017-03-20 15:00 ` Mark Rutland
2017-03-20 15:00 ` Mark Rutland
2017-03-06 21:48 ` [PATCH 00/17] clocksource/arch_timer: Errara workaround infrastructure rework dann frazier
2017-03-06 21:48 ` dann frazier
2017-03-07 12:56 ` Hanjun Guo
2017-03-07 12:56 ` Hanjun Guo
2017-03-20 15:07 ` Mark Rutland
2017-03-20 15:07 ` Mark Rutland
2017-03-20 15:25 ` Marc Zyngier
2017-03-20 15:25 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320145803.GI31213@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.