* [PATCH] wireless: ipw2200: remove redundant check of rc < 0
@ 2017-02-27 23:40 Colin King
2017-03-20 17:16 ` Kalle Valo
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-02-27 23:40 UTC (permalink / raw)
To: Stanislav Yakovlev, Kalle Valo, linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The check for rc < 0 is always false so the check is redundant
and can be removed.
Detected with CoverityScan, CID#101143 ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/intel/ipw2x00/ipw2200.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
index 5ef3c5c..bbc579b 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
@@ -3539,9 +3539,6 @@ static int ipw_load(struct ipw_priv *priv)
fw_img = &fw->data[le32_to_cpu(fw->boot_size) +
le32_to_cpu(fw->ucode_size)];
- if (rc < 0)
- goto error;
-
if (!priv->rxq)
priv->rxq = ipw_rx_queue_alloc(priv);
else
--
2.10.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: ipw2200: remove redundant check of rc < 0
2017-02-27 23:40 [PATCH] wireless: ipw2200: remove redundant check of rc < 0 Colin King
@ 2017-03-20 17:16 ` Kalle Valo
0 siblings, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2017-03-20 17:16 UTC (permalink / raw)
To: Colin Ian King
Cc: Stanislav Yakovlev, linux-wireless, netdev, kernel-janitors,
linux-kernel
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check for rc < 0 is always false so the check is redundant
> and can be removed.
>
> Detected with CoverityScan, CID#101143 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
889cdff72b85 ipw2200: remove redundant check of rc < 0
--
https://patchwork.kernel.org/patch/9594495/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ipw2200: remove redundant check of rc < 0
@ 2017-03-20 17:16 ` Kalle Valo
0 siblings, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2017-03-20 17:16 UTC (permalink / raw)
To: Colin Ian King
Cc: Stanislav Yakovlev, linux-wireless, netdev, kernel-janitors,
linux-kernel
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check for rc < 0 is always false so the check is redundant
> and can be removed.
>
> Detected with CoverityScan, CID#101143 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
889cdff72b85 ipw2200: remove redundant check of rc < 0
--
https://patchwork.kernel.org/patch/9594495/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-20 17:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-27 23:40 [PATCH] wireless: ipw2200: remove redundant check of rc < 0 Colin King
2017-03-20 17:16 ` Kalle Valo
2017-03-20 17:16 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.