From: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org,
dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/2] arm64: dts: add arm/arm64 include symlinks
Date: Mon, 20 Mar 2017 16:03:37 -0700 [thread overview]
Message-ID: <20170320230337.GB78325@google.com> (raw)
In-Reply-To: <20170226060058.5841-2-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Hi,
On Sun, Feb 26, 2017 at 07:00:58AM +0100, Heiko Stuebner wrote:
> Allow including of dtsi files in an architecture-independent manner.
> Some dtsi files may be shared between architectures and one suggestion
> was to have symlinks and let these includes get accessed via a
> #include <arm64/foo.dtsi>
> So add the necessary symlinks for arm32.
>
> Suggested-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
> Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> ---
> Suggested by Olof in response to the patch adding direct symlinks
> for cros-ec includes.
>
> Tested with adapted rk3399-Gru dtsi files and while we only need this arm64
> version right now, it might make sense to already have both the arm32 and
> arm64 versions ready.
FWIW, tested fine here too (for the same platform).
I guess this works fine, if it makes people happy. It also allows some
weird #include paths. e.g.:
#include <arm64/include/arm/include/arm64/rockchip/rk3399.dtsi>
I guess we can call that an entertaining feature, and not a bug?
Reviewed-by: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Tested-by: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Where should this go? I'd like not to wait another few months before
sending my Gru/Kevin DTS again.
Brian
> arch/arm64/boot/dts/include/arm | 1 +
> arch/arm64/boot/dts/include/arm64 | 1 +
> 2 files changed, 2 insertions(+)
> create mode 120000 arch/arm64/boot/dts/include/arm
> create mode 120000 arch/arm64/boot/dts/include/arm64
>
> diff --git a/arch/arm64/boot/dts/include/arm b/arch/arm64/boot/dts/include/arm
> new file mode 120000
> index 000000000000..cf63d80e2b93
> --- /dev/null
> +++ b/arch/arm64/boot/dts/include/arm
> @@ -0,0 +1 @@
> +../../../../arm/boot/dts
> \ No newline at end of file
> diff --git a/arch/arm64/boot/dts/include/arm64 b/arch/arm64/boot/dts/include/arm64
> new file mode 120000
> index 000000000000..a96aa0ea9d8c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/include/arm64
> @@ -0,0 +1 @@
> +..
> \ No newline at end of file
> --
> 2.11.0
>
WARNING: multiple messages have this Message-ID (diff)
From: briannorris@chromium.org (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: dts: add arm/arm64 include symlinks
Date: Mon, 20 Mar 2017 16:03:37 -0700 [thread overview]
Message-ID: <20170320230337.GB78325@google.com> (raw)
In-Reply-To: <20170226060058.5841-2-heiko@sntech.de>
Hi,
On Sun, Feb 26, 2017 at 07:00:58AM +0100, Heiko Stuebner wrote:
> Allow including of dtsi files in an architecture-independent manner.
> Some dtsi files may be shared between architectures and one suggestion
> was to have symlinks and let these includes get accessed via a
> #include <arm64/foo.dtsi>
> So add the necessary symlinks for arm32.
>
> Suggested-by: Olof Johansson <olof@lixom.net>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> Suggested by Olof in response to the patch adding direct symlinks
> for cros-ec includes.
>
> Tested with adapted rk3399-Gru dtsi files and while we only need this arm64
> version right now, it might make sense to already have both the arm32 and
> arm64 versions ready.
FWIW, tested fine here too (for the same platform).
I guess this works fine, if it makes people happy. It also allows some
weird #include paths. e.g.:
#include <arm64/include/arm/include/arm64/rockchip/rk3399.dtsi>
I guess we can call that an entertaining feature, and not a bug?
Reviewed-by: Brian Norris <briannorris@chromium.org>
Tested-by: Brian Norris <briannorris@chromium.org>
Where should this go? I'd like not to wait another few months before
sending my Gru/Kevin DTS again.
Brian
> arch/arm64/boot/dts/include/arm | 1 +
> arch/arm64/boot/dts/include/arm64 | 1 +
> 2 files changed, 2 insertions(+)
> create mode 120000 arch/arm64/boot/dts/include/arm
> create mode 120000 arch/arm64/boot/dts/include/arm64
>
> diff --git a/arch/arm64/boot/dts/include/arm b/arch/arm64/boot/dts/include/arm
> new file mode 120000
> index 000000000000..cf63d80e2b93
> --- /dev/null
> +++ b/arch/arm64/boot/dts/include/arm
> @@ -0,0 +1 @@
> +../../../../arm/boot/dts
> \ No newline at end of file
> diff --git a/arch/arm64/boot/dts/include/arm64 b/arch/arm64/boot/dts/include/arm64
> new file mode 120000
> index 000000000000..a96aa0ea9d8c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/include/arm64
> @@ -0,0 +1 @@
> +..
> \ No newline at end of file
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-03-20 23:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 6:00 [PATCH 1/2] ARM: dts: add arm/arm64 include symlinks Heiko Stuebner
2017-02-26 6:00 ` Heiko Stuebner
2017-02-26 6:00 ` [PATCH 2/2] arm64: " Heiko Stuebner
2017-02-26 6:00 ` Heiko Stuebner
[not found] ` <20170226060058.5841-2-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2017-03-20 23:03 ` Brian Norris [this message]
2017-03-20 23:03 ` Brian Norris
[not found] ` <20170320230337.GB78325-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-03-22 0:20 ` Olof Johansson
2017-03-22 0:20 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320230337.GB78325@google.com \
--to=briannorris-f7+t8e8rja9g9huczpvpmw@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.