All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG
Date: Tue, 21 Mar 2017 11:51:57 +0000	[thread overview]
Message-ID: <20170321115156.GB12766@arm.com> (raw)
In-Reply-To: <CAK8P3a2d71PL4EaJ_hCAsjg3szG=0CFrLZ8U2AZvch=k3bv2gQ@mail.gmail.com>

On Tue, Mar 21, 2017 at 11:35:16AM +0100, Arnd Bergmann wrote:
> On Mon, Mar 20, 2017 at 8:09 PM, Will Deacon <will.deacon@arm.com> wrote:
> 
> >>
> >> -#define BUG() do {                           \
> >> -     _BUG_FLAGS(0);                          \
> >> -     unreachable();                          \
> >> +#define _BUG_FLAGS(flags) __BUG_FLAGS(flags)
> >
> > What is this for? I don't see _BUG_FLAGS used anywhere, but I could
> > be missing some macro expansion.
> 
> I think I accidentally left this after removing the last user from an
> intermediate
> version of the patch. Do you want me to send an updated version, or could
> you just drop this line when applying?

I suspect Catalin can do that when he takes the patch. With that fixup:

Acked-by: Will Deacon <will.deacon@arm.com>

Thanks,

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG
Date: Tue, 21 Mar 2017 11:51:57 +0000	[thread overview]
Message-ID: <20170321115156.GB12766@arm.com> (raw)
In-Reply-To: <CAK8P3a2d71PL4EaJ_hCAsjg3szG=0CFrLZ8U2AZvch=k3bv2gQ@mail.gmail.com>

On Tue, Mar 21, 2017 at 11:35:16AM +0100, Arnd Bergmann wrote:
> On Mon, Mar 20, 2017 at 8:09 PM, Will Deacon <will.deacon@arm.com> wrote:
> 
> >>
> >> -#define BUG() do {                           \
> >> -     _BUG_FLAGS(0);                          \
> >> -     unreachable();                          \
> >> +#define _BUG_FLAGS(flags) __BUG_FLAGS(flags)
> >
> > What is this for? I don't see _BUG_FLAGS used anywhere, but I could
> > be missing some macro expansion.
> 
> I think I accidentally left this after removing the last user from an
> intermediate
> version of the patch. Do you want me to send an updated version, or could
> you just drop this line when applying?

I suspect Catalin can do that when he takes the patch. With that fixup:

Acked-by: Will Deacon <will.deacon@arm.com>

Thanks,

Will

  reply	other threads:[~2017-03-21 11:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-14 21:39 [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Arnd Bergmann
2017-03-14 21:39 ` Arnd Bergmann
2017-03-20 19:09 ` Will Deacon
2017-03-20 19:09   ` Will Deacon
2017-03-21 10:35   ` Arnd Bergmann
2017-03-21 10:35     ` Arnd Bergmann
2017-03-21 11:51     ` Will Deacon [this message]
2017-03-21 11:51       ` Will Deacon
2017-03-21 14:11       ` Catalin Marinas
2017-03-21 14:11         ` Catalin Marinas
2017-03-22 14:37 ` Catalin Marinas
2017-03-22 14:37   ` Catalin Marinas
2017-03-22 14:51   ` Arnd Bergmann
2017-03-22 14:51     ` Arnd Bergmann
2017-03-22 15:32     ` Catalin Marinas
2017-03-22 15:32       ` Catalin Marinas
2017-03-22 16:29       ` Arnd Bergmann
2017-03-22 16:29         ` Arnd Bergmann
2017-03-22 16:57         ` Catalin Marinas
2017-03-22 16:57           ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170321115156.GB12766@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.