From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Dmitry Safonov <dsafonov@virtuozzo.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Adam Borowski <kilobyte@angband.pl>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrei Vagin <avagin@gmail.com>, Borislav Petkov <bp@suse.de>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCHv2] x86/mm: set x32 syscall bit in SET_PERSONALITY()
Date: Tue, 21 Mar 2017 21:40:58 +0300 [thread overview]
Message-ID: <20170321184058.GD21564@uranus.lan> (raw)
In-Reply-To: <6648805c-e0d8-5e27-9e19-602ab47937a7@virtuozzo.com>
On Tue, Mar 21, 2017 at 09:09:40PM +0300, Dmitry Safonov wrote:
>
> I guess the question comes from that we're releasing CRIU 3.0 with
> 32-bit C/R and some other cool stuff, but we don't support x32 yet.
> As we don't want release a thing that we aren't properly testing.
> So for a while we should error on dumping x32 applications.
yes
> I think, the best way for now is to check physicall address of vdso
> from /proc/.../pagemap. If it's CONFIG_VDSO=n kernel, I guess we could
> also add check for %ds from ptrace's register set. For x32 it's set to
> __USER_DS, while for native it's 0 (looking at start_thread() and
> compat_start_thread()). The application can simply change it without
> any consequence - so it's not very reliable, we could only warn at
> catching it, not rely on this.
indeed, thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Dmitry Safonov <dsafonov@virtuozzo.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Adam Borowski <kilobyte@angband.pl>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrei Vagin <avagin@gmail.com>, Borislav Petkov <bp@suse.de>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCHv2] x86/mm: set x32 syscall bit in SET_PERSONALITY()
Date: Tue, 21 Mar 2017 21:40:58 +0300 [thread overview]
Message-ID: <20170321184058.GD21564@uranus.lan> (raw)
In-Reply-To: <6648805c-e0d8-5e27-9e19-602ab47937a7@virtuozzo.com>
On Tue, Mar 21, 2017 at 09:09:40PM +0300, Dmitry Safonov wrote:
>
> I guess the question comes from that we're releasing CRIU 3.0 with
> 32-bit C/R and some other cool stuff, but we don't support x32 yet.
> As we don't want release a thing that we aren't properly testing.
> So for a while we should error on dumping x32 applications.
yes
> I think, the best way for now is to check physicall address of vdso
> from /proc/.../pagemap. If it's CONFIG_VDSO=n kernel, I guess we could
> also add check for %ds from ptrace's register set. For x32 it's set to
> __USER_DS, while for native it's 0 (looking at start_thread() and
> compat_start_thread()). The application can simply change it without
> any consequence - so it's not very reliable, we could only warn at
> catching it, not rely on this.
indeed, thanks!
next prev parent reply other threads:[~2017-03-21 18:41 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 16:37 [PATCHv2] x86/mm: set x32 syscall bit in SET_PERSONALITY() Dmitry Safonov
2017-03-21 16:37 ` Dmitry Safonov
2017-03-21 17:17 ` Cyrill Gorcunov
2017-03-21 17:17 ` Cyrill Gorcunov
2017-03-21 17:45 ` Andy Lutomirski
2017-03-21 17:45 ` Andy Lutomirski
2017-03-21 18:05 ` [Q] Figuring out task mode Cyrill Gorcunov
2017-03-21 18:05 ` Cyrill Gorcunov
2017-03-21 23:54 ` Andy Lutomirski
2017-03-21 23:54 ` Andy Lutomirski
2017-03-21 18:09 ` [PATCHv2] x86/mm: set x32 syscall bit in SET_PERSONALITY() Dmitry Safonov
2017-03-21 18:09 ` Dmitry Safonov
2017-03-21 18:40 ` Cyrill Gorcunov [this message]
2017-03-21 18:40 ` Cyrill Gorcunov
2017-03-21 18:51 ` hpa
2017-03-21 18:51 ` hpa
2017-03-21 19:07 ` Cyrill Gorcunov
2017-03-21 19:07 ` Cyrill Gorcunov
2017-03-21 19:20 ` hpa
2017-03-21 19:20 ` hpa
2017-03-21 19:19 ` Dmitry Safonov
2017-03-21 19:19 ` Dmitry Safonov
2017-03-21 19:24 ` Cyrill Gorcunov
2017-03-21 19:24 ` Cyrill Gorcunov
2017-03-21 19:34 ` Dmitry Safonov
2017-03-21 19:34 ` Dmitry Safonov
2017-03-21 19:31 ` Andy Lutomirski
2017-03-21 19:31 ` Andy Lutomirski
2017-03-21 19:34 ` Cyrill Gorcunov
2017-03-21 19:34 ` Cyrill Gorcunov
2017-03-21 19:42 ` Dmitry Safonov
2017-03-21 19:42 ` Dmitry Safonov
2017-03-21 20:04 ` Dmitry Safonov
2017-03-21 20:04 ` Dmitry Safonov
2017-03-21 18:49 ` hpa
2017-03-21 18:49 ` hpa
2017-03-21 17:27 ` hpa
2017-03-21 17:27 ` hpa
2017-03-21 17:27 ` Dmitry Safonov
2017-03-21 17:27 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321184058.GD21564@uranus.lan \
--to=gorcunov@gmail.com \
--cc=0x7f454c46@gmail.com \
--cc=avagin@gmail.com \
--cc=bp@suse.de \
--cc=dsafonov@virtuozzo.com \
--cc=hpa@zytor.com \
--cc=kilobyte@angband.pl \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.