From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mtd: nand: hynix: Fix an error code in init
Date: Thu, 23 Mar 2017 09:45:48 +0000 [thread overview]
Message-ID: <20170323104548.30aae3d0@bbrezillon> (raw)
In-Reply-To: <20170322090145.GA14520@mwanda>
On Wed, 22 Mar 2017 12:01:45 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We should be return -ENOMEM instead of success.
>
> Fixes: 626994e07480 ("mtd: nand: hynix: Add read-retry support for 1x nm MLC NANDs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
Thanks,
Boris
>
> diff --git a/drivers/mtd/nand/nand_hynix.c b/drivers/mtd/nand/nand_hynix.c
> index 2a5d0efea498..b12dc7325378 100644
> --- a/drivers/mtd/nand/nand_hynix.c
> +++ b/drivers/mtd/nand/nand_hynix.c
> @@ -270,8 +270,10 @@ static int hynix_mlc_1xnm_rr_init(struct nand_chip *chip,
> goto out;
>
> rr = kzalloc(sizeof(*rr) + (nregs * nmodes), GFP_KERNEL);
> - if (!rr)
> + if (!rr) {
> + ret = -ENOMEM;
> goto out;
> + }
>
> for (i = 0; i < nmodes; i++) {
> for (j = 0; j < nregs; j++) {
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mtd: nand: hynix: Fix an error code in init
Date: Thu, 23 Mar 2017 10:45:48 +0100 [thread overview]
Message-ID: <20170323104548.30aae3d0@bbrezillon> (raw)
In-Reply-To: <20170322090145.GA14520@mwanda>
On Wed, 22 Mar 2017 12:01:45 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We should be return -ENOMEM instead of success.
>
> Fixes: 626994e07480 ("mtd: nand: hynix: Add read-retry support for 1x nm MLC NANDs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
Thanks,
Boris
>
> diff --git a/drivers/mtd/nand/nand_hynix.c b/drivers/mtd/nand/nand_hynix.c
> index 2a5d0efea498..b12dc7325378 100644
> --- a/drivers/mtd/nand/nand_hynix.c
> +++ b/drivers/mtd/nand/nand_hynix.c
> @@ -270,8 +270,10 @@ static int hynix_mlc_1xnm_rr_init(struct nand_chip *chip,
> goto out;
>
> rr = kzalloc(sizeof(*rr) + (nregs * nmodes), GFP_KERNEL);
> - if (!rr)
> + if (!rr) {
> + ret = -ENOMEM;
> goto out;
> + }
>
> for (i = 0; i < nmodes; i++) {
> for (j = 0; j < nregs; j++) {
next prev parent reply other threads:[~2017-03-23 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 9:01 [patch] mtd: nand: hynix: Fix an error code in init Dan Carpenter
2017-03-22 9:01 ` Dan Carpenter
2017-03-22 9:53 ` Richard Weinberger
2017-03-22 9:53 ` Richard Weinberger
2017-03-23 9:45 ` Boris Brezillon [this message]
2017-03-23 9:45 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323104548.30aae3d0@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dan.carpenter@oracle.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.