All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: jiri@resnulli.us, netdev@vger.kernel.org,
	roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org,
	idosch@mellanox.com, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next 0/2] net: bridge: allow user-space to add ext learned entries
Date: Thu, 23 Mar 2017 22:00:03 +0200	[thread overview]
Message-ID: <20170323200002.GC25688@splinter.mtl.com> (raw)
In-Reply-To: <1490264833-28867-1-git-send-email-nikolay@cumulusnetworks.com>

On Thu, Mar 23, 2017 at 12:27:11PM +0200, Nikolay Aleksandrov wrote:
> Hi,
> This set adds the ability to add externally learned entries from
> user-space. For symmetry and proper function we need to allow SW entries
> to take over HW learned ones (similar to how HW can take over SW entries
> currently) which is needed for our use case (evpn) where we have pure SW
> ports and HW ports mixed in a single bridge. This does not play well with
> switchdev devices currently because there's no feedback when the entry is
> taken over, but this case has never worked anyway and feedback can be
> easily added when needed.

Yea, correct. I think we should handle FDB offload in a similar fashion
to route offload. FDBs aren't only of interest to the port to which they
point, but also to the other ports in the bridge. In your example use
case we would actually need to forward to the CPU packets that hit FDB
entries pointing to the SW ports. What would currently happen is that we
would simply flood such packets via the HW ports.

WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@idosch.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, idosch@mellanox.com, jiri@resnulli.us,
	stephen@networkplumber.org, bridge@lists.linux-foundation.org,
	roopa@cumulusnetworks.com, davem@davemloft.net
Subject: Re: [PATCH net-next 0/2] net: bridge: allow user-space to add ext learned entries
Date: Thu, 23 Mar 2017 22:00:03 +0200	[thread overview]
Message-ID: <20170323200002.GC25688@splinter.mtl.com> (raw)
In-Reply-To: <1490264833-28867-1-git-send-email-nikolay@cumulusnetworks.com>

On Thu, Mar 23, 2017 at 12:27:11PM +0200, Nikolay Aleksandrov wrote:
> Hi,
> This set adds the ability to add externally learned entries from
> user-space. For symmetry and proper function we need to allow SW entries
> to take over HW learned ones (similar to how HW can take over SW entries
> currently) which is needed for our use case (evpn) where we have pure SW
> ports and HW ports mixed in a single bridge. This does not play well with
> switchdev devices currently because there's no feedback when the entry is
> taken over, but this case has never worked anyway and feedback can be
> easily added when needed.

Yea, correct. I think we should handle FDB offload in a similar fashion
to route offload. FDBs aren't only of interest to the port to which they
point, but also to the other ports in the bridge. In your example use
case we would actually need to forward to the CPU packets that hit FDB
entries pointing to the SW ports. What would currently happen is that we
would simply flood such packets via the HW ports.

  parent reply	other threads:[~2017-03-23 20:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23 10:27 [Bridge] [PATCH net-next 0/2] net: bridge: allow user-space to add ext learned entries Nikolay Aleksandrov
2017-03-23 10:27 ` Nikolay Aleksandrov
2017-03-23 10:27 ` [Bridge] [PATCH net-next 1/2] net: bridge: allow SW learn to take over HW fdb entries Nikolay Aleksandrov
2017-03-23 10:27   ` Nikolay Aleksandrov via Bridge
2017-03-23 19:47   ` [Bridge] " Ido Schimmel
2017-03-23 19:47     ` Ido Schimmel
2017-03-23 10:27 ` [Bridge] [PATCH net-next 2/2] net: bridge: allow to add externally learned entries from user-space Nikolay Aleksandrov
2017-03-23 10:27   ` Nikolay Aleksandrov
2017-03-23 19:47   ` [Bridge] " Ido Schimmel
2017-03-23 19:47     ` Ido Schimmel
2017-03-23 12:48 ` [Bridge] [PATCH net-next 0/2] net: bridge: allow user-space to add ext learned entries Nikolay Aleksandrov
2017-03-23 12:48   ` Nikolay Aleksandrov via Bridge
2017-03-23 20:00 ` Ido Schimmel [this message]
2017-03-23 20:00   ` Ido Schimmel
2017-03-24 19:31 ` [Bridge] " David Miller
2017-03-24 19:31   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170323200002.GC25688@splinter.mtl.com \
    --to=idosch@idosch.org \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=idosch@mellanox.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.