[RESEND PATCH v2] staging:speakup: Fix alignment with parenthesis.

[RESEND PATCH v2] staging:speakup: Fix alignment with parenthesis.

[Arushi Singhal]

[-- Attachment #1: Type: text/plain, Size: 2298 bytes --]

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
changes in v2
 - change the commit message.

 drivers/staging/speakup/speakup_apollo.c | 2 +-
 drivers/staging/speakup/speakup_decext.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/speakup/speakup_apollo.c
b/drivers/staging/speakup/speakup_apollo.c
index 9cfdbbfb9742..6ad83dc642c4 100644
--- a/drivers/staging/speakup/speakup_apollo.c
+++ b/drivers/staging/speakup/speakup_apollo.c
@@ -173,7 +173,7 @@ static void do_catch_up(struct spk_synth *synth)
                if (!synth->io_ops->synth_out(synth, ch)) {
                        outb(UART_MCR_DTR, speakup_info.port_tts +
UART_MCR);
                        outb(UART_MCR_DTR | UART_MCR_RTS,
-                                       speakup_info.port_tts + UART_MCR);
+                            speakup_info.port_tts + UART_MCR);
                        schedule_timeout(msecs_to_jiffies(full_time_val));
                        continue;
                }
diff --git a/drivers/staging/speakup/speakup_decext.c
b/drivers/staging/speakup/speakup_decext.c
index 929a28d618dc..c564bf8e1531 100644
--- a/drivers/staging/speakup/speakup_decext.c
+++ b/drivers/staging/speakup/speakup_decext.c
@@ -206,11 +206,11 @@ static void do_catch_up(struct spk_synth *synth)
                                if (!in_escape)
                                        synth->io_ops->synth_out(synth,
PROCSPEECH);
                                spin_lock_irqsave(&speakup_info.spinlock,
-                                                       flags);
+                                                 flags);
                                jiffy_delta_val = jiffy_delta->u.n.value;
                                delay_time_val = delay_time->u.n.value;
                                spin_unlock_irqrestore(&
speakup_info.spinlock,
-                                                       flags);
+                                                      flags);
                                schedule_timeout(msecs_to_jiffies
                                                 (delay_time_val));
                                jiff_max = jiffies + jiffy_delta_val;
--
2.11.0

[-- Attachment #2: Type: text/html, Size: 3185 bytes --]

Re: [Outreachy kernel] [RESEND PATCH v2] staging:speakup: Fix alignment with parenthesis.

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 3522 bytes --]

It should be staging: speakup:, not staging:speakup:

On Thu, 23 Mar 2017, Arushi Singhal wrote:

> Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".

It would really be better to say what the patch does, not just say what
error message you have fixed.

julia

> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> changes in v2
>  - change the commit message.
>
>  drivers/staging/speakup/speakup_apollo.c | 2 +-
>  drivers/staging/speakup/speakup_decext.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/speakup/speakup_apollo.c
> b/drivers/staging/speakup/speakup_apollo.c
> index 9cfdbbfb9742..6ad83dc642c4 100644
> --- a/drivers/staging/speakup/speakup_apollo.c
> +++ b/drivers/staging/speakup/speakup_apollo.c
> @@ -173,7 +173,7 @@ static void do_catch_up(struct spk_synth *synth)
>                 if (!synth->io_ops->synth_out(synth, ch)) {
>                         outb(UART_MCR_DTR, speakup_info.port_tts +
> UART_MCR);
>                         outb(UART_MCR_DTR | UART_MCR_RTS,
> -                                       speakup_info.port_tts + UART_MCR);
> +                            speakup_info.port_tts + UART_MCR);
>                         schedule_timeout(msecs_to_jiffies(full_time_val));
>                         continue;
>                 }
> diff --git a/drivers/staging/speakup/speakup_decext.c
> b/drivers/staging/speakup/speakup_decext.c
> index 929a28d618dc..c564bf8e1531 100644
> --- a/drivers/staging/speakup/speakup_decext.c
> +++ b/drivers/staging/speakup/speakup_decext.c
> @@ -206,11 +206,11 @@ static void do_catch_up(struct spk_synth *synth)
>                                 if (!in_escape)
>                                         synth->io_ops->synth_out(synth,
> PROCSPEECH);
>                                 spin_lock_irqsave(&speakup_info.spinlock,
> -                                                       flags);
> +                                                 flags);
>                                 jiffy_delta_val = jiffy_delta->u.n.value;
>                                 delay_time_val = delay_time->u.n.value;
>                                
> spin_unlock_irqrestore(&speakup_info.spinlock,
> -                                                       flags);
> +                                                      flags);
>                                 schedule_timeout(msecs_to_jiffies
>                                                  (delay_time_val));
>                                 jiff_max = jiffies + jiffy_delta_val;
> --
> 2.11.0
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF9fNHFEUopsZH5rf
> iuha-Pv0WA%2B8oACvT_cNxwiSX-rjg%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Re: [RESEND PATCH v2] staging:speakup: Fix alignment with parenthesis.

[Greg Kroah-Hartman]

On Thu, Mar 23, 2017 at 07:15:38PM +0530, Arushi Singhal wrote:
> Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>

<snip>

I can't take patches sent in html format :(

please fix your email client.

thanks,

greg k-h

Re: [RESEND PATCH v2] staging:speakup: Fix alignment with parenthesis.

[Arushi Singhal]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

On Fri, Mar 24, 2017 at 2:15 AM, Greg Kroah-Hartman <
gregkh@linuxfoundation.org> wrote:

> On Thu, Mar 23, 2017 at 07:15:38PM +0530, Arushi Singhal wrote:
> > Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
> >
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
>
> <snip>
>
> I can't take patches sent in html format :(
>
> please fix your email client.
>
Hi Greg
I will forward it in required format.

>
> thanks,
>
> greg k-h
>

[-- Attachment #2: Type: text/html, Size: 1077 bytes --]