From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
alsa-devel@alsa-project.org, Timur Tabi <timur@tabi.org>,
Xiubo.Lee@gmail.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
shengjiu.wang@nxp.com, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
mihai.serban@nxp.com, Mark Brown <broonie@kernel.org>,
viorel.suman@nxp.com, fabio.estevam@nxp.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] ASoC: WM8962: Let codec driver enable/disable its MCLK
Date: Fri, 24 Mar 2017 00:54:06 -0700 [thread overview]
Message-ID: <20170324075405.GA2000@Asurada> (raw)
In-Reply-To: <CAEnQRZCPcvkGUTc5bFKuOi-W1v39LmO_gAs31J_cWe6gFVVFEw@mail.gmail.com>
On Fri, Mar 24, 2017 at 09:37:00AM +0200, Daniel Baluta wrote:
> On Fri, Mar 24, 2017 at 6:58 AM, Nicolin Chen <nicoleotsuka@gmail.com> wrote:
> > On Thu, Mar 23, 2017 at 02:01:50PM +0200, Daniel Baluta wrote:
> >> From: Nicolin Chen <b42378@freescale.com>
> >>
> >> WM8962 needs its MCLK when powerup in wm8962_resume(). Thus it's better
> >> to control the MCLK in codec driver. Thus remove the clock enable in
> >> machine dirver accordingly.
> >>
> >> While at it, get rid of imx_wm8962_remove function since it is now
> >> empty.
> >>
> >> Signed-off-by: Nicolin Chen <b42378@freescale.com>
> >
> > Hmm...it'd probably be better to let yourself be the author and remove
> > my signed-off here. Just got an email deliver failure since that email
> > address is apparently not available any more.
>
> Hi Nic,
>
> I will fix the prefix subject as suggested. Is it OK to use
> your current email address for the signed-off-by tag?
The email address in the "From" would probably still remain that one,
which causes the problem.
I personally prefer that you resend it using your own and I could give
an Ack to it. It isn't really necessary to let me take the credit :)
Thanks
Nicolin
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Timur Tabi <timur@tabi.org>,
Xiubo.Lee@gmail.com, fabio.estevam@nxp.com,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
mihai.serban@nxp.com, viorel.suman@nxp.com,
shengjiu.wang@nxp.com
Subject: Re: [PATCH] ASoC: WM8962: Let codec driver enable/disable its MCLK
Date: Fri, 24 Mar 2017 00:54:06 -0700 [thread overview]
Message-ID: <20170324075405.GA2000@Asurada> (raw)
In-Reply-To: <CAEnQRZCPcvkGUTc5bFKuOi-W1v39LmO_gAs31J_cWe6gFVVFEw@mail.gmail.com>
On Fri, Mar 24, 2017 at 09:37:00AM +0200, Daniel Baluta wrote:
> On Fri, Mar 24, 2017 at 6:58 AM, Nicolin Chen <nicoleotsuka@gmail.com> wrote:
> > On Thu, Mar 23, 2017 at 02:01:50PM +0200, Daniel Baluta wrote:
> >> From: Nicolin Chen <b42378@freescale.com>
> >>
> >> WM8962 needs its MCLK when powerup in wm8962_resume(). Thus it's better
> >> to control the MCLK in codec driver. Thus remove the clock enable in
> >> machine dirver accordingly.
> >>
> >> While at it, get rid of imx_wm8962_remove function since it is now
> >> empty.
> >>
> >> Signed-off-by: Nicolin Chen <b42378@freescale.com>
> >
> > Hmm...it'd probably be better to let yourself be the author and remove
> > my signed-off here. Just got an email deliver failure since that email
> > address is apparently not available any more.
>
> Hi Nic,
>
> I will fix the prefix subject as suggested. Is it OK to use
> your current email address for the signed-off-by tag?
The email address in the "From" would probably still remain that one,
which causes the problem.
I personally prefer that you resend it using your own and I could give
an Ack to it. It isn't really necessary to let me take the credit :)
Thanks
Nicolin
next prev parent reply other threads:[~2017-03-24 7:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 12:01 [PATCH] ASoC: WM8962: Let codec driver enable/disable its MCLK Daniel Baluta
2017-03-24 4:49 ` Nicolin Chen
2017-03-24 4:49 ` Nicolin Chen
2017-03-24 4:58 ` Nicolin Chen
2017-03-24 4:58 ` Nicolin Chen
2017-03-24 7:37 ` Daniel Baluta
2017-03-24 7:37 ` Daniel Baluta
2017-03-24 7:54 ` Nicolin Chen [this message]
2017-03-24 7:54 ` Nicolin Chen
2017-03-29 11:54 ` Applied "ASoC: imx-wm8962: Let codec driver enable/disable its MCLK" to the asoc tree Mark Brown
2017-03-29 11:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324075405.GA2000@Asurada \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mihai.serban@nxp.com \
--cc=shengjiu.wang@nxp.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.com \
--cc=viorel.suman@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.