From: Ralph Sennhauser <ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Imre Kaloz <kaloz-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan
Date: Sun, 26 Mar 2017 23:05:58 +0200 [thread overview]
Message-ID: <20170326230558.6b6c4ec6@gmail.com> (raw)
In-Reply-To: <20170324143505.GK28518-g2DYL2Zd6BY@public.gmane.org>
On Fri, 24 Mar 2017 15:35:05 +0100
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> wrote:
> > + pwm_fan {
> > /* SUNON HA4010V4-0000-C99 */
> > - compatible = "gpio-fan";
> > - gpios = <&gpio0 24 0>;
> >
> > - gpio-fan,speed-map = <0 0
> > - 4500 1>;
> > + compatible = "pwm-fan";
> > + pwms = <&gpio0 24 4000 0>;
>
> Hi Ralph
>
> I believe this last 0 is the flags parameter. Now that we have
> #pwm-cells = 1, i think this last 0 should be dropped.
>
> Andrew
Hi Andrew,
isn't the 4000 (period?) pwm-cell #2 and 0 (flags?) pwm-cell #3? I
actually expect "pwms = <&gpio0 24>;" here or "#pwm-cells = <2>;"
Ralph
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: ralph.sennhauser@gmail.com (Ralph Sennhauser)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan
Date: Sun, 26 Mar 2017 23:05:58 +0200 [thread overview]
Message-ID: <20170326230558.6b6c4ec6@gmail.com> (raw)
In-Reply-To: <20170324143505.GK28518@lunn.ch>
On Fri, 24 Mar 2017 15:35:05 +0100
Andrew Lunn <andrew@lunn.ch> wrote:
> > + pwm_fan {
> > /* SUNON HA4010V4-0000-C99 */
> > - compatible = "gpio-fan";
> > - gpios = <&gpio0 24 0>;
> >
> > - gpio-fan,speed-map = <0 0
> > - 4500 1>;
> > + compatible = "pwm-fan";
> > + pwms = <&gpio0 24 4000 0>;
>
> Hi Ralph
>
> I believe this last 0 is the flags parameter. Now that we have
> #pwm-cells = 1, i think this last 0 should be dropped.
>
> Andrew
Hi Andrew,
isn't the 4000 (period?) pwm-cell #2 and 0 (flags?) pwm-cell #3? I
actually expect "pwms = <&gpio0 24>;" here or "#pwm-cells = <2>;"
Ralph
WARNING: multiple messages have this Message-ID (diff)
From: Ralph Sennhauser <ralph.sennhauser@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: linux-gpio@vger.kernel.org, Imre Kaloz <kaloz@openwrt.org>,
Thierry Reding <thierry.reding@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jason Cooper <jason@lakedaemon.net>,
Gregory Clement <gregory.clement@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan
Date: Sun, 26 Mar 2017 23:05:58 +0200 [thread overview]
Message-ID: <20170326230558.6b6c4ec6@gmail.com> (raw)
In-Reply-To: <20170324143505.GK28518@lunn.ch>
On Fri, 24 Mar 2017 15:35:05 +0100
Andrew Lunn <andrew@lunn.ch> wrote:
> > + pwm_fan {
> > /* SUNON HA4010V4-0000-C99 */
> > - compatible = "gpio-fan";
> > - gpios = <&gpio0 24 0>;
> >
> > - gpio-fan,speed-map = <0 0
> > - 4500 1>;
> > + compatible = "pwm-fan";
> > + pwms = <&gpio0 24 4000 0>;
>
> Hi Ralph
>
> I believe this last 0 is the flags parameter. Now that we have
> #pwm-cells = 1, i think this last 0 should be dropped.
>
> Andrew
Hi Andrew,
isn't the 4000 (period?) pwm-cell #2 and 0 (flags?) pwm-cell #3? I
actually expect "pwms = <&gpio0 24>;" here or "#pwm-cells = <2>;"
Ralph
next prev parent reply other threads:[~2017-03-26 21:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 14:18 [PATCH v3 0/4] gpio: mvebu: Add PWM fan support Ralph Sennhauser
2017-03-24 14:18 ` Ralph Sennhauser
2017-03-24 14:18 ` Ralph Sennhauser
[not found] ` <20170324141815.7252-1-ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-24 14:18 ` [PATCH v3 1/4] gpio: mvebu: Add limited PWM support Ralph Sennhauser
2017-03-24 14:18 ` Ralph Sennhauser
2017-03-24 14:18 ` Ralph Sennhauser
[not found] ` <20170324141815.7252-2-ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-24 14:23 ` Andrew Lunn
2017-03-24 14:23 ` Andrew Lunn
2017-03-24 14:23 ` Andrew Lunn
2017-03-24 14:28 ` Andrew Lunn
2017-03-24 14:28 ` Andrew Lunn
2017-03-24 14:28 ` Andrew Lunn
2017-03-24 14:18 ` [PATCH v3 2/4] mvebu: xp: Add PWM properties to .dtsi files Ralph Sennhauser
2017-03-24 14:18 ` Ralph Sennhauser
2017-03-24 14:18 ` Ralph Sennhauser
2017-03-24 14:18 ` [PATCH v3 3/4] ARM: mvebu: Enable SENSORS_PWM_FAN in defconfig Ralph Sennhauser
2017-03-24 14:18 ` Ralph Sennhauser
2017-03-24 14:18 ` Ralph Sennhauser
2017-03-24 14:18 ` [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Ralph Sennhauser
2017-03-24 14:18 ` Ralph Sennhauser
[not found] ` <20170324141815.7252-5-ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-24 14:35 ` Andrew Lunn
2017-03-24 14:35 ` Andrew Lunn
2017-03-24 14:35 ` Andrew Lunn
[not found] ` <20170324143505.GK28518-g2DYL2Zd6BY@public.gmane.org>
2017-03-24 22:23 ` Ralph Sennhauser
2017-03-24 22:23 ` Ralph Sennhauser
2017-03-24 22:23 ` Ralph Sennhauser
2017-03-26 21:05 ` Ralph Sennhauser [this message]
2017-03-26 21:05 ` Ralph Sennhauser
2017-03-26 21:05 ` Ralph Sennhauser
2017-03-27 13:17 ` Andrew Lunn
2017-03-27 13:17 ` Andrew Lunn
2017-03-27 13:17 ` Andrew Lunn
2017-03-27 13:17 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170326230558.6b6c4ec6@gmail.com \
--to=ralph.sennhauser-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=andrew-g2DYL2Zd6BY@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
--cc=kaloz-p3rKhJxN3npAfugRpC6u6w@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.