From: Omar Sandoval <osandov@osandov.com>
To: Stephen Bates <sbates@raithlin.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"Damien.LeMoal@wdc.com" <Damien.LeMoal@wdc.com>
Subject: Re: [PATCH 1/2] blk-stat: convert blk-stat bucket callback to signed
Date: Mon, 27 Mar 2017 09:01:03 -0700 [thread overview]
Message-ID: <20170327160103.GA12995@vader> (raw)
In-Reply-To: <4CED8A46-D6F9-48AB-B3C9-C2546C1855FC@raithlin.com>
On Mon, Mar 27, 2017 at 04:00:08PM +0000, Stephen Bates wrote:
> Thanks for the review Omar!
>
> >>
> >> -unsigned int blk_stat_rq_ddir(const struct request *rq)
> >> +int blk_stat_rq_ddir(const struct request *rq)
> >> {
> >> - return rq_data_dir(rq);
> >> + return (int)rq_data_dir(rq);
> >
> >The cast here here isn't necessary, let's leave it off.
> >
>
> OK, I will add that in the respin!
>
> >> }
> >> EXPORT_SYMBOL_GPL(blk_stat_rq_ddir);
> >>
> >> @@ -100,6 +100,8 @@ void blk_stat_add(struct request *rq)
> >> list_for_each_entry_rcu(cb, &q->stats->callbacks, list) {
> >> if (blk_stat_is_active(cb)) {
> >> bucket = cb->bucket_fn(rq);
> >> + if (bucket < 0)
> >> + continue;
> >
> >You also need to change the declaration of bucket to int above.
> >
>
> Ummmm, it is already is an int…
Yup, I was looking at the wrong place, sorry.
WARNING: multiple messages have this Message-ID (diff)
From: osandov@osandov.com (Omar Sandoval)
Subject: [PATCH 1/2] blk-stat: convert blk-stat bucket callback to signed
Date: Mon, 27 Mar 2017 09:01:03 -0700 [thread overview]
Message-ID: <20170327160103.GA12995@vader> (raw)
In-Reply-To: <4CED8A46-D6F9-48AB-B3C9-C2546C1855FC@raithlin.com>
On Mon, Mar 27, 2017@04:00:08PM +0000, Stephen Bates wrote:
> Thanks for the review Omar!
>
> >>
> >> -unsigned int blk_stat_rq_ddir(const struct request *rq)
> >> +int blk_stat_rq_ddir(const struct request *rq)
> >> {
> >> - return rq_data_dir(rq);
> >> + return (int)rq_data_dir(rq);
> >
> >The cast here here isn't necessary, let's leave it off.
> >
>
> OK, I will add that in the respin!
>
> >> }
> >> EXPORT_SYMBOL_GPL(blk_stat_rq_ddir);
> >>
> >> @@ -100,6 +100,8 @@ void blk_stat_add(struct request *rq)
> >> list_for_each_entry_rcu(cb, &q->stats->callbacks, list) {
> >> if (blk_stat_is_active(cb)) {
> >> bucket = cb->bucket_fn(rq);
> >> + if (bucket < 0)
> >> + continue;
> >
> >You also need to change the declaration of bucket to int above.
> >
>
> Ummmm, it is already is an int?
Yup, I was looking at the wrong place, sorry.
next prev parent reply other threads:[~2017-03-27 16:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-26 2:18 [PATCH 0/2] blk-stat: Add ability to not bucket IO, add this to IO poling sbates
2017-03-26 2:18 ` sbates
2017-03-26 2:18 ` [PATCH 1/2] blk-stat: convert blk-stat bucket callback to signed sbates
2017-03-26 2:18 ` sbates
2017-03-26 2:49 ` Omar Sandoval
2017-03-26 2:49 ` Omar Sandoval
2017-03-27 16:00 ` Stephen Bates
2017-03-27 16:00 ` Stephen Bates
2017-03-27 16:01 ` Omar Sandoval [this message]
2017-03-27 16:01 ` Omar Sandoval
2017-03-26 2:18 ` [PATCH 2/2] blk-stat: add a poll_size value to the request_queue struct sbates
2017-03-26 2:18 ` sbates
2017-03-28 10:50 ` Sagi Grimberg
2017-03-28 10:50 ` Sagi Grimberg
2017-03-28 19:38 ` Stephen Bates
2017-03-28 19:38 ` Stephen Bates
2017-03-28 19:46 ` Jens Axboe
2017-03-28 19:46 ` Jens Axboe
2017-03-28 19:58 ` Stephen Bates
2017-03-28 19:58 ` Stephen Bates
2017-03-28 20:38 ` Jens Axboe
2017-03-28 20:38 ` Jens Axboe
2017-03-28 21:49 ` Stephen Bates
2017-03-28 21:52 ` Stephen Bates
2017-03-28 21:52 ` Stephen Bates
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327160103.GA12995@vader \
--to=osandov@osandov.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.