From: jszhang@marvell.com (Jisheng Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: mvneta: set rx mode during resume if interface is running
Date: Tue, 28 Mar 2017 10:27:20 +0800 [thread overview]
Message-ID: <20170328102720.71f530f8@xhacker> (raw)
In-Reply-To: <20170327.161534.60442857212281980.davem@davemloft.net>
Dear David,
On Mon, 27 Mar 2017 16:15:34 -0700 David Miller wrote:
> From: Jisheng Zhang <jszhang@marvell.com>
> Date: Mon, 27 Mar 2017 18:59:05 +0800
>
> > I found a bug by:
> >
> > 0. boot and start dhcp client
> > 1. echo mem > /sys/power/state
> > 2. resume back immediately
> > 3. don't touch dhcp client to renew the lease
> > 4. ping the gateway. No acks
> >
> > Usually, after step2, the DHCP lease isn't expired, so in theory we
> > should resume all back. But in fact, it doesn't. It turns out
> > the rx mode isn't resumed correctly. This patch fixes it by adding
> > mvneta_set_rx_mode(dev) in the resume hook if interface is running.
> >
> > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
>
> This doesn't apply cleanly to the net tree, please respin.
This patch is generated against net-next, for mvneta suspend/resume support
is added into net-next recently. I did need to use the "[PATCH net-next]" for
the patch title, will take care in the future.
Sorry for confusion,
Jisheng
WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang@marvell.com>
To: David Miller <davem@davemloft.net>
Cc: <thomas.petazzoni@free-electrons.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] net: mvneta: set rx mode during resume if interface is running
Date: Tue, 28 Mar 2017 10:27:20 +0800 [thread overview]
Message-ID: <20170328102720.71f530f8@xhacker> (raw)
In-Reply-To: <20170327.161534.60442857212281980.davem@davemloft.net>
Dear David,
On Mon, 27 Mar 2017 16:15:34 -0700 David Miller wrote:
> From: Jisheng Zhang <jszhang@marvell.com>
> Date: Mon, 27 Mar 2017 18:59:05 +0800
>
> > I found a bug by:
> >
> > 0. boot and start dhcp client
> > 1. echo mem > /sys/power/state
> > 2. resume back immediately
> > 3. don't touch dhcp client to renew the lease
> > 4. ping the gateway. No acks
> >
> > Usually, after step2, the DHCP lease isn't expired, so in theory we
> > should resume all back. But in fact, it doesn't. It turns out
> > the rx mode isn't resumed correctly. This patch fixes it by adding
> > mvneta_set_rx_mode(dev) in the resume hook if interface is running.
> >
> > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
>
> This doesn't apply cleanly to the net tree, please respin.
This patch is generated against net-next, for mvneta suspend/resume support
is added into net-next recently. I did need to use the "[PATCH net-next]" for
the patch title, will take care in the future.
Sorry for confusion,
Jisheng
WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang@marvell.com>
To: David Miller <davem@davemloft.net>
Cc: thomas.petazzoni@free-electrons.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: mvneta: set rx mode during resume if interface is running
Date: Tue, 28 Mar 2017 10:27:20 +0800 [thread overview]
Message-ID: <20170328102720.71f530f8@xhacker> (raw)
In-Reply-To: <20170327.161534.60442857212281980.davem@davemloft.net>
Dear David,
On Mon, 27 Mar 2017 16:15:34 -0700 David Miller wrote:
> From: Jisheng Zhang <jszhang@marvell.com>
> Date: Mon, 27 Mar 2017 18:59:05 +0800
>
> > I found a bug by:
> >
> > 0. boot and start dhcp client
> > 1. echo mem > /sys/power/state
> > 2. resume back immediately
> > 3. don't touch dhcp client to renew the lease
> > 4. ping the gateway. No acks
> >
> > Usually, after step2, the DHCP lease isn't expired, so in theory we
> > should resume all back. But in fact, it doesn't. It turns out
> > the rx mode isn't resumed correctly. This patch fixes it by adding
> > mvneta_set_rx_mode(dev) in the resume hook if interface is running.
> >
> > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
>
> This doesn't apply cleanly to the net tree, please respin.
This patch is generated against net-next, for mvneta suspend/resume support
is added into net-next recently. I did need to use the "[PATCH net-next]" for
the patch title, will take care in the future.
Sorry for confusion,
Jisheng
next prev parent reply other threads:[~2017-03-28 2:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 10:59 [PATCH] net: mvneta: set rx mode during resume if interface is running Jisheng Zhang
2017-03-27 10:59 ` Jisheng Zhang
2017-03-27 10:59 ` Jisheng Zhang
2017-03-27 23:15 ` David Miller
2017-03-27 23:15 ` David Miller
2017-03-28 2:27 ` Jisheng Zhang [this message]
2017-03-28 2:27 ` Jisheng Zhang
2017-03-28 2:27 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328102720.71f530f8@xhacker \
--to=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.