From: Eduardo Valentin <edubezval@gmail.com>
To: Keerthy <j-keerthy@ti.com>
Cc: tony@atomide.com, rui.zhang@intel.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
robh+dt@kernel.org, t-kristo@ti.com
Subject: Re: [PATCH v2 3/8] ARM: OMAP5: Thermal: Add slope and offset values
Date: Tue, 28 Mar 2017 21:33:04 -0700 [thread overview]
Message-ID: <20170329043302.GA1596@localhost.localdomain> (raw)
In-Reply-To: <1489046762-11288-4-git-send-email-j-keerthy@ti.com>
On Thu, Mar 09, 2017 at 01:35:57PM +0530, Keerthy wrote:
> Currently the slope and offset values for calculating the
> hot spot temperature of a particular thermal zone is part
> of driver data. Pass them here instead and obtain the values
> while of node parsing.
The patch is fine.. but
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> arch/arm/boot/dts/omap5.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index 222155c..eaff2a5 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -1127,6 +1127,15 @@
>
> &cpu_thermal {
> polling-delay = <500>; /* milliseconds */
> + coefficients = <65 (-1791)>;
I suppose you tried this change with this patch:
https://patchwork.kernel.org/patch/9619577/
?
Otherwise, I do not see how your coeff would work, right?
> };
>
> /include/ "omap54xx-clocks.dtsi"
> +
> +&gpu_thermal {
> + coefficients = <117 (-2992)>;
> +};
> +
> +&core_thermal {
> + coefficients = <0 2000>;
> +};
> --
> 1.9.1
>
WARNING: multiple messages have this Message-ID (diff)
From: edubezval@gmail.com (Eduardo Valentin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/8] ARM: OMAP5: Thermal: Add slope and offset values
Date: Tue, 28 Mar 2017 21:33:04 -0700 [thread overview]
Message-ID: <20170329043302.GA1596@localhost.localdomain> (raw)
In-Reply-To: <1489046762-11288-4-git-send-email-j-keerthy@ti.com>
On Thu, Mar 09, 2017 at 01:35:57PM +0530, Keerthy wrote:
> Currently the slope and offset values for calculating the
> hot spot temperature of a particular thermal zone is part
> of driver data. Pass them here instead and obtain the values
> while of node parsing.
The patch is fine.. but
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> arch/arm/boot/dts/omap5.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index 222155c..eaff2a5 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -1127,6 +1127,15 @@
>
> &cpu_thermal {
> polling-delay = <500>; /* milliseconds */
> + coefficients = <65 (-1791)>;
I suppose you tried this change with this patch:
https://patchwork.kernel.org/patch/9619577/
?
Otherwise, I do not see how your coeff would work, right?
> };
>
> /include/ "omap54xx-clocks.dtsi"
> +
> +&gpu_thermal {
> + coefficients = <117 (-2992)>;
> +};
> +
> +&core_thermal {
> + coefficients = <0 2000>;
> +};
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-03-29 4:33 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 8:05 [PATCH v2 0/8] thermal: ti-soc-thermal: Migrate slope/offset data to device tree Keerthy
2017-03-09 8:05 ` Keerthy
2017-03-09 8:05 ` Keerthy
2017-03-09 8:05 ` [PATCH v2 1/8] arm: dts: omap3: Add cpu_thermal zone Keerthy
2017-03-09 8:05 ` Keerthy
2017-03-09 8:05 ` Keerthy
2017-03-09 8:05 ` [PATCH v2 2/8] ARM: DRA7: Thermal: Add slope and offset values Keerthy
2017-03-09 8:05 ` Keerthy
2017-03-09 8:05 ` Keerthy
2017-03-09 8:05 ` [PATCH v2 3/8] ARM: OMAP5: " Keerthy
2017-03-09 8:05 ` Keerthy
2017-03-09 8:05 ` Keerthy
2017-03-29 4:33 ` Eduardo Valentin [this message]
2017-03-29 4:33 ` Eduardo Valentin
2017-03-30 3:27 ` Keerthy
2017-03-30 3:27 ` Keerthy
2017-03-30 3:27 ` Keerthy
2017-03-09 8:05 ` [PATCH v2 4/8] ARM: OMAP443x: " Keerthy
2017-03-09 8:05 ` Keerthy
2017-03-09 8:05 ` Keerthy
2017-03-09 8:05 ` [PATCH v2 5/8] ARM: OMAP4460: " Keerthy
2017-03-09 8:05 ` Keerthy
2017-03-09 8:05 ` Keerthy
2017-03-09 8:06 ` [PATCH v2 6/8] thermal: ti-soc-thermal: Fetch slope and offset from DT Keerthy
2017-03-09 8:06 ` Keerthy
2017-03-09 8:06 ` Keerthy
2017-03-09 8:06 ` [PATCH v2 7/8] thermal: ti-soc-thermal: Remove redundant constants Keerthy
2017-03-09 8:06 ` Keerthy
2017-03-09 8:06 ` Keerthy
2017-03-09 8:06 ` [PATCH v2 8/8] thermal: ti-soc-thermal: Remove redundant code Keerthy
2017-03-09 8:06 ` Keerthy
2017-03-09 8:06 ` Keerthy
2017-03-22 3:42 ` [PATCH v2 0/8] thermal: ti-soc-thermal: Migrate slope/offset data to device tree Keerthy
2017-03-22 3:42 ` Keerthy
2017-03-22 3:42 ` Keerthy
2017-03-23 20:52 ` Tony Lindgren
2017-03-23 20:52 ` Tony Lindgren
2017-03-23 20:52 ` Tony Lindgren
2017-03-24 3:26 ` Keerthy
2017-03-24 3:26 ` Keerthy
2017-03-24 3:26 ` Keerthy
2017-03-24 14:26 ` Tony Lindgren
2017-03-24 14:26 ` Tony Lindgren
2017-03-29 4:37 ` Eduardo Valentin
2017-03-29 4:37 ` Eduardo Valentin
2017-03-30 3:29 ` Keerthy
2017-03-30 3:29 ` Keerthy
2017-03-30 3:29 ` Keerthy
2017-03-30 4:46 ` Eduardo Valentin
2017-03-30 4:46 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329043302.GA1596@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.