From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Minchan Kim <minchan@kernel.org>, Yisheng Xie <xieyisheng1@huawei.com>
Cc: ngupta@vflare.org, sergey.senozhatsky.work@gmail.com,
linux-mm@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Xishi Qiu <qiuxishi@huawei.com>,
Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [RFC]mm/zsmalloc,: trigger BUG_ON in function zs_map_object.
Date: Wed, 29 Mar 2017 15:42:06 +0900 [thread overview]
Message-ID: <20170329064206.GA512@tigerII.localdomain> (raw)
In-Reply-To: <20170329002029.GA18979@bbox>
On (03/29/17 09:20), Minchan Kim wrote:
> Hello,
>
> On Tue, Mar 28, 2017 at 03:20:22PM +0800, Yisheng Xie wrote:
> > Hi, all,
> >
> > We had backport the no-lru migration to linux-4.1, meanwhile change the
> > ZS_MAX_ZSPAGE_ORDER to 3. Then we met a BUG_ON(!page[1]).
>
> Hmm, I don't know how you backported.
>
> There isn't any problem with default ZS_MAX_ZSPAGE_ORDER. Right?
> So, it happens only if you changed it to 3?
I agree with Minchan. too much things could have gone wrong during the backport.
> Could you tell me what is your base kernel? and what zram/zsmalloc
> version(ie, from what kernel version) you backported to your
> base kernel?
agree again.
Yisheng, do you have this commit applied?
commit c102f07ca0b04f2cb49cfc161c83f6239d17f491
Author: Junil Lee <junil0814.lee@lge.com>
Date: Wed Jan 20 14:58:18 2016 -0800
zsmalloc: fix migrate_zspage-zs_free race condition
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Minchan Kim <minchan@kernel.org>, Yisheng Xie <xieyisheng1@huawei.com>
Cc: ngupta@vflare.org, sergey.senozhatsky.work@gmail.com,
linux-mm@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Xishi Qiu <qiuxishi@huawei.com>,
Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [RFC]mm/zsmalloc,: trigger BUG_ON in function zs_map_object.
Date: Wed, 29 Mar 2017 15:42:06 +0900 [thread overview]
Message-ID: <20170329064206.GA512@tigerII.localdomain> (raw)
In-Reply-To: <20170329002029.GA18979@bbox>
On (03/29/17 09:20), Minchan Kim wrote:
> Hello,
>
> On Tue, Mar 28, 2017 at 03:20:22PM +0800, Yisheng Xie wrote:
> > Hi, all,
> >
> > We had backport the no-lru migration to linux-4.1, meanwhile change the
> > ZS_MAX_ZSPAGE_ORDER to 3. Then we met a BUG_ON(!page[1]).
>
> Hmm, I don't know how you backported.
>
> There isn't any problem with default ZS_MAX_ZSPAGE_ORDER. Right?
> So, it happens only if you changed it to 3?
I agree with Minchan. too much things could have gone wrong during the backport.
> Could you tell me what is your base kernel? and what zram/zsmalloc
> version(ie, from what kernel version) you backported to your
> base kernel?
agree again.
Yisheng, do you have this commit applied?
commit c102f07ca0b04f2cb49cfc161c83f6239d17f491
Author: Junil Lee <junil0814.lee@lge.com>
Date: Wed Jan 20 14:58:18 2016 -0800
zsmalloc: fix migrate_zspage-zs_free race condition
-ss
next prev parent reply other threads:[~2017-03-29 6:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 7:20 [RFC]mm/zsmalloc,: trigger BUG_ON in function zs_map_object Yisheng Xie
2017-03-28 7:20 ` Yisheng Xie
2017-03-29 0:20 ` Minchan Kim
2017-03-29 0:20 ` Minchan Kim
2017-03-29 6:42 ` Sergey Senozhatsky [this message]
2017-03-29 6:42 ` Sergey Senozhatsky
2017-03-29 7:53 ` Yisheng Xie
2017-03-29 7:53 ` Yisheng Xie
2017-03-29 7:51 ` Yisheng Xie
2017-03-29 7:51 ` Yisheng Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329064206.GA512@tigerII.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=qiuxishi@huawei.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.