* [PATCH]: staging: media: css2400: fix checkpatch error
@ 2017-03-29 5:36 Haim Daniel
2017-03-29 7:12 ` [PATCH v2] [media] staging: " Haim Daniel
2017-03-29 7:38 ` [PATCH]: staging: media: " Greg KH
0 siblings, 2 replies; 6+ messages in thread
From: Haim Daniel @ 2017-03-29 5:36 UTC (permalink / raw)
To: mchehab, gregkh, linux-media, devel
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: 0001-media-staging-css2400-fix-checkpatch-error.patch --]
[-- Type: text/x-patch, Size: 1576 bytes --]
>From 41d35b455f8eb139912909639e914469ef5e06fb Mon Sep 17 00:00:00 2001
From: Haim Daniel <haimdaniel@gmail.com>
Date: Tue, 28 Mar 2017 19:27:57 +0300
Subject: [PATCH] [media] staging: css2400: fix checkpatch error
isp_capture_defs.h:
enclose macro with complex values in parentheses.
Signed-off-by: Haim Daniel <haimdaniel@gmail.com>
---
.../pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
index aa413df..78cbbf6 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
@@ -19,7 +19,7 @@
#define _ISP_CAPTURE_BITS_PER_ELEM 32 /* only for data, not SOP */
#define _ISP_CAPTURE_BYTES_PER_ELEM (_ISP_CAPTURE_BITS_PER_ELEM/8 )
#define _ISP_CAPTURE_BYTES_PER_WORD 32 /* 256/8 */
-#define _ISP_CAPTURE_ELEM_PER_WORD _ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM
+#define _ISP_CAPTURE_ELEM_PER_WORD (_ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM)
//#define CAPT_RCV_ACK 1
//#define CAPT_WRT_ACK 2
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] [media] staging: css2400: fix checkpatch error
2017-03-29 5:36 [PATCH]: staging: media: css2400: fix checkpatch error Haim Daniel
@ 2017-03-29 7:12 ` Haim Daniel
2017-03-29 7:28 ` Greg KH
2017-03-29 7:38 ` [PATCH]: staging: media: " Greg KH
1 sibling, 1 reply; 6+ messages in thread
From: Haim Daniel @ 2017-03-29 7:12 UTC (permalink / raw)
To: mchehab, gregkh, linux-media, devel; +Cc: Haim Daniel
isp_capture_defs.h:
fix checkpatch ERROR:
Macros with complex values should be enclosed in parentheses
Signed-off-by: Haim Daniel <haimdaniel@gmail.com>
---
.../pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
index aa413df..78cbbf6 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
@@ -19,7 +19,7 @@
#define _ISP_CAPTURE_BITS_PER_ELEM 32 /* only for data, not SOP */
#define _ISP_CAPTURE_BYTES_PER_ELEM (_ISP_CAPTURE_BITS_PER_ELEM/8 )
#define _ISP_CAPTURE_BYTES_PER_WORD 32 /* 256/8 */
-#define _ISP_CAPTURE_ELEM_PER_WORD _ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM
+#define _ISP_CAPTURE_ELEM_PER_WORD (_ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM)
//#define CAPT_RCV_ACK 1
//#define CAPT_WRT_ACK 2
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] [media] staging: css2400: fix checkpatch error
2017-03-29 7:12 ` [PATCH v2] [media] staging: " Haim Daniel
@ 2017-03-29 7:28 ` Greg KH
2017-03-29 7:50 ` [PATCH v3] " Haim Daniel
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2017-03-29 7:28 UTC (permalink / raw)
To: Haim Daniel; +Cc: mchehab, linux-media, devel
On Wed, Mar 29, 2017 at 10:12:28AM +0300, Haim Daniel wrote:
> isp_capture_defs.h:
What is this line for?
> fix checkpatch ERROR:
Trailing whitespace?
> Macros with complex values should be enclosed in parentheses
>
> Signed-off-by: Haim Daniel <haimdaniel@gmail.com>
> ---
> .../pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
> index aa413df..78cbbf6 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
> @@ -19,7 +19,7 @@
> #define _ISP_CAPTURE_BITS_PER_ELEM 32 /* only for data, not SOP */
> #define _ISP_CAPTURE_BYTES_PER_ELEM (_ISP_CAPTURE_BITS_PER_ELEM/8 )
> #define _ISP_CAPTURE_BYTES_PER_WORD 32 /* 256/8 */
> -#define _ISP_CAPTURE_ELEM_PER_WORD _ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM
> +#define _ISP_CAPTURE_ELEM_PER_WORD (_ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM)
Does this change really make sense? Why keep the trailing whitespace if
you touch the line?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3] [media] staging: css2400: fix checkpatch error
2017-03-29 7:28 ` Greg KH
@ 2017-03-29 7:50 ` Haim Daniel
2017-04-18 11:31 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Haim Daniel @ 2017-03-29 7:50 UTC (permalink / raw)
To: mchehab, gregkh, linux-media, devel; +Cc: Haim Daniel
isp_capture_defs.h: clean up ERROR: Macros with complex values should be enclosed in parentheses
Signed-off-by: Haim Daniel <haimdaniel@gmail.com>
---
.../pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
index aa413df..117c7a2 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
@@ -19,7 +19,7 @@
#define _ISP_CAPTURE_BITS_PER_ELEM 32 /* only for data, not SOP */
#define _ISP_CAPTURE_BYTES_PER_ELEM (_ISP_CAPTURE_BITS_PER_ELEM/8 )
#define _ISP_CAPTURE_BYTES_PER_WORD 32 /* 256/8 */
-#define _ISP_CAPTURE_ELEM_PER_WORD _ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM
+#define _ISP_CAPTURE_ELEM_PER_WORD (_ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM)
//#define CAPT_RCV_ACK 1
//#define CAPT_WRT_ACK 2
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3] [media] staging: css2400: fix checkpatch error
2017-03-29 7:50 ` [PATCH v3] " Haim Daniel
@ 2017-04-18 11:31 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2017-04-18 11:31 UTC (permalink / raw)
To: Haim Daniel; +Cc: mchehab, linux-media, devel
On Wed, Mar 29, 2017 at 10:50:08AM +0300, Haim Daniel wrote:
> isp_capture_defs.h: clean up ERROR: Macros with complex values should be enclosed in parentheses
>
> Signed-off-by: Haim Daniel <haimdaniel@gmail.com>
> ---
> .../pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
> index aa413df..117c7a2 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
> @@ -19,7 +19,7 @@
> #define _ISP_CAPTURE_BITS_PER_ELEM 32 /* only for data, not SOP */
> #define _ISP_CAPTURE_BYTES_PER_ELEM (_ISP_CAPTURE_BITS_PER_ELEM/8 )
> #define _ISP_CAPTURE_BYTES_PER_WORD 32 /* 256/8 */
> -#define _ISP_CAPTURE_ELEM_PER_WORD _ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM
> +#define _ISP_CAPTURE_ELEM_PER_WORD (_ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM)
Why only fix one of these instances?
And why is this define even needed? No one touches it, right?
Also, please cc: Alan on patches to this driver when you resend. You
are using scripts/get_maintainer.pl, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH]: staging: media: css2400: fix checkpatch error
2017-03-29 5:36 [PATCH]: staging: media: css2400: fix checkpatch error Haim Daniel
2017-03-29 7:12 ` [PATCH v2] [media] staging: " Haim Daniel
@ 2017-03-29 7:38 ` Greg KH
1 sibling, 0 replies; 6+ messages in thread
From: Greg KH @ 2017-03-29 7:38 UTC (permalink / raw)
To: Haim Daniel; +Cc: mchehab, linux-media, devel
On Wed, Mar 29, 2017 at 08:36:27AM +0300, Haim Daniel wrote:
> >From 41d35b455f8eb139912909639e914469ef5e06fb Mon Sep 17 00:00:00 2001
> From: Haim Daniel <haimdaniel@gmail.com>
> Date: Tue, 28 Mar 2017 19:27:57 +0300
> Subject: [PATCH] [media] staging: css2400: fix checkpatch error
>
> isp_capture_defs.h:
What is this line for?
>
> enclose macro with complex values in parentheses.
>
> Signed-off-by: Haim Daniel <haimdaniel@gmail.com>
> ---
> .../pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Please don't attach your patch, use 'git send-email' to send it
properly.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-18 11:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-29 5:36 [PATCH]: staging: media: css2400: fix checkpatch error Haim Daniel
2017-03-29 7:12 ` [PATCH v2] [media] staging: " Haim Daniel
2017-03-29 7:28 ` Greg KH
2017-03-29 7:50 ` [PATCH v3] " Haim Daniel
2017-04-18 11:31 ` Greg KH
2017-03-29 7:38 ` [PATCH]: staging: media: " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.