All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Dmitry Vyukov <dvyukov@google.com>,
	peterz@infradead.org, mingo@redhat.com,
	akpm@linux-foundation.org, will.deacon@arm.com,
	aryabinin@virtuozzo.com, kasan-dev@googlegroups.com,
	linux-kernel@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 4/8] asm-generic: add atomic-instrumented.h
Date: Wed, 29 Mar 2017 14:27:18 +0100	[thread overview]
Message-ID: <20170329132718.GI23442@leverpostej> (raw)
In-Reply-To: <20170328213513.GB12803@bombadil.infradead.org>

On Tue, Mar 28, 2017 at 02:35:13PM -0700, Matthew Wilcox wrote:
> On Tue, Mar 28, 2017 at 06:15:41PM +0200, Dmitry Vyukov wrote:
> > The new header allows to wrap per-arch atomic operations
> > and add common functionality to all of them.
> 
> Why a new header instead of putting this in linux/atomic.h?

The idea was that doing it this way allowed architectures to switch over
to the arch_* naming without a flag day. Currently this only matters for
KASAN, which is only supported by a couple of architectures (arm64,
x86).

I seem to recall that there was an issue that prevented us from solving
this with ifdeffery early in linux/atomic.h like:

#ifdef arch_op
#define op(...) ({ 		\
	kasna_whatever(...)	\
	arch_op(...)		\
})
#endif

... but I can't recall specifically what it was.

Thanks,
Mark.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Dmitry Vyukov <dvyukov@google.com>,
	peterz@infradead.org, mingo@redhat.com,
	akpm@linux-foundation.org, will.deacon@arm.com,
	aryabinin@virtuozzo.com, kasan-dev@googlegroups.com,
	linux-kernel@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 4/8] asm-generic: add atomic-instrumented.h
Date: Wed, 29 Mar 2017 14:27:18 +0100	[thread overview]
Message-ID: <20170329132718.GI23442@leverpostej> (raw)
In-Reply-To: <20170328213513.GB12803@bombadil.infradead.org>

On Tue, Mar 28, 2017 at 02:35:13PM -0700, Matthew Wilcox wrote:
> On Tue, Mar 28, 2017 at 06:15:41PM +0200, Dmitry Vyukov wrote:
> > The new header allows to wrap per-arch atomic operations
> > and add common functionality to all of them.
> 
> Why a new header instead of putting this in linux/atomic.h?

The idea was that doing it this way allowed architectures to switch over
to the arch_* naming without a flag day. Currently this only matters for
KASAN, which is only supported by a couple of architectures (arm64,
x86).

I seem to recall that there was an issue that prevented us from solving
this with ifdeffery early in linux/atomic.h like:

#ifdef arch_op
#define op(...) ({ 		\
	kasna_whatever(...)	\
	arch_op(...)		\
})
#endif

... but I can't recall specifically what it was.

Thanks,
Mark.

  parent reply	other threads:[~2017-03-29 13:27 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28 16:15 [PATCH 0/8] x86, kasan: add KASAN checks to atomic operations Dmitry Vyukov
2017-03-28 16:15 ` [PATCH 1/8] x86: remove unused atomic_inc_short() Dmitry Vyukov
2017-03-28 16:15 ` [PATCH 2/8] x86: un-macro-ify atomic ops implementation Dmitry Vyukov
2017-03-28 16:15 ` [PATCH 3/8] x86: use long long for 64-bit atomic ops Dmitry Vyukov
2017-03-28 16:15   ` Dmitry Vyukov
2017-03-28 21:32   ` Matthew Wilcox
2017-03-28 21:32     ` Matthew Wilcox
2017-05-26 19:29     ` Dmitry Vyukov
2017-05-26 19:29       ` Dmitry Vyukov
2017-03-28 16:15 ` [PATCH 4/8] asm-generic: add atomic-instrumented.h Dmitry Vyukov
2017-03-28 16:15   ` Dmitry Vyukov
2017-03-28 21:35   ` Matthew Wilcox
2017-03-28 21:35     ` Matthew Wilcox
2017-03-29  8:21     ` Dmitry Vyukov
2017-03-29  8:21       ` Dmitry Vyukov
2017-03-29 13:27     ` Mark Rutland [this message]
2017-03-29 13:27       ` Mark Rutland
2017-03-29 17:15   ` Mark Rutland
2017-03-29 17:15     ` Mark Rutland
2017-03-30  6:43     ` Ingo Molnar
2017-03-30  6:43       ` Ingo Molnar
2017-03-30 10:40       ` Mark Rutland
2017-03-30 10:40         ` Mark Rutland
2017-03-28 16:15 ` [PATCH 5/8] x86: switch atomic.h to use atomic-instrumented.h Dmitry Vyukov
2017-03-28 16:15   ` Dmitry Vyukov
2017-03-28 16:25   ` Dmitry Vyukov
2017-03-28 16:25     ` Dmitry Vyukov
2017-03-29 13:37     ` Mark Rutland
2017-03-29 13:37       ` Mark Rutland
2017-05-26 19:28       ` Dmitry Vyukov
2017-05-26 19:28         ` Dmitry Vyukov
2017-03-28 16:15 ` [PATCH 6/8] kasan: allow kasan_check_read/write() to accept pointers to volatiles Dmitry Vyukov
2017-03-28 16:15   ` Dmitry Vyukov
2017-03-28 16:15 ` [PATCH 7/8] asm-generic: add KASAN instrumentation to atomic operations Dmitry Vyukov
2017-03-28 16:15   ` Dmitry Vyukov
2017-03-29 14:00   ` Mark Rutland
2017-03-29 14:00     ` Mark Rutland
2017-03-29 15:52     ` Dmitry Vyukov
2017-03-29 15:52       ` Dmitry Vyukov
2017-03-29 15:56       ` Mark Rutland
2017-03-29 15:56         ` Mark Rutland
2017-03-28 16:15 ` [PATCH 8/8] asm-generic, x86: add comments for atomic instrumentation Dmitry Vyukov
2017-03-28 16:15   ` Dmitry Vyukov
2017-03-28 16:26 ` [PATCH 0/8] x86, kasan: add KASAN checks to atomic operations Dmitry Vyukov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170329132718.GI23442@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=dvyukov@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=will.deacon@arm.com \
    --cc=willy@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.